Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25292

Atomic CREATE OR REPLACE TABLE

Details

    Description

      Atomic drop table (MDEV-23844) does not recover the replaced table if CREATE OR REPLACE TABLE fails.

      This is because current, as before, CREATE OR REPLACE TABLE foo ... is implemented as:

      DROP TABLE IF EXISTS foo;
      CREATE TABLE foo ..

      Because of that failed CREATE OR REPLACE TABLE or a crash during the create will lead to lost table, if the original table existed.

      This task equips table drop with backing up the old table until the new table was successfully created.

      In other words, this task ensures that if one executes CREATE OR REPLACE TABLE foo on an existing table, the table foo will either be the new or old table after the statement has executed, including in the cases the CREATE fails or the server crashes.

      NOTE: this change was in a preview release for MariaDB Community Server 10.10.0, but could not be added to 10.10 RC

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-4259 transactional DDL

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. MDEV-19191 Partitioning in child tables with foreign keys

          • Critical - Crashes, loss of data, severe memory leak.
          • In Review

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27180 Fully atomic partitioning DDL operations

          • Critical - Crashes, loss of data, severe memory leak.
          • In Review

          Task - A task that needs to be done. MDEV-31138 Enable the test spider/bugfix.mdev_29676 once MDEV-25292 is pushed

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36069 Remove dict_table_t::n_ref_count; implement event based table eviction

          • Major - Major loss of function.
          • Open
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28933 CREATE OR REPLACE fails to recreate same constraint name

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28952 Assertion `t->s->tmp_table || thd->mdl_context.is_lock_owner(MDL_key::TABLE, t->s->db.str, t->s->table_name.str, t->reginfo.lock_type >= TL_WRITE_ALLOW_WRITE ? MDL_SHARED_WRITE : MDL_SHARED_READ)' failed

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28956 Locking is broken if CREATE OR REPLACE fails under LOCK TABLES

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29544 SIGSEGV in HA_CREATE_INFO::finalize_locked_tables

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29620 Assertion `next_insert_id == 0' failed in handler::ha_external_lock

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29628 Memory leak after CREATE OR REPLACE with foreign key

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29664 Assertion `!n_mysql_tables_in_use' failed in innobase_close_connection

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29676 Dual thread hang in 'closing tables' and 'Waiting for table metadata lock' on Spider CREATE OR REPLACE TABLE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29680 ASAN heap-use-after-free in myrocks::Rdb_transaction::on_commit upon CREATE OR REPLACE .. SELECT

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29698 Server crash or assertion failure upon CREATE OR REPLACE with a MERGE table

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29699 Assertion `!table_list->table || frm.str || !atomic_replace' failed upon CREATE OR REPLACE with ARCHIVE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29701 Inconsistencies and eventual failure upon CREATE OR REPLACE with foreign keys

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29709 Unexpected ER_NO_SUCH_TABLE on CREATE OR REPLACE with further assertion failures

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29758 CREATE OR REPLACE .. SELECT of Federated table doesn't store selected values

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29767 CREATE OR REPLACE bypasses S3 restriction for table creation

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29770 Broken table cannot be CREATE OR REPLACE -ed anymore

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29772 CREATE OR REPLACE not atomic for sequences (a.k.a tables with SEQUENCE=1)

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29779 Unexpected ER_ERROR_ON_RENAME upon CREATE OR REPLACE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29781 Server crashes in ha_myisammrg::add_children_list upon CREATE OR REPLACE with MERGE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29783 ER_NO_SUCH_TABLE_IN_ENGINE after failed CREATE OR REPLACE with FK violation

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29787 CREATE OR REPLACE does not work with custom DATA/INDEX DIRECTORY

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29791 ER_NO_SUCH_TABLE_IN_ENGINE or "File not found" upon concurrent DDL with CREATE OR REPLACE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29793 Assertion failure in translog_write_record upon CREATE OR REPLACE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29800 ERROR 1062 (23000): Duplicate entry 'test-t-0' for key 'PRIMARY' on CoR for Spider table, DDL_LOG: Got error 1032 or 12524 when trying to execute action for entry 1/2/3/4/5/6/7 of type 'rename table'

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29802 #sql-backup tables are visible upon CREATE OR REPLACE and get stuck in S3 storage

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29824 Galera crashes when running CoR for a locked table

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29831 Galera crashes when running CoR for a locked table after setting the minimum memory for a user session

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Technical task - A technical task. MDEV-28753 Review InnoDB changes for MDEV-25292

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28933 CREATE OR REPLACE fails to recreate same constraint name

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29824 Galera crashes when running CoR for a locked table

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29831 Galera crashes when running CoR for a locked table after setting the minimum memory for a user session

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-35854 Clean up some DDL code around FOREIGN KEY constraints

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is part of

          New Feature - A new feature of the product, which has yet to be developed. MDEV-25921 Implement CREATE TABLE...SELECT in one transaction

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33432 Erroneous CREATE OR REPLACE can cause replication abort

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35895 purge_sys_t::close_and_reopen() can busy loop for a long time

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. MDEV-36099 Ensure that creation and usage of temporary tables in replication is predictable

          • Major - Major loss of function.
          • In Testing

          Task - A task that needs to be done. MDEV-24576 Atomic CREATE TABLE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25595 DROP part of failed CREATE OR REPLACE is not written into binary log

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 25 older comments
            monty Michael Widenius added a comment -

            bb-11.8-monty pushed for QA testing.

            monty Michael Widenius added a comment - bb-11.8-monty pushed for QA testing.
            monty Michael Widenius added a comment -

            bb-11.8-monty updated
            All known things are fixed, except the mdl locks that InnoDB needs.

            monty Michael Widenius added a comment - bb-11.8-monty updated All known things are fixed, except the mdl locks that InnoDB needs.
            serg Sergei Golubchik added a comment - - edited

            See commits
            https://github.com/MariaDB/server/commit/6ff731317239
            https://github.com/MariaDB/server/commit/5ed14c2fdeff
            https://github.com/MariaDB/server/commit/a6b0394cffb4
            https://github.com/MariaDB/server/commit/59e3b88fbd8e
            https://github.com/MariaDB/server/commit/9c3281fc9679
            https://github.com/MariaDB/server/commit/c0fe20dbf24

            Please, consider cherry-picking them into bb-11.8-monty

            serg Sergei Golubchik added a comment - - edited See commits https://github.com/MariaDB/server/commit/6ff731317239 https://github.com/MariaDB/server/commit/5ed14c2fdeff https://github.com/MariaDB/server/commit/a6b0394cffb4 https://github.com/MariaDB/server/commit/59e3b88fbd8e https://github.com/MariaDB/server/commit/9c3281fc9679 https://github.com/MariaDB/server/commit/c0fe20dbf24 Please, consider cherry-picking them into bb-11.8-monty
            monty Michael Widenius added a comment - - edited

            Merge of the above commits are now done. Each change has been added to it's original commit
            pushed to bb-11.8-monty

            monty Michael Widenius added a comment - - edited Merge of the above commits are now done. Each change has been added to it's original commit pushed to bb-11.8-monty
            monty Michael Widenius added a comment -

            bb-main-monty is now updated to latest main.

            monty Michael Widenius added a comment - bb-main-monty is now updated to latest main.

            People

              elenst Elena Stepanova
              midenok Aleksey Midenkov
              Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.