Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26178

Spider: remove unnecessary #ifdef and dead code in #ifdef

Details

    Description

      Remove unnecessary #ifdefs and dead code, in Spider, which is protected by #ifdef.

      Some time ago, the Spider was a separate project, and Kentoku tried to make it compile on many MySQL and MariaDB versions without changes. So, there are many #ifdef macro in the Spider codebase, which were to adjust Spider for changes in API over different server versions. For example, see ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC. Now, the Spider is part of the source tree, and thus we can remove dead code in #ifdef.

      Use unifdef as far as possible.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-26858 Spider: Remove dead code related to HandlerSocket

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-26912 Spider: Remove dead code related to Oracle OCI

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-27474 Spider: remove #WITH_PARTITION_STORAGE_ENGINE

          • Major - Major loss of function.
          • Closed
          1.
          		 Spider: remove #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= ${VERSION} Technical task Closed Nayuta Yanagisawa (Inactive)
          2.
          		 Spider: remove #if MYSQL_VERSION_ID < ${VERSION} Technical task Closed Nayuta Yanagisawa (Inactive)
          3.
          		 Spider: remove #ifdef WITHOUT_SPIDER_BG_SEARCH Technical task Closed Nayuta Yanagisawa (Inactive)
          4.
          		 Spider: remove #ifdef HA_CAN_BULK_ACCESS Technical task Closed Nayuta Yanagisawa (Inactive)
          5.
          		 Spider: remove #ifdef HANDLER_HAS_DIRECT_AGGREGATE Technical task Closed Nayuta Yanagisawa (Inactive)
          6.
          		 Spider: remove #ifdef HA_MRR_USE_DEFAULT_IMPL Technical task Closed Nayuta Yanagisawa (Inactive)
          7.
          		 Spider: remove #ifdef SPIDER_HAS_HASH_VALUE_TYPE Technical task Closed Nayuta Yanagisawa (Inactive)
          8.
          		 Spider: remove #ifdef HANDLER_HAS_DIRECT_UPDATE_ROWS Technical task Closed Nayuta Yanagisawa (Inactive)
          9.
          		 Spider: remove #ifdef HASH_UPDATE_WITH_HASH_VALUE Technical task Closed Nayuta Yanagisawa (Inactive)
          10.
          		 Spider: remove #ifdef SPIDER_HAS_GROUP_BY_HANDLER Technical task Closed Yuchen Pei
          11.
          		 Spider: remove #ifdef HA_HAS_CHECKSUM_EXTENDED Technical task Closed Nayuta Yanagisawa (Inactive)
          12.
          		 Spider: remove #ifdef MARIADB_BASE_VERSION Technical task Closed Nayuta Yanagisawa (Inactive)
          13.
          		 Spider: remove #ifdef SPIDER_HAS_DISCOVER_TABLE_STRUCTURE Technical task Closed Nayuta Yanagisawa (Inactive)
          14.
          		 Spider: remove #ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS Technical task Closed Nayuta Yanagisawa (Inactive)
          15.
          		 Spider: remove #if defined(PARTITION_HAS_GET_CHILD_HANDLERS) Technical task Closed Nayuta Yanagisawa (Inactive)
          16.
          		 Spider: remove #ifdef HANDLER_HAS_DIRECT_UPDATE_ROWS_WITH_HS Technical task Closed Nayuta Yanagisawa (Inactive)
          17.
          		 Spider: remove #ifdef SPIDER_HANDLER_START_BULK_INSERT_HAS_FLAGS Technical task Closed Nayuta Yanagisawa (Inactive)
          18.
          		 Spider: remove #ifdef SPIDER_SUPPORT_CREATE_OR_REPLACE_TABLE Technical task Closed Nayuta Yanagisawa (Inactive)
          19.
          		 Spider: remove #ifdef SPIDER_USE_CONST_ITEM_FOR_STRING_INT_REAL_DECIMAL_DATE_ITEM Technical task Closed Nayuta Yanagisawa (Inactive)
          20.
          		 Spider: remove #ifdef SPIDER_SQL_CACHE_IS_IN_LEX Technical task Closed Nayuta Yanagisawa (Inactive)
          21.
          		 Spider: remove #ifdef SPIDER_LIKE_FUNC_HAS_GET_NEGATED Technical task Closed Nayuta Yanagisawa (Inactive)
          22.
          		 Spider: remove #ifdef SPIDER_I_S_USE_SHOW_FOR_COLUMN Technical task Closed Nayuta Yanagisawa (Inactive)
          23.
          		 Spider: remove #ifdef SPIDER_USE_CONST_ITEM_FOR_STRING_INT_REAL_DECIMAL_DATE_ITEM Technical task Closed Nayuta Yanagisawa (Inactive)
          24.
          		 Spider: remove #ifdef SPIDER_MDEV_16246 Technical task Closed Nayuta Yanagisawa (Inactive)
          25.
          		 Spider: remove #ifdef HANDLER_HAS_NEED_INFO_FOR_AUTO_INC Technical task Closed Nayuta Yanagisawa (Inactive)
          26.
          		 Spider: remove #ifdef SPIDER_HAS_MY_CHARLEN Technical task Closed Nayuta Yanagisawa (Inactive)
          27.
          		 Spider: remove #ifdef SPIDER_use_LEX_CSTRING_for_KEY_Field_name Technical task Closed Nayuta Yanagisawa (Inactive)
          28.
          		 Spider: remove #ifdef SPIDER_ITEM_STRING_WITHOUT_SET_STR_WITH_COPY_AND_THDPTR Technical task Closed Nayuta Yanagisawa (Inactive)
          29.
          		 Spider: remove #ifdef SPIDER_ITEM_STRING_WITHOUT_SET_STR_WITH_COPY Technical task Closed Nayuta Yanagisawa (Inactive)
          30.
          		 Spider: remove #ifdef SPIDER_use_LEX_CSTRING_for_Field_blob_constructor Technical task Closed Yuchen Pei
          31.
          		 Spider: remove #ifdef SPIDER_HAS_EXPR_CACHE_ITEM Technical task Closed Nayuta Yanagisawa (Inactive)
          32.
          		 Spider: remove #ifdef SPIDER_ITEM_HAS_CMP_TYPE Technical task Closed Nayuta Yanagisawa (Inactive)
          33.
          		 Spider: remove #ifdef ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC Technical task Closed Yuchen Pei
          34.
          		 Spider: remove #ifdef SPIDER_XID_USES_xid_cache_iterate Technical task Closed Nayuta Yanagisawa (Inactive)
          35.
          		 Spider: remove #ifdef SPIDER_FIELD_FIELDPTR_REQUIRES_THDPTR Technical task Closed Yuchen Pei
          36.
          		 Spider: remove #ifdef SPIDER_Item_args_arg_count_IS_PROTECTED Technical task Closed Yuchen Pei
          37.
          		 Spider: remove #ifdef SPIDER_NET_HAS_THD Technical task Closed Yuchen Pei
          38.
          		 Spider: remove #ifdef HA_EXTRA_HAS_STARTING_ORDERED_INDEX_SCAN Technical task Closed Yuchen Pei
          39.
          		 Spider: remove #ifdef HANDLER_HAS_CAN_USE_FOR_AUTO_INC_INIT Technical task Closed Yuchen Pei
          40.
          		 Spider: remove #ifdef SPIDER_UPDATE_ROW_HAS_CONST_NEW_DATA Technical task Closed Yuchen Pei
          41.
          		 Spider: remove #ifdef ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC Technical task Closed Yuchen Pei

          Activity

            Transition Time In Source Status Execution Times
            Nayuta Yanagisawa (Inactive) made transition -
            Open In Progress
            		192d 18h 40m 1
            Nayuta Yanagisawa (Inactive) made transition -
            In Progress In Review
            		14s 1
            Nayuta Yanagisawa (Inactive) made transition -
            Stalled In Progress
            		91d 22h 33m 1
            Yuchen Pei made transition -
            In Progress Stalled
            		507d 20h 27m 1
            Yuchen Pei made transition -
            Stalled In Review
            		260d 12h 3m 1
            Alexey Botchkov made transition -
            In Review Stalled
            		17d 5h 27m 2
            Yuchen Pei made transition -
            Stalled In Testing
            		1d 5h 38m 1
            Roel Van de Paar made transition -
            In Testing Stalled
            		74d 2h 39m 1
            Yuchen Pei made transition -
            Stalled Closed
            		30d 19h 3m 1

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.