[MDEV-26178] Spider: remove unnecessary #ifdef and dead code in #ifdef Created: 2021-07-19  Updated: 2023-10-02

Status: Stalled
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: 11.1

Type: Task Priority: Minor
Reporter: Nayuta Yanagisawa (Inactive) Assignee: Yuchen Pei
Resolution: Unresolved Votes: 0
Labels: beginner-friendly

Issue Links:
Relates
relates to MDEV-26858 Spider: Remove dead code related to H... Closed
relates to MDEV-26912 Spider: Remove dead code related to O... Closed
relates to MDEV-27474 Spider: remove #WITH_PARTITION_STORAG... Closed
Sub-Tasks:
Key
 Summary
 Type
 Status
 Assignee
MDEV-27637 Spider: remove #if defined(MARIADB_B... Technical task Closed Nayuta Yanagisawa  
MDEV-27641 Spider: remove #if MYSQL_VERSION_ID <... Technical task Closed Nayuta Yanagisawa  
MDEV-27642 Spider: remove #ifdef WITHOUT_SPIDER_... Technical task Closed Nayuta Yanagisawa  
MDEV-27643 Spider: remove #ifdef HA_CAN_BULK_ACCESS Technical task Closed Nayuta Yanagisawa  
MDEV-27644 Spider: remove #ifdef HANDLER_HAS_DIR... Technical task Closed Nayuta Yanagisawa  
MDEV-27645 Spider: remove #ifdef HA_MRR_USE_DEF... Technical task Closed Nayuta Yanagisawa  
MDEV-27646 Spider: remove #ifdef SPIDER_HAS_HASH... Technical task Closed Nayuta Yanagisawa  
MDEV-27647 Spider: remove #ifdef HANDLER_HAS_DI... Technical task Closed Nayuta Yanagisawa  
MDEV-27648 Spider: remove #ifdef HASH_UPDATE_WIT... Technical task Closed Nayuta Yanagisawa  
MDEV-27650 Spider: remove #ifdef SPIDER_HAS_GROU... Technical task Closed Nayuta Yanagisawa  
MDEV-27652 Spider: remove #ifdef HA_HAS_CHECKSUM... Technical task Closed Nayuta Yanagisawa  
MDEV-27655 Spider: remove #ifdef MARIADB_BASE_VE... Technical task Closed Nayuta Yanagisawa  
MDEV-27656 Spider: remove #ifdef SPIDER_HAS_DISC... Technical task Closed Nayuta Yanagisawa  
MDEV-27657 Spider: remove #ifdef SPIDER_HANDLER_... Technical task Closed Nayuta Yanagisawa  
MDEV-27658 Spider: remove #if defined(PARTITION_... Technical task Closed Nayuta Yanagisawa  
MDEV-27659 Spider: remove #ifdef HANDLER_HAS_DIR... Technical task Closed Nayuta Yanagisawa  
MDEV-27660 Spider: remove #ifdef SPIDER_HANDLER_... Technical task Closed Nayuta Yanagisawa  
MDEV-27662 Spider: remove #ifdef SPIDER_SUPPORT_... Technical task Closed Nayuta Yanagisawa  
MDEV-27663 Spider: remove #ifdef SPIDER_USE_CONS... Technical task Closed Nayuta Yanagisawa  
MDEV-27664 Spider: remove #ifdef SPIDER_SQL_CACH... Technical task Closed Nayuta Yanagisawa  
MDEV-27808 Spider: remove #ifdef SPIDER_LIKE_FUN... Technical task Closed Nayuta Yanagisawa  
MDEV-27809 Spider: remove #ifdef SPIDER_I_S_USE_... Technical task Closed Nayuta Yanagisawa  
MDEV-27810 Spider: remove #ifdef SPIDER_USE_CONS... Technical task Closed Nayuta Yanagisawa  
MDEV-27811 Spider: remove #ifdef SPIDER_MDEV_16246 Technical task Closed Nayuta Yanagisawa  
MDEV-28226 Spider: remove #ifdef HANDLER_HAS_NEE... Technical task Closed Nayuta Yanagisawa  
MDEV-28359 Spider: remove #ifdef SPIDER_HAS_MY_C... Technical task Closed Nayuta Yanagisawa  
MDEV-28360 Spider: remove #ifdef SPIDER_use_LEX_... Technical task Closed Nayuta Yanagisawa  
MDEV-28361 Spider: remove #ifdef SPIDER_ITEM_STR... Technical task Closed Nayuta Yanagisawa  
MDEV-28362 Spider: remove #ifdef SPIDER_ITEM_STR... Technical task Closed Nayuta Yanagisawa  
MDEV-28363 Spider: remove #ifdef SPIDER_use_LEX_... Technical task Closed Yuchen Pei  
MDEV-28364 Spider: remove #ifdef SPIDER_HAS_EXPR... Technical task Closed Nayuta Yanagisawa  
MDEV-28365 Spider: remove #ifdef SPIDER_ITEM_HAS... Technical task Closed Nayuta Yanagisawa  
MDEV-28873 Spider: remove #ifdef ITEM_FUNC_CASE_... Technical task Open Yuchen Pei  
MDEV-28890 Spider: remove #ifdef SPIDER_XID_USES... Technical task Closed Nayuta Yanagisawa  
MDEV-28891 Spider: remove #ifdef SPIDER_FIELD_FI... Technical task Closed Yuchen Pei  
MDEV-28892 Spider: remove #ifdef SPIDER_Item_arg... Technical task Open Yuchen Pei  
MDEV-28893 Spider: remove #ifdef SPIDER_NET_HAS_THD Technical task Open Yuchen Pei  
MDEV-28894 Spider: remove #ifdef HA_EXTRA_HAS_ST... Technical task Open Yuchen Pei  
MDEV-28895 Spider: remove #ifdef HANDLER_HAS_CAN... Technical task Open Yuchen Pei  
MDEV-28896 Spider: remove #ifdef SPIDER_UPDATE_R... Technical task Open Yuchen Pei  
MDEV-29269 Spider: remove #ifdef ITEM_FUNC_TIMES... Technical task Closed Yuchen Pei  
Epic Link: Spider Refactoring

 Description   

Remove unnecessary #ifdefs and dead code, in Spider, which is protected by #ifdef.

Some time ago, the Spider was a separate project, and Kentoku tried to make it compile on many MySQL and MariaDB versions without changes. So, there are many #ifdef macro in the Spider codebase, which were to adjust Spider for changes in API over different server versions. For example, see ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC. Now, the Spider is part of the source tree, and thus we can remove dead code in #ifdef.

Use unifdef as far as possible.

 Comments   
Comment by Nayuta Yanagisawa (Inactive) [ 2022-01-27 ]

https://buildbot.mariadb.org/#/builders/234

Comment by Nayuta Yanagisawa (Inactive) [ 2022-01-28 ]

https://github.com/MariaDB/server/tree/bb-10.9-MDEV-26178

Generated at Thu Feb 08 09:43:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.