Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26178

Spider: remove unnecessary #ifdef and dead code in #ifdef

    XMLWordPrintable

Details

    Description

      Remove unnecessary #ifdefs and dead code, in Spider, which is protected by #ifdef.

      Some time ago, the Spider was a separate project, and Kentoku tried to make it compile on many MySQL and MariaDB versions without changes. So, there are many #ifdef macro in the Spider codebase, which were to adjust Spider for changes in API over different server versions. For example, see ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC. Now, the Spider is part of the source tree, and thus we can remove dead code in #ifdef.

      Use unifdef as far as possible.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-26858 Spider: Remove dead code related to HandlerSocket

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-26912 Spider: Remove dead code related to Oracle OCI

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-27474 Spider: remove #WITH_PARTITION_STORAGE_ENGINE

          • Major - Major loss of function.
          • Closed

          Activity

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.