Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26178

Spider: remove unnecessary #ifdef and dead code in #ifdef

Details

    Description

      Remove unnecessary #ifdefs and dead code, in Spider, which is protected by #ifdef.

      Some time ago, the Spider was a separate project, and Kentoku tried to make it compile on many MySQL and MariaDB versions without changes. So, there are many #ifdef macro in the Spider codebase, which were to adjust Spider for changes in API over different server versions. For example, see ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC. Now, the Spider is part of the source tree, and thus we can remove dead code in #ifdef.

      Use unifdef as far as possible.

      Attachments

        Issue Links

          There are no Sub-Tasks for this issue.

          Activity

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            holyfoot thanks for the review.

            Roel I've included which commits to test in my latest comment in MDEV-31788[1]. The 10.5 branch based on a two week old 10.5 - is that new enough for the purpose of testing?

            [1] https://jira.mariadb.org/browse/MDEV-31788?focusedCommentId=287314&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-287314

            ycp Yuchen Pei added a comment - holyfoot thanks for the review. Roel I've included which commits to test in my latest comment in MDEV-31788 [1] . The 10.5 branch based on a two week old 10.5 - is that new enough for the purpose of testing? [1] https://jira.mariadb.org/browse/MDEV-31788?focusedCommentId=287314&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-287314

            Branches are fine. Testing as part of MDEV-31788.

            Roel Roel Van de Paar added a comment - Branches are fine. Testing as part of MDEV-31788 .

            OK to push

            Roel Roel Van de Paar added a comment - OK to push
            ycp Yuchen Pei added a comment - - edited

            All subtasks done. fixversions vary, may backport some subtasks when needed.

            ycp Yuchen Pei added a comment - - edited All subtasks done. fixversions vary, may backport some subtasks when needed.

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.