Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26178 Spider: remove unnecessary #ifdef and dead code in #ifdef
  3. MDEV-27641

Spider: remove #if MYSQL_VERSION_ID < ${VERSION}

Details

    Attachments

      Issue Links

        relates to

        Task - A task that needs to be done. MDEV-33728 remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider

        • Critical - Crashes, loss of data, severe memory leak.
        • Closed

        Activity

          Ascending order - Click to sort in descending order
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited

          I did this by my hand. I left the indentation as is to reduce the possibility of error. https://github.com/MariaDB/server/commit/e3537be73d5eb20d5d029b622142c3afe01e7ab3

          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited I did this by my hand. I left the indentation as is to reduce the possibility of error. https://github.com/MariaDB/server/commit/e3537be73d5eb20d5d029b622142c3afe01e7ab3
          holyfoot Alexey Botchkov added a comment -

          ok to push.

          holyfoot Alexey Botchkov added a comment - ok to push.

          People

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.