Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33728

remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider

Details

    Description

      They are from an age when spider was not in the mariadb source tree, and clutters the code.

      The changes can be generated by

      unifdef -DMYSQL_VERSION_ID=100400 -DMARIADB_BASE_VERSION -m storage/spider/spd_* storage/spider/ha_spider.* storage/spider/hs_client/*

      Attachments

        Issue Links

          relates to

          Technical task - A technical task. MDEV-27637 Spider: remove #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= ${VERSION}

          • Major - Major loss of function.
          • Closed

          Technical task - A technical task. MDEV-27641 Spider: remove #if MYSQL_VERSION_ID < ${VERSION}

          • Major - Major loss of function.
          • Closed

          Technical task - A technical task. MDEV-27655 Spider: remove #ifdef MARIADB_BASE_VERSION

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment - - edited

            Hi holyfoot, ptal thanks (in branch bb-10.4-mdev-33728)

            upstream/bb-10.4-mdev-33728 3ad0c5555991291927daeffdbe3872c5cf5ce014
            		 
            MDEV-33728 spider: remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION
            		 
             
            		 
            change created by:
            		 
             
            		 
            unifdef -DMYSQL_VERSION_ID=100400 -DMARIADB_BASE_VERSION -m storage/spider/spd_* storage/spider/ha_spider.* storage/spider/hs_client/*
            		 
             
            		 
            basically MDEV-27637, MDEV-27641, MDEV-27655

            ycp Yuchen Pei added a comment - - edited Hi holyfoot , ptal thanks (in branch bb-10.4-mdev-33728) upstream/bb-10.4-mdev-33728 3ad0c5555991291927daeffdbe3872c5cf5ce014 MDEV-33728 spider: remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION   change created by:   unifdef -DMYSQL_VERSION_ID=100400 -DMARIADB_BASE_VERSION -m storage/spider/spd_* storage/spider/ha_spider.* storage/spider/hs_client/*   basically MDEV-27637, MDEV-27641, MDEV-27655
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            thanks for the review, pushed 9c93d41ad7b6efcbad38fe19a994a76c1c4b5c32 to 10.4

            ycp Yuchen Pei added a comment - thanks for the review, pushed 9c93d41ad7b6efcbad38fe19a994a76c1c4b5c32 to 10.4

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.