[MDEV-33728] remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider - Jira

XML

Word

Printable

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 10.4.34, 10.5.25, 10.6.18, 10.11.8, 11.0.6, 11.1.5, 11.2.4, 11.4.2
Component/s: Storage Engine - Spider
Labels:
None

Description

They are from an age when spider was not in the mariadb source tree, and clutters the code.

The changes can be generated by

unifdef -DMYSQL_VERSION_ID=100400 -DMARIADB_BASE_VERSION -m storage/spider/spd_* storage/spider/ha_spider.* storage/spider/hs_client/*

Attachments

Issue Links

relates to

MDEV-27637 Spider: remove #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= ${VERSION}

Closed

MDEV-27641 Spider: remove #if MYSQL_VERSION_ID < ${VERSION}

Closed

MDEV-27655 Spider: remove #ifdef MARIADB_BASE_VERSION

Closed

Activity

People

Assignee:: Yuchen Pei

Reporter:: Yuchen Pei

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2024-03-20 03:03

Updated:: 2024-04-11 00:09

Resolved:: 2024-04-08 06:12

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.