Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26178 Spider: remove unnecessary #ifdef and dead code in #ifdef
  3. MDEV-27637

Spider: remove #if defined(MARIADB_BASE_VERSION) && MYSQL_VERSION_ID >= ${VERSION}

Details

    Attachments

      Issue Links

        Activity

          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited I did this by my hand https://github.com/MariaDB/server/commit/3decd8251927d1e53d20bc3281a06c07c646dcfe

          I see one MARIADB_BASE_VERSION survived in the spd_db_oracle.cc.
          Was it intentional?
          Otherwise ok to push.

          holyfoot Alexey Botchkov added a comment - I see one MARIADB_BASE_VERSION survived in the spd_db_oracle.cc. Was it intentional? Otherwise ok to push.

          Thank you for your review. This is intentional. spd_db_oralce.* will also be removed by another issue.

          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - Thank you for your review. This is intentional. spd_db_oralce.* will also be removed by another issue.

          People

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.