Type:
Priority:
Resolution:
Fixed
Remove unnecessary #ifdefs and dead code, in Spider, which is protected by #ifdef.
Some time ago, the Spider was a separate project, and Kentoku tried to make it compile on many MySQL and MariaDB versions without changes. So, there are many #ifdef macro in the Spider codebase, which were to adjust Spider for changes in API over different server versions. For example, see ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC . Now, the Spider is part of the source tree, and thus we can remove dead code in #ifdef.
Use unifdef as far as possible.
{"report":{"fcp":1264.1000001430511,"ttfb":484,"pageVisibility":"visible","entityId":101344,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"e7b7a8da-8fb4-478f-8e29-02e323332354","navigationType":0,"readyForUser":1410.5,"redirectCount":0,"resourceLoadedEnd":1391.2000000476837,"resourceLoadedStart":490.5,"resourceTiming":[{"duration":174.29999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":490.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":490.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":664.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":174.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":490.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":490.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":665.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":209.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":491,"connectEnd":491,"connectStart":491,"domainLookupEnd":491,"domainLookupStart":491,"fetchStart":491,"redirectEnd":0,"redirectStart":0,"requestStart":491,"responseEnd":700.5,"responseStart":700.5,"secureConnectionStart":491},{"duration":279.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":491.2999999523163,"connectEnd":491.2999999523163,"connectStart":491.2999999523163,"domainLookupEnd":491.2999999523163,"domainLookupStart":491.2999999523163,"fetchStart":491.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":491.2999999523163,"responseEnd":771.1000001430511,"responseStart":771.1000001430511,"secureConnectionStart":491.2999999523163},{"duration":283.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":491.5,"connectEnd":491.5,"connectStart":491.5,"domainLookupEnd":491.5,"domainLookupStart":491.5,"fetchStart":491.5,"redirectEnd":0,"redirectStart":0,"requestStart":491.5,"responseEnd":775.2999999523163,"responseStart":775.2999999523163,"secureConnectionStart":491.5},{"duration":284.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":491.7000000476837,"connectEnd":491.7000000476837,"connectStart":491.7000000476837,"domainLookupEnd":491.7000000476837,"domainLookupStart":491.7000000476837,"fetchStart":491.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":491.7000000476837,"responseEnd":775.7999999523163,"responseStart":775.7999999523163,"secureConnectionStart":491.7000000476837},{"duration":284.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":491.7999999523163,"connectEnd":491.7999999523163,"connectStart":491.7999999523163,"domainLookupEnd":491.7999999523163,"domainLookupStart":491.7999999523163,"fetchStart":491.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":491.7999999523163,"responseEnd":776.5,"responseStart":776.5,"secureConnectionStart":491.7999999523163},{"duration":359.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":492.10000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":492.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":285.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":492.2000000476837,"connectEnd":492.2000000476837,"connectStart":492.2000000476837,"domainLookupEnd":492.2000000476837,"domainLookupStart":492.2000000476837,"fetchStart":492.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":492.2000000476837,"responseEnd":777.4000000953674,"responseStart":777.4000000953674,"secureConnectionStart":492.2000000476837},{"duration":359.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":492.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":492.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":285.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":492.60000014305115,"connectEnd":492.60000014305115,"connectStart":492.60000014305115,"domainLookupEnd":492.60000014305115,"domainLookupStart":492.60000014305115,"fetchStart":492.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":492.60000014305115,"responseEnd":778.2999999523163,"responseStart":778.2999999523163,"secureConnectionStart":492.60000014305115},{"duration":510.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":500,"connectEnd":500,"connectStart":500,"domainLookupEnd":500,"domainLookupStart":500,"fetchStart":500,"redirectEnd":0,"redirectStart":0,"requestStart":500,"responseEnd":1010.6000001430511,"responseStart":1010.6000001430511,"secureConnectionStart":500},{"duration":809.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":500,"connectEnd":500,"connectStart":500,"domainLookupEnd":500,"domainLookupStart":500,"fetchStart":500,"redirectEnd":0,"redirectStart":0,"requestStart":500,"responseEnd":1309.7000000476837,"responseStart":1309.7000000476837,"secureConnectionStart":500},{"duration":146.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":864.7999999523163,"connectEnd":864.7999999523163,"connectStart":864.7999999523163,"domainLookupEnd":864.7999999523163,"domainLookupStart":864.7999999523163,"fetchStart":864.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":864.7999999523163,"responseEnd":1011.2999999523163,"responseStart":1011.2999999523163,"secureConnectionStart":864.7999999523163},{"duration":210.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1153.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1153.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1364.1000001430511,"responseStart":0,"secureConnectionStart":0},{"duration":209.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1154.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1154.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1364.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":211.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1155.7000000476837,"connectEnd":1155.7000000476837,"connectStart":1155.7000000476837,"domainLookupEnd":1155.7000000476837,"domainLookupStart":1155.7000000476837,"fetchStart":1155.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1155.7000000476837,"responseEnd":1367.2000000476837,"responseStart":1367.2000000476837,"secureConnectionStart":1155.7000000476837},{"duration":233.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1156.2000000476837,"connectEnd":1156.2000000476837,"connectStart":1156.2000000476837,"domainLookupEnd":1156.2000000476837,"domainLookupStart":1156.2000000476837,"fetchStart":1156.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1156.2000000476837,"responseEnd":1389.7000000476837,"responseStart":1389.7000000476837,"secureConnectionStart":1156.2000000476837},{"duration":234.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/e0bf5781d46ea69fb123572974cf39de-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1156.5,"connectEnd":1156.5,"connectStart":1156.5,"domainLookupEnd":1156.5,"domainLookupStart":1156.5,"fetchStart":1156.5,"redirectEnd":0,"redirectStart":0,"requestStart":1156.5,"responseEnd":1391.2000000476837,"responseStart":1391.2000000476837,"secureConnectionStart":1156.5},{"duration":373.09999990463257,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1232.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1232.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1605.2999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":243,"responseStart":484,"responseEnd":489,"domLoading":487,"domInteractive":1529,"domContentLoadedEventStart":1529,"domContentLoadedEventEnd":1591,"domComplete":2018,"loadEventStart":2018,"loadEventEnd":2019,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1492.1000001430511},{"name":"bigPipe.sidebar-id.end","time":1493.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1493.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1495.1000001430511},{"name":"activityTabFullyLoaded","time":1620.1000001430511}],"measures":[],"correlationId":"bb340d9ab44cd6","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":137,"dbReadsTimeInMs":18,"dbConnsTimeInMs":28,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Task
Minor
ok to push.