Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18347

mariabackup doesn't read all server option groups from configuration files

Details

    Description

      mariabackup doesn't currently seem to read all server option groups.

      I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

      static const char *xb_server_default_groups[]=
      	{ "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };
      

      https://github.com/MariaDB/server/blob/9dc81d2a7a6467cea2dc456d75e22d93ad192e1e/extra/mariabackup/xtrabackup.cc#L1581

      And comparing that to the array in include/mysqld_default_groups.h:

      const char *load_default_groups[]= {
      "mysqld", "server", MYSQL_BASE_VERSION,
      "mariadb", MARIADB_BASE_VERSION,
      "client-server",
      #ifdef WITH_WSREP
      "galera",
      #endif
      0, 0};
      

      https://github.com/MariaDB/server/blob/5abc79dd7ab2fccb4b05ca38a512ec816d2f8e52/include/mysqld_default_groups.h

      Attachments

        Issue Links

          Activity

            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            GeoffMontee Geoff Montee (Inactive) made changes -
            Summary mariabackup doesn't understand all server option groups mariabackup doesn't read all server option groups
            GeoffMontee Geoff Montee (Inactive) made changes -
            Description mariabackup doesn't currently seem to understand all server option groups.

            I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

            {noformat}
            static const char *xb_server_default_groups[]=
            { "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };
            {noformat}

            And comparing that to the array in include/mysqld_default_groups.h:

            {noformat}
            const char *load_default_groups[]= {
            "mysqld", "server", MYSQL_BASE_VERSION,
            "mariadb", MARIADB_BASE_VERSION,
            "client-server",
            #ifdef WITH_WSREP
            "galera",
            #endif
            0, 0};
            {noformat}
            mariabackup doesn't currently seem to read all server option groups.

            I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

            {noformat}
            static const char *xb_server_default_groups[]=
            { "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };
            {noformat}

            And comparing that to the array in include/mysqld_default_groups.h:

            {noformat}
            const char *load_default_groups[]= {
            "mysqld", "server", MYSQL_BASE_VERSION,
            "mariadb", MARIADB_BASE_VERSION,
            "client-server",
            #ifdef WITH_WSREP
            "galera",
            #endif
            0, 0};
            {noformat}
            GeoffMontee Geoff Montee (Inactive) made changes -
            Description mariabackup doesn't currently seem to read all server option groups.

            I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

            {noformat}
            static const char *xb_server_default_groups[]=
            { "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };
            {noformat}

            And comparing that to the array in include/mysqld_default_groups.h:

            {noformat}
            const char *load_default_groups[]= {
            "mysqld", "server", MYSQL_BASE_VERSION,
            "mariadb", MARIADB_BASE_VERSION,
            "client-server",
            #ifdef WITH_WSREP
            "galera",
            #endif
            0, 0};
            {noformat}
            mariabackup doesn't currently seem to read all server option groups.

            I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

            {noformat}
            static const char *xb_server_default_groups[]=
            { "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };
            {noformat}

            https://github.com/MariaDB/server/blob/9dc81d2a7a6467cea2dc456d75e22d93ad192e1e/extra/mariabackup/xtrabackup.cc#L1581

            And comparing that to the array in include/mysqld_default_groups.h:

            {noformat}
            const char *load_default_groups[]= {
            "mysqld", "server", MYSQL_BASE_VERSION,
            "mariadb", MARIADB_BASE_VERSION,
            "client-server",
            #ifdef WITH_WSREP
            "galera",
            #endif
            0, 0};
            {noformat}

            https://github.com/MariaDB/server/blob/5abc79dd7ab2fccb4b05ca38a512ec816d2f8e52/include/mysqld_default_groups.h
            GeoffMontee Geoff Montee (Inactive) made changes -
            Summary mariabackup doesn't read all server option groups mariabackup doesn't read all server option groups from configuration files
            wlad Vladislav Vaintroub made changes -
            issue.field.resolutiondate 2019-01-24 11:46:00.0 2019-01-24 11:46:00.938
            wlad Vladislav Vaintroub made changes -
            Fix Version/s 10.1.38 [ 23209 ]
            Fix Version/s 10.3.13 [ 23215 ]
            Fix Version/s 10.2.22 [ 23250 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 91998 ] MariaDB v4 [ 133828 ]
            GeoffMontee Geoff Montee (Inactive) made changes -

            People

              wlad Vladislav Vaintroub
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.