Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18347

mariabackup doesn't read all server option groups from configuration files

Details

    Description

      mariabackup doesn't currently seem to read all server option groups.

      I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

      static const char *xb_server_default_groups[]=
      		 
      	{ "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };

      https://github.com/MariaDB/server/blob/9dc81d2a7a6467cea2dc456d75e22d93ad192e1e/extra/mariabackup/xtrabackup.cc#L1581

      And comparing that to the array in include/mysqld_default_groups.h:

      const char *load_default_groups[]= {
      		 
      "mysqld", "server", MYSQL_BASE_VERSION,
      		 
      "mariadb", MARIADB_BASE_VERSION,
      		 
      "client-server",
      		 
      #ifdef WITH_WSREP
      		 
      "galera",
      		 
      #endif
      		 
      0, 0};

      https://github.com/MariaDB/server/blob/5abc79dd7ab2fccb4b05ca38a512ec816d2f8e52/include/mysqld_default_groups.h

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariadb_backup_*

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19246 Change database and table used for Mariabackup's history

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-20552 Remove innobackupex mode from Mariabackup

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21298 mariabackup doesn't read from the [mariadbd] and [mariadbd-X.Y] server option groups from configuration files

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21301 mariabackup doesn't read [mariadb-backup] option group in configuration file

          • Major - Major loss of function.
          • Closed

          Activity

            GeoffMontee Geoff Montee (Inactive) added a comment - - edited

            wlad,

            I submitted a pull request that makes mariabackup read all of MariaDB's client and server option groups:

            https://github.com/MariaDB/server/pull/1126

            I built it and confirmed that it reads the groups:

            $ ./extra/mariabackup/mariabackup --help | grep "following groups are read"
            		 
            ./extra/mariabackup/mariabackup based on MariaDB server 10.1.38-MariaDB Linux (x86_64)
            		 
            The following groups are read: xtrabackup mariabackup mysqld server mysqld-10.1 mariadb mariadb-10.1 client-server galera

            GeoffMontee Geoff Montee (Inactive) added a comment - - edited wlad , I submitted a pull request that makes mariabackup read all of MariaDB's client and server option groups: https://github.com/MariaDB/server/pull/1126 I built it and confirmed that it reads the groups: $ ./extra/mariabackup/mariabackup --help | grep "following groups are read" ./extra/mariabackup/mariabackup based on MariaDB server 10.1.38-MariaDB Linux (x86_64) The following groups are read: xtrabackup mariabackup mysqld server mysqld-10.1 mariadb mariadb-10.1 client-server galera

            People

              wlad Vladislav Vaintroub
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.