[MDEV-18347] mariabackup doesn't read all server option groups from configuration files Created: 2019-01-23  Updated: 2022-03-24  Resolved: 2019-01-24

Status: Closed
Project: MariaDB Server
Component/s: Configuration, mariabackup
Fix Version/s: 10.1.38, 10.2.22, 10.3.13

Type: Task Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: configuration, mariabackup, my.cnf

Issue Links:
Relates
relates to MDEV-14746 mariabackup doesn't read [mariabackup... Closed
relates to MDEV-18405 Add Mariabackup option to set gtid_sl... Stalled
relates to MDEV-18917 Don't create xtrabackup_binlog_pos_in... Closed
relates to MDEV-18931 Rename Mariabackup's xtrabackup_* fil... Closed
relates to MDEV-18985 Remove support for XtraDB's changed p... Confirmed
relates to MDEV-19246 Change database and table used for Ma... Closed
relates to MDEV-19264 Better support MariaDB GTID for Maria... Closed
relates to MDEV-20552 Remove innobackupex mode from Mariaba... Stalled
relates to MDEV-20556 Remove references to "xtrabackup" and... Closed
relates to MDEV-21298 mariabackup doesn't read from the [ma... Closed
relates to MDEV-21301 mariabackup doesn't read [mariadb-bac... Closed

 Description   

mariabackup doesn't currently seem to read all server option groups.

I checked by looking at the following array in extra/mariabackup/xtrabackup.cc:

static const char *xb_server_default_groups[]=
 
	{ "xtrabackup", "mariabackup", "mysqld", 0, 0, 0 };

https://github.com/MariaDB/server/blob/9dc81d2a7a6467cea2dc456d75e22d93ad192e1e/extra/mariabackup/xtrabackup.cc#L1581

And comparing that to the array in include/mysqld_default_groups.h:

const char *load_default_groups[]= {
 
"mysqld", "server", MYSQL_BASE_VERSION,
 
"mariadb", MARIADB_BASE_VERSION,
 
"client-server",
 
#ifdef WITH_WSREP
 
"galera",
 
#endif
 
0, 0};

https://github.com/MariaDB/server/blob/5abc79dd7ab2fccb4b05ca38a512ec816d2f8e52/include/mysqld_default_groups.h

 Comments   
Comment by Geoff Montee (Inactive) [ 2019-01-24 ]

wlad,

I submitted a pull request that makes mariabackup read all of MariaDB's client and server option groups:

https://github.com/MariaDB/server/pull/1126

I built it and confirmed that it reads the groups:

$ ./extra/mariabackup/mariabackup --help | grep "following groups are read"
 
./extra/mariabackup/mariabackup based on MariaDB server 10.1.38-MariaDB Linux (x86_64)
 
The following groups are read: xtrabackup mariabackup mysqld server mysqld-10.1 mariadb mariadb-10.1 client-server galera

Generated at Thu Feb 08 08:43:25 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.