[MDEV-18931] Rename Mariabackup's xtrabackup_* files to mariadb_backup_* - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 11.1.0
Component/s: mariabackup
Labels:
- Preview_11.1
- mariabackup

Description

Mariabackup creates a few files of the form xtrabackup_*. e.g.:

$ ls -l backup/xtrabackup_*

-rw-r----- 1 root root  38 Mar 13 18:43 backup/xtrabackup_binlog_info

-rw-r--r-- 1 root root  25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb

-rw-r----- 1 root root  99 Mar 13 18:44 backup/xtrabackup_checkpoints

-rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info

Maybe we should rename these to mariabackup_*?

Attachments

Issue Links

causes

MDEV-34856 Galera Cluster upgrade from 11.0 to 11.1 fails, eventually leads to crash

Closed

MDEV-36259 MariaDB-Backup >=11.1 still writes xtrabackup_binlog_pos_innodb

Confirmed

is part of

MDEV-30201 Remove MySQL names

Open

relates to

MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

Closed

MDEV-18347 mariabackup doesn't read all server option groups from configuration files

Closed

MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

Stalled

MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

Closed

MDEV-19246 Change database and table used for Mariabackup's history

Closed

MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

Closed

MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

Closed

MDEV-20552 Remove innobackupex mode from Mariabackup

Stalled

MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

Closed

MDEV-30822 Adjust wsrep_sst_mariabackup.sh to understand both pre-MDEV-18931 and post-MDEV-18931 file naming

Closed

(8 relates to)

Activity

Ascending order - Click to sort in descending order

View 7 older comments

Alexander Barkov added a comment - 2023-03-07 08:24

Hi vlad.lesin,

Please review a new patch version:

https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee

Thanks.

Alexander Barkov added a comment - 2023-03-07 08:24 Hi vlad.lesin , Please review a new patch version: https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee Thanks.

Vladislav Lesin added a comment - 2023-03-07 13:05 - edited

bar, I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg, could you please suggest how to fix the script?

Vladislav Lesin added a comment - 2023-03-07 13:05 - edited bar , I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg , could you please suggest how to fix the script?

Vladislav Lesin added a comment - 2023-03-09 13:56

Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.

Vladislav Lesin added a comment - 2023-03-09 13:56 Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.

Michael Widenius added a comment - 2024-09-04 12:19

I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong.
It is better to revert to use the old names if the new name does not exist and old name exists.

Michael Widenius added a comment - 2024-09-04 12:19 I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong. It is better to revert to use the old names if the new name does not exist and old name exists.

Michael Widenius added a comment - 2024-09-04 12:23

As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

Michael Widenius added a comment - 2024-09-04 12:23 As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

People

Assignee:: Alexander Barkov

Reporter:: Geoff Montee (Inactive)

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 2019-03-14 21:55

Updated:: 2025-03-10 14:59

Resolved:: 2023-03-09 14:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server