any compatibility concerns?

serg We do not guaranty mariabackup compatibility among major versions. Besides, we already did more serious renames from compatibility perspective, like mysqld->mariadbd, mariabackup->mariadb-backup etc. But we used symlinks for that, what is reasonable and can be used for this issue too.

I don't understand. How do you suggest to use symlinks here?

We could create mariabackup_* files instead of xtrabackup_*, and create xtrabackup_* symlinks to mariabackup_* to let existing user scripts to use old names.

why should this be done at all?

As the canonical name is now "mariadb-backup", the files should probably be renamed to mariadb_backup_*.

serg, please review this patch:
https://github.com/MariaDB/server/commit/ba70039c89b91dc1017d1451864bcd3caa3cbda0

Thanks!

Hi vlad.lesin,

Please review a new patch version:

https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee

Thanks.

bar, I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg, could you please suggest how to fix the script?

Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.