Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5816

MySQL WL#4179 - Stored programs: validation of stored program statements

Details

    Description

      Test case for MySQL "WL#4179 - Stored programs: validation of stored program statements" fails in 10.0.

      Test diff attached. Please try to apply test case as is unless it is applicable.

      Changes introduced by the task MDEV-5816.
      ---------------------------------------------
      Main logic of SP instructions processing is modified to support handling of tables metadata change the Stored routine's instructions depends on.

      • On first execution of SP instruction the current version of metadata for tables used by SP statement is extracted from the data dictionary and remembered in SP instruction's context.
      • Next time the same SP instruction is run the current version of underlying tables metadata is checked against their version loaded from data dictionary. In case these versions are different the statement for this SP instruction is re-parsed and actual metadata of underlying tables is reloaded from the data dictionary.

      To invalidate current SP instruction on metadata change and force its re-parsing, the same approach that used for Prepared Statement is applied - an instance of the class Reprepare_observer installed before second and subsequent executions of SP instruction and in case underlying tables metadata be changed this fact will be notified to and SP instruction's statement be re-parsed.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-11225 SELECT from view, which was replaced in prepared statement inside cursor, gives wrong result

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-11652 SP with cursors does not work well in combination with ALTER TABLE

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-14557 Assertion `m_sp == __null' failed in Item_func_sp::init_result_field upon 2nd execution of SP

          • Critical - Crashes, loss of data, severe memory leak.
          • Stalled
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31799 Unexpected ER_TRG_NO_SUCH_ROW_IN_TRG and server crash after ALTER TABLE

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31867 Assertion `is_invalidated()' failed in Reprepare_observer::can_retry on 2nd execute of SP after recreation

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32694 ASAN errors in Binary_string::alloced_length / reset_stmt_params

          • Critical - Crashes, loss of data, severe memory leak.
          • Stalled
          includes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-595 LP:1006160 - View used via a trigger references old columns

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-774 LP:948583 - Stored procedure doesn't not take into account ALTER TABLE, causes wrong result or replication abort

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-6488 Autodiscover + CONNECT + OR REPLACE

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19637 Crash on an SP variable assignment to a wrong subselect

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19639 sql_mode=ORACLE: Wrong SHOW PROCEDURE output for sysvar:=expr

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19640 Wrong SHOW PROCEDURE output for SET GLOBAL sysvar1=expr, sysvar2=expr

          • Major - Major loss of function.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-4784 merge test cases from 5.6

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26048 Table 'test._test_new' doesn't exist when add trigger (use pt-osc)

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31081 Assertion `fixed()' failed in virtual double Item_func_hybrid_field_type::val_real()

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31123 Stored programs does not validate SQLs when using certain SQL modes

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31661 Assertion `thd->lex == sp_instr_lex' failed in LEX* sp_lex_instr::parse_expr(THD*, sp_head*, LEX*)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-7410 Temporary table name conflict between sessions

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12166 PROCEDURE using a SELECT from a temporary table does not work well

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33525 Recreate/reuse temporary table

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34438 The insert trigger does not work while performing pt-osc.

          • Major - Major loss of function.
          • Confirmed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36079 Stored routine with a cursor crashes on the second execution if a DDL statement happened

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36409 Server crashes when creating a table using function with a return type sys_refcursor

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36462 Crash on `DECLARE spvar1 ROW TYPE OF cursor1` after a table recreation

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 8 older comments
            shulga Dmitry Shulga added a comment - - edited

            Updated status of the task:

            • The new branch 10.11-MDEV-5816-1 contains current implementation of the task.
            • There are few failing tests: sys_vars.sysvars_star versioning.partition main.ps_ddl sysschema.pr_create_synonym_db innodb.autoinc_persist atomic.rename_trigger
            • There are several memory leaks on recompilation of statements for failing SP instructions that will be fixed on the next development cycle
            • There is the critical issue regarding recompilation of statements inside triggers.
              • Before the failed statement of trigger is re-parsed, all items storing in the intrusive list sp_lex_instr::free_list are deleted. For triggers such items include Item_trigger_field. On the other hand, pointers to deleted objects of the class Item_trigger_field are stored at objects of the class Trigger. After re-parsing of the current statement for the failed SP instruction, Trigger objects still points to objects just destroyed that results in crash.
            • First 8 test suites in the file sp_validation.test (borrowed from MySQL) passed ok. Total number of test suites is 11. First test that fails is regarding to running a stored routine that
              has an meta-data dependent expression inside IF instruction.
            shulga Dmitry Shulga added a comment - - edited Updated status of the task: The new branch 10.11- MDEV-5816 -1 contains current implementation of the task. There are few failing tests: sys_vars.sysvars_star versioning.partition main.ps_ddl sysschema.pr_create_synonym_db innodb.autoinc_persist atomic.rename_trigger There are several memory leaks on recompilation of statements for failing SP instructions that will be fixed on the next development cycle There is the critical issue regarding recompilation of statements inside triggers. Before the failed statement of trigger is re-parsed, all items storing in the intrusive list sp_lex_instr::free_list are deleted. For triggers such items include Item_trigger_field. On the other hand, pointers to deleted objects of the class Item_trigger_field are stored at objects of the class Trigger. After re-parsing of the current statement for the failed SP instruction, Trigger objects still points to objects just destroyed that results in crash. First 8 test suites in the file sp_validation.test (borrowed from MySQL) passed ok. Total number of test suites is 11. First test that fails is regarding to running a stored routine that has an meta-data dependent expression inside IF instruction.
            shulga Dmitry Shulga added a comment -

            Branch for review is bb-11.0-MDEV-5816

            shulga Dmitry Shulga added a comment - Branch for review is bb-11.0- MDEV-5816
            sanja Oleksandr Byelkin added a comment -

            see my e-main with only 2 issues

            sanja Oleksandr Byelkin added a comment - see my e-main with only 2 issues
            shulga Dmitry Shulga added a comment -

            The branch bb-11.2-MDEV-5816 is ready for review and QA.

            shulga Dmitry Shulga added a comment - The branch bb-11.2- MDEV-5816 is ready for review and QA.
            ramesh Ramesh Sivaraman added a comment -

            okay to push

            ramesh Ramesh Sivaraman added a comment - okay to push

            People

              shulga Dmitry Shulga
              svoj Sergey Vojtovich
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.