Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27666

User variable not parsed as geometry variable in geometry function

Details

    Description

      Repeatable with

      set @g=  point(1, 1); 
      select ST_AsWKT(GeometryCollection(Point(44, 6), @g));
       
      ERROR 1367 (22007) at line 1: Illegal non geometric '@`g`' value found during parsing
      

      The same bug exists in MySQL 8.0 with slightly different error message (note braces).

      ERROR 1367 (22007) at line 1: Illegal non geometric '(@`g`)' value found during parsing
      

      Attachments

        Issue Links

          Activity

            anel Anel Husakovic created issue -
            anel Anel Husakovic made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Priority Blocker [ 1 ] Major [ 3 ]
            holyfoot Alexey Botchkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            serg Sergei Golubchik made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            bar Alexander Barkov made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.2 [ 14601 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Blocker [ 1 ] Critical [ 2 ]
            holyfoot Alexey Botchkov made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            alice Alice Sherepa made changes -
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            alice Alice Sherepa made changes -
            Affects Version/s 10.7 [ 24805 ]
            Affects Version/s 10.8 [ 26121 ]
            Affects Version/s 10.9 [ 26905 ]
            Affects Version/s 10.10 [ 27530 ]
            Affects Version/s 10.11 [ 27614 ]
            alice Alice Sherepa made changes -
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.7 [ 24805 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.3 [ 22126 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.8 [ 26121 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.9 [ 26905 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.10 [ 27530 ]
            julien.fritsch Julien Fritsch made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            holyfoot Alexey Botchkov added a comment - https://github.com/MariaDB/server/commit/1b9561fde4436568e210f96837e8351227261af8
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Alexander Barkov [ bar ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            bar Alexander Barkov made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]

            Hello Alexey,

            I propose instead of adding a new enum for variable data type, implement this in a more generic way using Type_handler.

            Please review this version:
            https://github.com/MariaDB/server/commit/7d71e9901bf171fbac0f95e290b5612beedea90f

            bar Alexander Barkov added a comment - Hello Alexey, I propose instead of adding a new enum for variable data type, implement this in a more generic way using Type_handler. Please review this version: https://github.com/MariaDB/server/commit/7d71e9901bf171fbac0f95e290b5612beedea90f
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Alexey Botchkov [ holyfoot ]
            Status Stalled [ 10000 ] In Review [ 10002 ]

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2024-01-16 16:02:56.0 2024-01-16 16:02:55.599
            bar Alexander Barkov made changes -
            Fix Version/s 10.5.24 [ 29517 ]
            Fix Version/s 10.6.17 [ 29518 ]
            Fix Version/s 10.11.7 [ 29519 ]
            Fix Version/s 11.1.4 [ 29024 ]
            Fix Version/s 11.2.3 [ 29521 ]
            Fix Version/s 11.3.2 [ 29522 ]
            Fix Version/s 11.4.1 [ 29523 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.11 [ 27614 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 11.0.5 [ 29520 ]
            bnestere Brandon Nesterenko made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Attachment 10.4-test.diff [ 72831 ]

            Verified that 10.5->10.4 replication of user variables does not break.
            The 10.4 slave ignores the extra CHUNK_DATA_TYPE_NAME chunk in the User_var_log_event.

            bar Alexander Barkov added a comment - Verified that 10.5->10.4 replication of user variables does not break. The 10.4 slave ignores the extra CHUNK_DATA_TYPE_NAME chunk in the User_var_log_event.

            People

              bar Alexander Barkov
              anel Anel Husakovic
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.