Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18931

Rename Mariabackup's xtrabackup_* files to mariadb_backup_*

Details

    Description

      Mariabackup creates a few files of the form xtrabackup_*. e.g.:

      $ ls -l backup/xtrabackup_*
      		 
      -rw-r----- 1 root root  38 Mar 13 18:43 backup/xtrabackup_binlog_info
      		 
      -rw-r--r-- 1 root root  25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb
      		 
      -rw-r----- 1 root root  99 Mar 13 18:44 backup/xtrabackup_checkpoints
      		 
      -rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info

      Maybe we should rename these to mariabackup_*?

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34856 Galera Cluster upgrade from 11.0 to 11.1 fails, eventually leads to crash

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36259 MariaDB-Backup >=11.1 still writes xtrabackup_binlog_pos_innodb

          • Major - Major loss of function.
          • Confirmed
          is part of

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-30201 Remove MySQL names

          • Major - Major loss of function.
          • Open
          relates to

          Task - A task that needs to be done. MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18347 mariabackup doesn't read all server option groups from configuration files

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19246 Change database and table used for Mariabackup's history

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-20552 Remove innobackupex mode from Mariabackup

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-30822 Adjust wsrep_sst_mariabackup.sh to understand both pre-MDEV-18931 and post-MDEV-18931 file naming

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik added a comment -

            any compatibility concerns?

            serg Sergei Golubchik added a comment - any compatibility concerns?
            vlad.lesin Vladislav Lesin added a comment -

            serg We do not guaranty mariabackup compatibility among major versions. Besides, we already did more serious renames from compatibility perspective, like mysqld->mariadbd, mariabackup->mariadb-backup etc. But we used symlinks for that, what is reasonable and can be used for this issue too.

            vlad.lesin Vladislav Lesin added a comment - serg We do not guaranty mariabackup compatibility among major versions. Besides, we already did more serious renames from compatibility perspective, like mysqld->mariadbd, mariabackup->mariadb-backup etc. But we used symlinks for that, what is reasonable and can be used for this issue too.
            serg Sergei Golubchik added a comment -

            I don't understand. How do you suggest to use symlinks here?

            serg Sergei Golubchik added a comment - I don't understand. How do you suggest to use symlinks here?
            vlad.lesin Vladislav Lesin added a comment - - edited

            We could create mariabackup_* files instead of xtrabackup_*, and create xtrabackup_* symlinks to mariabackup_* to let existing user scripts to use old names.

            vlad.lesin Vladislav Lesin added a comment - - edited We could create mariabackup_* files instead of xtrabackup_*, and create xtrabackup_* symlinks to mariabackup_* to let existing user scripts to use old names.
            serg Sergei Golubchik added a comment -

            why should this be done at all?

            serg Sergei Golubchik added a comment - why should this be done at all?
            bar Alexander Barkov added a comment -

            As the canonical name is now "mariadb-backup", the files should probably be renamed to mariadb_backup_*.

            bar Alexander Barkov added a comment - As the canonical name is now "mariadb-backup", the files should probably be renamed to mariadb_backup_* .
            bar Alexander Barkov added a comment -

            serg, please review this patch:
            https://github.com/MariaDB/server/commit/ba70039c89b91dc1017d1451864bcd3caa3cbda0

            Thanks!

            bar Alexander Barkov added a comment - serg , please review this patch: https://github.com/MariaDB/server/commit/ba70039c89b91dc1017d1451864bcd3caa3cbda0 Thanks!
            bar Alexander Barkov added a comment -

            Hi vlad.lesin,

            Please review a new patch version:

            https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee

            Thanks.

            bar Alexander Barkov added a comment - Hi vlad.lesin , Please review a new patch version: https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee Thanks.
            vlad.lesin Vladislav Lesin added a comment - - edited

            bar, I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg, could you please suggest how to fix the script?

            vlad.lesin Vladislav Lesin added a comment - - edited bar , I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg , could you please suggest how to fix the script?
            vlad.lesin Vladislav Lesin added a comment -

            Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.

            vlad.lesin Vladislav Lesin added a comment - Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.
            monty Michael Widenius added a comment -

            I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong.
            It is better to revert to use the old names if the new name does not exist and old name exists.

            monty Michael Widenius added a comment - I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong. It is better to revert to use the old names if the new name does not exist and old name exists.
            monty Michael Widenius added a comment -

            As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

            monty Michael Widenius added a comment - As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

            People

              bar Alexander Barkov
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.