[MDEV-18931] Rename Mariabackup's xtrabackup_* files to mariadb_backup_* - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 11.1.0
Component/s: mariabackup
Labels:
- Preview_11.1
- mariabackup

Description

Mariabackup creates a few files of the form xtrabackup_*. e.g.:

$ ls -l backup/xtrabackup_*

-rw-r----- 1 root root  38 Mar 13 18:43 backup/xtrabackup_binlog_info

-rw-r--r-- 1 root root  25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb

-rw-r----- 1 root root  99 Mar 13 18:44 backup/xtrabackup_checkpoints

-rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info

Maybe we should rename these to mariabackup_*?

Attachments

Issue Links

causes

MDEV-34856 Galera Cluster upgrade from 11.0 to 11.1 fails, eventually leads to crash

Closed

MDEV-36259 MariaDB-Backup >=11.1 still writes xtrabackup_binlog_pos_innodb

Confirmed

is part of

MDEV-30201 Remove MySQL names

Open

relates to

MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

Closed

MDEV-18347 mariabackup doesn't read all server option groups from configuration files

Closed

MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

Stalled

MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

Closed

MDEV-19246 Change database and table used for Mariabackup's history

Closed

MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

Closed

MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

Closed

MDEV-20552 Remove innobackupex mode from Mariabackup

Stalled

MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

Closed

MDEV-30822 Adjust wsrep_sst_mariabackup.sh to understand both pre-MDEV-18931 and post-MDEV-18931 file naming

Closed

(8 relates to)

Activity

Ascending order - Click to sort in descending order

Geoff Montee (Inactive) created issue - 2019-03-14 21:55

Geoff Montee (Inactive) made changes - 2019-03-14 21:56

Field	Original Value	New Value
Labels		mariabackup

Geoff Montee (Inactive) made changes - 2019-03-14 21:57

Link

This issue relates to ~~MDEV-18917~~ [ ~~MDEV-18917~~ ]

Geoff Montee (Inactive) made changes - 2019-03-14 21:57

Description

Mariabackup creates a lot of files of the form xtrabackup_*. e.g.:

{noformat}
$ ls -l backup/xtrabackup_*
-rw-r----- 1 root root 38 Mar 13 18:43 backup/xtrabackup_binlog_info
-rw-r--r-- 1 root root 25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb
-rw-r----- 1 root root 99 Mar 13 18:44 backup/xtrabackup_checkpoints
-rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info
{noformat}

Maybe we should rename these to mariabackup_*?

Mariabackup creates a few files of the form xtrabackup_*. e.g.:

{noformat}
$ ls -l backup/xtrabackup_*
-rw-r----- 1 root root 38 Mar 13 18:43 backup/xtrabackup_binlog_info
-rw-r--r-- 1 root root 25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb
-rw-r----- 1 root root 99 Mar 13 18:44 backup/xtrabackup_checkpoints
-rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info
{noformat}

Maybe we should rename these to mariabackup_*?

Geoff Montee (Inactive) made changes - 2019-04-15 17:57

Assignee

Vladislav Vaintroub [ wlad ]

Vladislav Lesin [ vlad.lesin ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:38

Link

This issue relates to ~~MDEV-19264~~ [ ~~MDEV-19264~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:39

Link

This issue relates to ~~MDEV-19246~~ [ ~~MDEV-19246~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:41

Link

This issue relates to ~~MDEV-18985~~ [ ~~MDEV-18985~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to MDEV-18405 [ MDEV-18405 ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to ~~MDEV-18347~~ [ ~~MDEV-18347~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to ~~MDEV-14746~~ [ ~~MDEV-14746~~ ]

Geoff Montee (Inactive) made changes - 2019-06-13 23:41

Link

This issue relates to MDEV-19753 [ MDEV-19753 ]

Geoff Montee (Inactive) made changes - 2019-09-11 03:16

Link

This issue relates to ~~MDEV-20556~~ [ ~~MDEV-20556~~ ]

Geoff Montee (Inactive) made changes - 2019-09-11 03:17

Link

This issue relates to MDEV-20552 [ MDEV-20552 ]

Vladislav Lesin made changes - 2020-09-08 17:55

Fix Version/s

10.6 [ 24028 ]

Sergei Golubchik added a comment - 2020-09-10 08:09

any compatibility concerns?

Sergei Golubchik added a comment - 2020-09-10 08:09 any compatibility concerns?

Vladislav Lesin added a comment - 2020-09-21 10:50

serg We do not guaranty mariabackup compatibility among major versions. Besides, we already did more serious renames from compatibility perspective, like mysqld->mariadbd, mariabackup->mariadb-backup etc. But we used symlinks for that, what is reasonable and can be used for this issue too.

Vladislav Lesin added a comment - 2020-09-21 10:50 serg We do not guaranty mariabackup compatibility among major versions. Besides, we already did more serious renames from compatibility perspective, like mysqld->mariadbd, mariabackup->mariadb-backup etc. But we used symlinks for that, what is reasonable and can be used for this issue too.

Sergei Golubchik added a comment - 2020-09-21 17:05

I don't understand. How do you suggest to use symlinks here?

Sergei Golubchik added a comment - 2020-09-21 17:05 I don't understand. How do you suggest to use symlinks here?

Vladislav Lesin added a comment - 2020-09-22 13:20 - edited

We could create mariabackup_* files instead of xtrabackup_*, and create xtrabackup_* symlinks to mariabackup_* to let existing user scripts to use old names.

Vladislav Lesin added a comment - 2020-09-22 13:20 - edited We could create mariabackup_* files instead of xtrabackup_*, and create xtrabackup_* symlinks to mariabackup_* to let existing user scripts to use old names.

Julien Fritsch made changes - 2020-12-10 16:16

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Golubchik made changes - 2020-12-10 20:16

Priority

Critical [ 2 ]

Major [ 3 ]

Sergei Golubchik added a comment - 2020-12-10 20:16

why should this be done at all?

Sergei Golubchik added a comment - 2020-12-10 20:16 why should this be done at all?

Julien Fritsch made changes - 2020-12-11 06:54

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Golubchik made changes - 2020-12-11 09:41

Assignee

Vladislav Lesin [ vlad.lesin ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2020-12-11 09:42

Priority

Critical [ 2 ]

Major [ 3 ]

Ralf Gebhardt made changes - 2021-03-19 21:31

Epic/Theme

MariaDB_Branding

Julien Fritsch made changes - 2021-04-26 09:30

Assignee

Sergei Golubchik [ serg ]

Geoff Montee [ geoffmontee ]

Julien Fritsch made changes - 2021-04-26 09:30

Labels

mariabackup

mariabackup need_feedback

Ralf Gebhardt made changes - 2021-04-26 09:46

Fix Version/s

10.6 [ 24028 ]

Ralf Gebhardt made changes - 2021-04-26 09:46

Assignee

Geoff Montee [ geoffmontee ]

Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]

Ralf Gebhardt made changes - 2021-07-01 12:41

Fix Version/s		10.7 [ 24805 ]
Assignee	Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
Priority	Major [ 3 ]	Critical [ 2 ]

Ralf Gebhardt made changes - 2021-10-06 07:47

Fix Version/s		10.8 [ 26121 ]
Fix Version/s	10.7 [ 24805 ]

Ralf Gebhardt made changes - 2021-10-06 07:48

Labels

mariabackup need_feedback

mariabackup

Sergei Golubchik made changes - 2021-10-29 11:56

Priority

Critical [ 2 ]

Major [ 3 ]

Sergei Golubchik made changes - 2021-12-06 21:21

Workflow

MariaDB v3 [ 93284 ]

MariaDB v4 [ 131009 ]

Sergei Golubchik made changes - 2022-02-01 11:32

Fix Version/s		10.9 [ 26905 ]
Fix Version/s	10.8 [ 26121 ]

Ralf Gebhardt made changes - 2022-07-26 12:45

Fix Version/s		10.11 [ 27614 ]
Fix Version/s	10.9 [ 26905 ]

Sergei Golubchik made changes - 2022-08-02 19:57

Fix Version/s		10.12 [ 28320 ]
Fix Version/s	10.11 [ 27614 ]

AirFocus made changes - 2022-08-09 16:10

Description

Mariabackup creates a few files of the form xtrabackup\_\*. e.g.:

{noformat}
$ ls -l backup/xtrabackup_*
-rw-r----- 1 root root 38 Mar 13 18:43 backup/xtrabackup_binlog_info
-rw-r--r-- 1 root root 25 Mar 13 18:44 backup/xtrabackup_binlog_pos_innodb
-rw-r----- 1 root root 99 Mar 13 18:44 backup/xtrabackup_checkpoints
-rw-r----- 1 root root 572 Mar 13 18:43 backup/xtrabackup_info
{noformat}

Maybe we should rename these to mariabackup\_\*?

Ralf Gebhardt made changes - 2022-11-17 15:30

Assignee

Alexander Barkov [ bar ]

Ralf Gebhardt made changes - 2022-12-30 14:25

Fix Version/s		11.1 [ 28549 ]
Fix Version/s	11.0 [ 28320 ]

Ralf Gebhardt made changes - 2022-12-30 14:25

Priority

Major [ 3 ]

Critical [ 2 ]

Alexander Barkov added a comment - 2023-02-03 03:15

As the canonical name is now "mariadb-backup", the files should probably be renamed to mariadb_backup_*.

Alexander Barkov added a comment - 2023-02-03 03:15 As the canonical name is now "mariadb-backup", the files should probably be renamed to mariadb_backup_* .

Alexander Barkov made changes - 2023-02-03 03:43

Summary

Rename Mariabackup's xtrabackup_* files to mariabackup_*

Rename Mariabackup's xtrabackup_* files to mariadb_backup_*

Alexander Barkov made changes - 2023-02-03 03:46

Status

Open [ 1 ]

In Progress [ 3 ]

Alexander Barkov added a comment - 2023-02-03 03:47

serg, please review this patch:
https://github.com/MariaDB/server/commit/ba70039c89b91dc1017d1451864bcd3caa3cbda0

Thanks!

Alexander Barkov added a comment - 2023-02-03 03:47 serg , please review this patch: https://github.com/MariaDB/server/commit/ba70039c89b91dc1017d1451864bcd3caa3cbda0 Thanks!

Alexander Barkov made changes - 2023-02-03 03:47

Status

In Progress [ 3 ]

In Testing [ 10301 ]

Alexander Barkov made changes - 2023-02-03 03:47

Status

In Testing [ 10301 ]

Stalled [ 10000 ]

Alexander Barkov made changes - 2023-02-03 03:47

Assignee	Alexander Barkov [ bar ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Daniel Black made changes - 2023-02-06 23:12

Link

This issue is part of MDEV-30201 [ MDEV-30201 ]

Sergei Golubchik made changes - 2023-02-16 21:01

Assignee

Sergei Golubchik [ serg ]

Vladislav Lesin [ vlad.lesin ]

Vladislav Lesin made changes - 2023-03-01 13:22

Assignee	Vladislav Lesin [ vlad.lesin ]	Alexander Barkov [ bar ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Alexander Barkov made changes - 2023-03-07 08:23

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Alexander Barkov made changes - 2023-03-07 08:23

Status

In Progress [ 3 ]

In Testing [ 10301 ]

Alexander Barkov made changes - 2023-03-07 08:23

Status

In Testing [ 10301 ]

Stalled [ 10000 ]

Alexander Barkov added a comment - 2023-03-07 08:24

Hi vlad.lesin,

Please review a new patch version:

https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee

Thanks.

Alexander Barkov added a comment - 2023-03-07 08:24 Hi vlad.lesin , Please review a new patch version: https://github.com/MariaDB/server/commit/39184ac9a0cb2cb56ef286a6b23b3becb729d2ee Thanks.

Alexander Barkov made changes - 2023-03-07 08:24

Status

Stalled [ 10000 ]

In Review [ 10002 ]

Vladislav Lesin added a comment - 2023-03-07 13:05 - edited

bar, I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg, could you please suggest how to fix the script?

Vladislav Lesin added a comment - 2023-03-07 13:05 - edited bar , I have some doubts about xtrabackup_galera_info renaming. It's used in ./scripts/wsrep_sst_mariabackup.sh for creating state for adding new node to galera cluster. If we just rename it and don't fix the script, it will be broken. I think there should be the same logic in this script as for backup preparing, i.e. try to use old file name, and then the new one. sysprg , could you please suggest how to fix the script?

Vladislav Lesin added a comment - 2023-03-09 13:56

Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.

Vladislav Lesin added a comment - 2023-03-09 13:56 Taking into account that the galera sst script for mariabackup will be fixed by Julius, https://github.com/MariaDB/server/commit/0f97bd1244d7c7618698b46327dc2a0900fd8026 looks good to me.

Alexander Barkov made changes - 2023-03-09 14:07

Link

This issue relates to ~~MDEV-30822~~ [ ~~MDEV-30822~~ ]

Alexander Barkov made changes - 2023-03-09 14:20

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Alexander Barkov made changes - 2023-03-09 14:20

Fix Version/s		11.1.0 [ 28705 ]
Fix Version/s	11.1 [ 28549 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Ralf Gebhardt made changes - 2023-03-21 09:25

Labels

mariabackup

Preview_11.1 mariabackup

Michael Widenius added a comment - 2024-09-04 12:19

I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong.
It is better to revert to use the old names if the new name does not exist and old name exists.

Michael Widenius added a comment - 2024-09-04 12:19 I do not like the idea of renaming files at a later stage as this would make it impossible to use the backup with an older version if things goes wrong. It is better to revert to use the old names if the new name does not exist and old name exists.

Michael Widenius added a comment - 2024-09-04 12:23

As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

Michael Widenius added a comment - 2024-09-04 12:23 As we are guaranteeing that one can move from ANY MariaDB version to ANY future version of MariaDB without any fuss, we can NEVER remove supporting the old names from the code. Not in 12.0 or later.

Jan Lindström made changes - 2024-09-05 09:23

Link

This issue causes ~~MDEV-34856~~ [ ~~MDEV-34856~~ ]

Hartmut Holzgraefe made changes - 2025-03-10 14:59

Link

This issue causes MDEV-36259 [ MDEV-36259 ]

People

Assignee:: Alexander Barkov

Reporter:: Geoff Montee (Inactive)

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 2019-03-14 21:55

Updated:: 2025-03-10 14:59

Resolved:: 2023-03-09 14:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration