Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28861

Spider: Deprecate table options by COMMENT

Details

    Description

      MDEV-28856 implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT and CONNECTION.

      MDEV-31146 proposes that SHOW CREATE TABLE shows options, which is optional and could be done in a separate ticket if needed.

      Other than that COMMENT and CONNECTION will cause a deprecation warning, and every param in COMMENT and CONNECTION that does not have a corresponding table option will cause a separate deprecation warning.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-31146 Spider: Remove table options by COMMENT

          • Critical - Crashes, loss of data, severe memory leak.
          • Open
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32999 ERROR 138 instead of warning, and potential error masking

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          includes

          Task - A task that needs to be done. MDEV-32856 deprecate spider table params regarding table stats retrieval

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-28856 Spider: Implement more engine-defined options

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32999 ERROR 138 instead of warning, and potential error masking

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-27106 Spider: specify connection to data node by engine-defined attributes

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Technical task - A technical task. MDEV-31789 Deprecate spider_casual_read

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            d70daaa3cd3 upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks d70daaa3cd3 upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection
            ycp Yuchen Pei added a comment -

            Sorry, I forgot about deprecating params not selected for table options in MDEV-28856. Will need to rework a bit.

            ycp Yuchen Pei added a comment - Sorry, I forgot about deprecating params not selected for table options in MDEV-28856 . Will need to rework a bit.
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            6462be25c3a upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks 6462be25c3a upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            Hi Roel, ptal thanks

            upstream/bb-11.4-mdev-28861 f93c20081a8a505ac502850ec02630f95673dfba
            		 
            MDEV-28861 Deprecate spider table options by comment/connection
            		 
             
            		 
            Also deprecating table params not implemented in MDEV-28856.

            ycp Yuchen Pei added a comment - Hi Roel , ptal thanks upstream/bb-11.4-mdev-28861 f93c20081a8a505ac502850ec02630f95673dfba MDEV-28861 Deprecate spider table options by comment/connection   Also deprecating table params not implemented in MDEV-28856.
            Roel Roel Van de Paar added a comment -

            Created MDEV-32999 ERROR 138 instead of warning, and potential error masking

            Roel Roel Van de Paar added a comment - Created MDEV-32999 ERROR 138 instead of warning, and potential error masking
            Roel Roel Van de Paar added a comment -

            Created MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

            Roel Roel Van de Paar added a comment - Created MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE
            Roel Roel Van de Paar added a comment - - edited

            OK to push. Please note MDEV-32999.

            Roel Roel Van de Paar added a comment - - edited OK to push. Please note MDEV-32999 .
            Roel Roel Van de Paar added a comment -

            Re-signoff after MDEV-32999 fix. OK to push to 11.4.

            Roel Roel Van de Paar added a comment - Re-signoff after MDEV-32999 fix. OK to push to 11.4.
            ycp Yuchen Pei added a comment -

            Pushed 20741b92370ee48843d6101b6d6eaecab58ba41a to 11.4

            ycp Yuchen Pei added a comment - Pushed 20741b92370ee48843d6101b6d6eaecab58ba41a to 11.4

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.