[MDEV-28861] Spider: Deprecate table options by COMMENT Created: 2022-06-16  Updated: 2024-01-24  Resolved: 2024-01-24

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: 11.4.1

Type: Task Priority: Critical
Reporter: Nayuta Yanagisawa (Inactive) Assignee: Yuchen Pei
Resolution: Fixed Votes: 0
Labels: Preview_11.4

Issue Links:
Blocks
blocks MDEV-31146 Spider: Remove table options by COMMENT Open
is blocked by MDEV-28856 Spider: Implement more engine-defined... Closed
is blocked by MDEV-32999 ERROR 138 instead of warning, and pot... Closed
PartOf
includes MDEV-32856 deprecate spider table params regardi... Closed
Problem/Incident
causes MDEV-32999 ERROR 138 instead of warning, and pot... Closed
causes MDEV-33195 Assertion `!is_set() || (m_status == ... Closed
Relates
relates to MDEV-27106 Spider: specify connection to data no... Closed
relates to MDEV-33388 Dedicated table options for Spider+ODBC Open

 Description   

MDEV-28856 implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT and CONNECTION.

MDEV-31146 proposes that SHOW CREATE TABLE shows options, which is optional and could be done in a separate ticket if needed.

Other than that COMMENT and CONNECTION will cause a deprecation warning, and every param in COMMENT and CONNECTION that does not have a corresponding table option will cause a separate deprecation warning.

 Comments   
Comment by Yuchen Pei [ 2023-12-01 ]

Hi holyfoot, ptal thanks

d70daaa3cd3 upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

Comment by Yuchen Pei [ 2023-12-01 ]

Sorry, I forgot about deprecating params not selected for table options in MDEV-28856. Will need to rework a bit.

Comment by Yuchen Pei [ 2023-12-01 ]

Hi holyfoot, ptal thanks

6462be25c3a upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

Comment by Alexey Botchkov [ 2023-12-03 ]

ok to push.

Comment by Yuchen Pei [ 2023-12-05 ]

Hi Roel, ptal thanks

upstream/bb-11.4-mdev-28861 f93c20081a8a505ac502850ec02630f95673dfba
 
MDEV-28861 Deprecate spider table options by comment/connection
 
 
 
Also deprecating table params not implemented in MDEV-28856.

Comment by Roel Van de Paar [ 2023-12-12 ]

Created MDEV-32999 ERROR 138 instead of warning, and potential error masking

Comment by Roel Van de Paar [ 2024-01-07 ]

Created MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

Comment by Roel Van de Paar [ 2024-01-17 ]

OK to push. Please note MDEV-32999.

Comment by Roel Van de Paar [ 2024-01-23 ]

Re-signoff after MDEV-32999 fix. OK to push to 11.4.

Comment by Yuchen Pei [ 2024-01-24 ]

Pushed 20741b92370ee48843d6101b6d6eaecab58ba41a to 11.4

Generated at Thu Feb 08 10:04:02 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.