[MDEV-28861] Spider: Deprecate table options by COMMENT - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 11.4.1
Component/s: Storage Engine - Spider
Labels:
- Preview_11.4

Description

~~MDEV-28856~~ implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT and CONNECTION.

MDEV-31146 proposes that SHOW CREATE TABLE shows options, which is optional and could be done in a separate ticket if needed.

Other than that COMMENT and CONNECTION will cause a deprecation warning, and every param in COMMENT and CONNECTION that does not have a corresponding table option will cause a separate deprecation warning.

Attachments

Issue Links

blocks

MDEV-31146 Spider: Remove table options by COMMENT

Open

causes

MDEV-32999 ERROR 138 instead of warning, and potential error masking

Closed

MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

Closed

includes

MDEV-32856 deprecate spider table params regarding table stats retrieval

Closed

is blocked by

MDEV-28856 Spider: Implement more engine-defined options

Closed

MDEV-32999 ERROR 138 instead of warning, and potential error masking

Closed

relates to

MDEV-27106 Spider: specify connection to data node by engine-defined attributes

Closed

MDEV-31789 Deprecate spider_casual_read

Closed

(1 is blocked by, 2 relates to)

Activity

Ascending order - Click to sort in descending order

Nayuta Yanagisawa (Inactive) created issue - 2022-06-16 04:10

Nayuta Yanagisawa (Inactive) made changes - 2022-06-16 04:10

Field	Original Value	New Value
Link		This issue is blocked by ~~MDEV-28856~~ [ ~~MDEV-28856~~ ]

Julien Fritsch made changes - 2023-04-27 14:52

Fix Version/s

10.8 [ 26121 ]

Yuchen Pei made changes - 2023-04-28 01:40

Link

This issue relates to ~~MDEV-27106~~ [ ~~MDEV-27106~~ ]

Ralf Gebhardt made changes - 2023-04-28 06:06

Fix Version/s		11.3 [ 28565 ]
Fix Version/s	10.9 [ 26905 ]

Ralf Gebhardt made changes - 2023-04-28 06:10

Link

This issue blocks MDEV-31146 [ MDEV-31146 ]

Ralf Gebhardt made changes - 2023-04-28 06:12

Assignee

Nayuta Yanagisawa [ JIRAUSER47117 ]

Yuchen Pei [ JIRAUSER52627 ]

Ralf Gebhardt made changes - 2023-07-21 08:27

Link

This issue relates to MENT-813 [ MENT-813 ]

Yuchen Pei made changes - 2023-08-28 05:59

Fix Version/s		N/A [ 14700 ]
Fix Version/s	11.3 [ 28565 ]
Resolution		Duplicate [ 3 ]
Status	Open [ 1 ]	Closed [ 6 ]

Yuchen Pei made changes - 2023-08-28 06:01

Resolution	Duplicate [ 3 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Yuchen Pei made changes - 2023-08-28 06:01

Comment

[ This will be done as a part of ~~MDEV-28856~~ ]

Yuchen Pei made changes - 2023-08-28 06:01

Fix Version/s		11.3 [ 28565 ]
Fix Version/s	N/A [ 14700 ]

Yuchen Pei made changes - 2023-08-30 23:46

Description

~~MDEV-28856~~ implements the engine-defined options corresponding to major table options. So, we now deprecate the table options, specified by COMMENT, which have engine-defined option correspondence. Also, deprecate non-major, rarely used table options.

~~MDEV-28856~~ implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT.

As proposed in MDEV-31146[1], changes in this ticket will cause COMMENT to be still accepted, but SHOW CREATE TABLE shows options. COMMENT will cause a deprecation warning, and every param in COMMENT that does not have a corresponding table option will cause a separate deprecation warning.

Yuchen Pei made changes - 2023-08-30 23:47

Priority

Major [ 3 ]

Critical [ 2 ]

Yuchen Pei made changes - 2023-09-01 07:46

Description

~~MDEV-28856~~ implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT and CONNECTION.

As proposed in MDEV-31146[1], changes in this ticket will cause COMMENT to be still accepted, but SHOW CREATE TABLE shows options. COMMENT and CONNECTION will cause a deprecation warning, and every param in COMMENT and CONNECTION that does not have a corresponding table option will cause a separate deprecation warning.

Sergei Golubchik made changes - 2023-09-17 18:02

Fix Version/s		11.4 [ 29301 ]
Fix Version/s	11.3 [ 28565 ]

Sergei Golubchik made changes - 2023-10-30 12:59

Fix Version/s		11.5 [ 29506 ]
Fix Version/s	11.4 [ 29301 ]

Yuchen Pei made changes - 2023-11-30 01:50

Fix Version/s		11.4 [ 29301 ]
Fix Version/s	11.5 [ 29506 ]

Yuchen Pei made changes - 2023-11-30 01:50

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Yuchen Pei made changes - 2023-11-30 02:19

Description

~~MDEV-28856~~ implements the engine-defined options corresponding to major table options. So, we now deprecate all table params specified by COMMENT and CONNECTION.

MDEV-31146 proposes that SHOW CREATE TABLE shows options, which is optional and could be done in a separate ticket if needed.

Other than that COMMENT and CONNECTION will cause a deprecation warning, and every param in COMMENT and CONNECTION that does not have a corresponding table option will cause a separate deprecation warning.

Julien Fritsch made changes - 2023-11-30 16:29

Issue Type

Task [ 3 ]

New Feature [ 2 ]

Ralf Gebhardt made changes - 2023-11-30 16:43

Issue Type

New Feature [ 2 ]

Task [ 3 ]

Yuchen Pei added a comment - 2023-12-01 06:54

Hi holyfoot, ptal thanks

d70daaa3cd3 upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

Yuchen Pei added a comment - 2023-12-01 06:54 Hi holyfoot , ptal thanks d70daaa3cd3 upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

Yuchen Pei made changes - 2023-12-01 06:54

Assignee	Yuchen Pei [ JIRAUSER52627 ]	Alexey Botchkov [ holyfoot ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Yuchen Pei added a comment - 2023-12-01 06:56

Sorry, I forgot about deprecating params not selected for table options in ~~MDEV-28856~~. Will need to rework a bit.

Yuchen Pei added a comment - 2023-12-01 06:56 Sorry, I forgot about deprecating params not selected for table options in MDEV-28856 . Will need to rework a bit.

Yuchen Pei made changes - 2023-12-01 06:56

Status

In Review [ 10002 ]

In Testing [ 10301 ]

Yuchen Pei made changes - 2023-12-01 06:56

Assignee	Alexey Botchkov [ holyfoot ]	Yuchen Pei [ JIRAUSER52627 ]
Status	In Testing [ 10301 ]	Stalled [ 10000 ]

Yuchen Pei made changes - 2023-12-01 06:56

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Yuchen Pei added a comment - 2023-12-01 07:42

Hi holyfoot, ptal thanks

6462be25c3a upstream/bb-11.4-mdev-28861 ~~MDEV-28861~~ Deprecate spider table options by comment/connection

Yuchen Pei added a comment - 2023-12-01 07:42 Hi holyfoot , ptal thanks 6462be25c3a upstream/bb-11.4-mdev-28861 MDEV-28861 Deprecate spider table options by comment/connection

Yuchen Pei made changes - 2023-12-01 07:42

Assignee	Yuchen Pei [ JIRAUSER52627 ]	Alexey Botchkov [ holyfoot ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Alexey Botchkov added a comment - 2023-12-03 10:32

ok to push.

Alexey Botchkov added a comment - 2023-12-03 10:32 ok to push.

Alexey Botchkov made changes - 2023-12-03 10:32

Assignee	Alexey Botchkov [ holyfoot ]	Yuchen Pei [ JIRAUSER52627 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Yuchen Pei made changes - 2023-12-05 03:42

Status

Stalled [ 10000 ]

In Testing [ 10301 ]

Yuchen Pei made changes - 2023-12-05 03:42

Assignee

Yuchen Pei [ JIRAUSER52627 ]

Roel Van de Paar [ roel ]

Yuchen Pei added a comment - 2023-12-05 03:46

Hi Roel, ptal thanks

upstream/bb-11.4-mdev-28861 f93c20081a8a505ac502850ec02630f95673dfba

MDEV-28861 Deprecate spider table options by comment/connection

Also deprecating table params not implemented in MDEV-28856.

Yuchen Pei added a comment - 2023-12-05 03:46 Hi Roel , ptal thanks upstream/bb-11.4-mdev-28861 f93c20081a8a505ac502850ec02630f95673dfba MDEV-28861 Deprecate spider table options by comment/connection Also deprecating table params not implemented in MDEV-28856.

Roel Van de Paar added a comment - 2023-12-12 08:32

Created ~~MDEV-32999~~ ERROR 138 instead of warning, and potential error masking

Roel Van de Paar added a comment - 2023-12-12 08:32 Created MDEV-32999 ERROR 138 instead of warning, and potential error masking

Roel Van de Paar made changes - 2023-12-12 08:32

Link

This issue causes ~~MDEV-32999~~ [ ~~MDEV-32999~~ ]

Yuchen Pei made changes - 2023-12-13 00:20

Link

This issue causes ~~MDEV-32999~~ [ ~~MDEV-32999~~ ]

Roel Van de Paar made changes - 2023-12-16 00:13

Link

This issue causes ~~MDEV-32999~~ [ ~~MDEV-32999~~ ]

Sergei Golubchik made changes - 2023-12-22 09:35

Link

This issue causes TODO-4495 [ TODO-4495 ]

Sergei Golubchik made changes - 2023-12-22 11:12

Link

This issue causes TODO-4495 [ TODO-4495 ]

Sergei Golubchik made changes - 2023-12-22 11:13

Link

This issue is part of TODO-4495 [ TODO-4495 ]

Ralf Gebhardt made changes - 2023-12-27 10:20

Labels

Preview_11.4

Roel Van de Paar made changes - 2023-12-29 20:54

Link

This issue includes ~~MDEV-32856~~ [ ~~MDEV-32856~~ ]

Roel Van de Paar made changes - 2023-12-29 21:29

Link

This issue is duplicated by ~~MDEV-32856~~ [ ~~MDEV-32856~~ ]

Roel Van de Paar made changes - 2023-12-29 21:29

Link

This issue is duplicated by ~~MDEV-32856~~ [ ~~MDEV-32856~~ ]

Roel Van de Paar made changes - 2024-01-07 20:06

Link

This issue causes ~~MDEV-33195~~ [ ~~MDEV-33195~~ ]

Roel Van de Paar added a comment - 2024-01-07 20:07

Created ~~MDEV-33195~~ Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

Roel Van de Paar added a comment - 2024-01-07 20:07 Created MDEV-33195 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on UPDATE

Roel Van de Paar made changes - 2024-01-17 00:35

Comment

[ [~ycp] Hi! With low frequency (seen 3 times overall) I have observed this error:
{noformat}
[ERROR] Error reading packet from server: Binary log is not open (server_errno=1236)
{noformat}
In the feature branch and nowhere else (all runs, test-server-wide). This is somewhat odd and one would generally expect this to be a bug to be in the feature, however it is 1) not reproducible in any way, even once, 2) it looks very unrelated to the patch code. I am going for the moment subscribe it to a fluke (OOS perhaps). Still, wanted to flag it in case it rings any bells for you. ]

Roel Van de Paar added a comment - 2024-01-17 01:35 - edited

OK to push. Please note ~~MDEV-32999~~.

Roel Van de Paar added a comment - 2024-01-17 01:35 - edited OK to push. Please note MDEV-32999 .

Roel Van de Paar made changes - 2024-01-17 01:39

Assignee	Roel Van de Paar [ roel ]	Yuchen Pei [ JIRAUSER52627 ]
Status	In Testing [ 10301 ]	Stalled [ 10000 ]

Roel Van de Paar made changes - 2024-01-17 01:40

Link

This issue relates to TODO-3120 [ TODO-3120 ]

Yuchen Pei made changes - 2024-01-22 05:01

Link

This issue is blocked by ~~MDEV-32999~~ [ ~~MDEV-32999~~ ]

Roel Van de Paar added a comment - 2024-01-23 22:05

Re-signoff after ~~MDEV-32999~~ fix. OK to push to 11.4.

Roel Van de Paar added a comment - 2024-01-23 22:05 Re-signoff after MDEV-32999 fix. OK to push to 11.4.

Yuchen Pei added a comment - 2024-01-24 02:59

Pushed 20741b92370ee48843d6101b6d6eaecab58ba41a to 11.4

Yuchen Pei added a comment - 2024-01-24 02:59 Pushed 20741b92370ee48843d6101b6d6eaecab58ba41a to 11.4

Yuchen Pei made changes - 2024-01-24 02:59

Fix Version/s		11.4.1 [ 29523 ]
Fix Version/s	11.4 [ 29301 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Roel Van de Paar made changes - 2024-03-09 02:35

Link

This issue relates to ~~MDEV-31789~~ [ ~~MDEV-31789~~ ]

People

Assignee:: Yuchen Pei

Reporter:: Nayuta Yanagisawa (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 2022-06-16 04:10

Updated:: 2025-03-13 11:32

Resolved:: 2024-01-24 02:59

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration