Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.3.1
Description
This is a list smaller bugs for SEQUENCE's that should be fixed before 10.3.1. A lot of the following things where reported by Peter Gulutzan.
Bugs and missing features
- SET @x = PREVIOUS VALUE FOR x;
> Result = Error 1146 (42S02) Table 'test.x' doesn't exist
Should be SEQUENCE doesn't exists
- CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678;
> Result = Error 4061 (HY000) Sequence 'test.x' values are conflicting
> This is not a helpful message, saying "too big number" would be better.
- Create better error messages for the test of initial seqeunce values in:
bool sequence_definition::check_and_adjust(bool set_reserved_until)
But try to create reusable error messages
Type:
%s must be less than %s
Too big value for %s
Add also a check the cache can't be < 0 and not equal or bigger than
LONGLONG_MAX.
- This should give an error for the second create:
CREATE TEMPORARY TABLE s1 (s1 INT);
CREATE TEMPORARY SEQUENCE s1 (s1 INT);
- CREATE TABLE s1 (s1 INT);
DROP SEQUENCE s1;
> Error 4066 (42S02) 'test.s1' is not a SEQUENCE
CREATE TEMPORARY TABLE s1 (s1 INT);
DROP TEMPORARY SEQUENCE s1;
> Error 4067 (42S02) Unknown SEQUENCE: 'test.s1'
The second DROP should also give error 4066
- create trigger s1 before update on sequence_name for each row set @a = 5;
The above should fail with a new error 'One can't create a trigger on
a sequence"
Attachments
Issue Links
- causes
-
-
- Closed
-
- is part of
-
MDEV-10139 Support for SEQUENCE objects
-
- Closed
-
- relates to
-
-
- Confirmed
-
-
MDEV-28152 Features for sequence
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is part of |
| Fix Version/s | 10.4 [ 22408 ] |
| Labels | beginner-friendly |
Hi rucha174
let's start with
CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678; |
So what I usually do when dealing with error messages is to put the breakpoint on
my_message_sql
|
.
After doing so you will get the backtrace like so:
(gdb) bt
|
+bt
|
#0 my_message_sql (error=4085, str=0x7ffff410a230 "Sequence 'test.x' values are conflicting", MyFlags=0) at sql/mysqld.cc:3258
|
#1 0x000055555674fb4e in my_error (nr=4085, MyFlags=0) at mysys/my_error.c:125
|
#2 0x0000555555f310ba in MYSQLparse (thd=0x7fff64000cf8) at /home/anel/workspace/server/sql/sql_yacc.yy:2708
|
#3 0x0000555555cd53de in parse_sql (thd=0x7fff64000cf8, parser_state=0x7ffff410c1b0, creation_ctx=0x0, do_pfs_digest=true) at sql/sql_parse.cc:10247
|
#4 0x0000555555cd0314 in mysql_parse (thd=0x7fff64000cf8, rawbuf=0x7fff64014af0 "CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678", length=62, parser_state=0x7ffff410c1b0, is_com_multi=false, is_next_command=false) at sql/sql_parse.cc:8157
|
#5 0x0000555555cbb95d in dispatch_command (command=COM_QUERY, thd=0x7fff64000cf8, packet=0x7fff64009f79 "CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678", packet_length=62, is_com_multi=false, is_next_command=false) at sql/sql_parse.cc:1828
|
#6 0x0000555555cba193 in do_command (thd=0x7fff64000cf8) at sql/sql_parse.cc:1357
|
#7 0x0000555555e2da46 in do_handle_one_connection (connect=0x555558a68948) at sql/sql_connect.cc:1399
|
#8 0x0000555555e2d7aa in handle_one_connection (arg=0x555558a68948) at sql/sql_connect.cc:1302
|
#9 0x00007ffff6c996db in start_thread (arg=0x7ffff410d700) at pthread_create.c:463
|
#10 0x00007ffff5e7f88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
|
Now if you go in
|
(gdb) f 2
|
+f 2
|
#2 0x0000555555f310ba in MYSQLparse (thd=0x7fff64000cf8) at /home/anel/workspace/server/sql/sql_yacc.yy:2708
|
you will see error
ER_SEQUENCE_INVALID_DATA
|
that is raised in .yacc file:
if (unlikely(lex->create_info.seq_create_info->check_and_adjust(1))) │
|
│2707 { │
|
>│2708 my_error(ER_SEQUENCE_INVALID_DATA, MYF(0), │
|
│2709 lex->first_select_lex()->table_list.first->db.str, │
|
│2710 lex->first_select_lex()->table_list.first-> │
|
│2711 table_name.str); │
|
│2712 MYSQL_YYABORT; │
|
│2713 }
|
Now to see this error you will need to go in
./sql/share/errmsg-utf8.txt
|
Try to do the same procedure, find this message and change it, compile again and run, new result should be obtained.
If you need additional help please feel free to ask on our zulip channel https://mariadb.zulipchat.com/# where also other developer will be active and provide you additional help.
Happy coding ^^
I changed error message for:
(42S02) "Table 'test.x' doesn't exist" to "Sequence doesn't exist." and
Error 4061 (HY000) "Sequence 'test.x' values are conflicting" to "Too big number"
| Link | This issue relates to MDEV-22705 [ MDEV-22705 ] |
| Assignee | Rucha Deodhar [ rucha174 ] |
| Parent |
|
|
| Issue Type | Technical task [ 7 ] | Bug [ 1 ] |
| Epic Link | MDEV-11070 [ 58519 ] |
| Workflow | MariaDB v3 [ 81112 ] | MariaDB v4 [ 140334 ] |
| Comment | [ [~ralf.gebhardt@mariadb.com] I wouldn't mind splitting it up and agree that it would be better or I can make multiple commits , one for each bug. Whichever seems more right. ] |
| Description |
This is a list of trivial missing features and smaller bugs for SEQUENCE's that should be fixed before 10.3.1. A lot of the following things where reported by Peter Gulutzan.
Bugs and missing features - SET @x = PREVIOUS VALUE FOR x; > Result = Error 1146 (42S02) Table 'test.x' doesn't exist Should be SEQUENCE doesn't exists - Support syntax "CREATE SEQUENCE x AS BIGINT'; - CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678; > Result = Error 4061 (HY000) Sequence 'test.x' values are conflicting > This is not a helpful message, saying "too big number" would be better. - Create better error messages for the test of initial seqeunce values in: bool sequence_definition::check_and_adjust(bool set_reserved_until) But try to create reusable error messages Type: %s must be less than %s Too big value for %s Add also a check the cache can't be < 0 and not equal or bigger than LONGLONG_MAX. - Allow in parser very big numbers (decimal) for MAXVALUE but change these to LONGLONG_MAX-1, with a note for the user. This is needes as it's common practice to use MAXVALUE 9999999999999999999999999999 in Oracle examples. - This should give an error for the second create: CREATE TEMPORARY TABLE s1 (s1 INT); CREATE TEMPORARY SEQUENCE s1 (s1 INT); - CREATE TABLE s1 (s1 INT); DROP SEQUENCE s1; > Error 4066 (42S02) 'test.s1' is not a SEQUENCE CREATE TEMPORARY TABLE s1 (s1 INT); DROP TEMPORARY SEQUENCE s1; > Error 4067 (42S02) Unknown SEQUENCE: 'test.s1' The second DROP should also give error 4066 - create trigger s1 before update on sequence_name for each row set @a = 5; The above should fail with a new error 'One can't create a trigger on a sequence" - Create information_schema.sequences that lists all sequences and their information. Should work similar to views: select * from information_schema.sequences where table_schema="test"; The column names are: SEQUENCE_CATALOG, SEQUENCE_SCHEMA, SEQUENCE_NAME, DATA_TYPE, NUMERIC_PRECISION, NUMERIC_PRECISION_RADIX, NUMERIC_SCALE, START_VALUE, MINIMUM_VALUE, MAXIMUM_VALUE, INCREMENT, CYCLE_OPTION, DECLARED_DATA_TYPE, DECLARED_NUMERIC_PRECISION, DECLARED_NUMERIC_SCALE Some suggested values: DATA_TYPE BIGINT DECLARED_DATA_TYPE BIGINT NUMERIC_PRECISION 19 NUMERIC_PRECISION_RADIX 10 DECLARED_DATA_TYPE NULL DECLARED_NUMERIC_PRECISION NULL DECLARED_NUMERIC_SCALE NULL |
This is a list smaller bugs for SEQUENCE's that should be fixed before 10.3.1. A lot of the following things where reported by Peter Gulutzan.
Bugs and missing features - SET @x = PREVIOUS VALUE FOR x; > Result = Error 1146 (42S02) Table 'test.x' doesn't exist Should be SEQUENCE doesn't exists - CREATE SEQUENCE x START WITH 1 INCREMENT BY 123456789012345678; > Result = Error 4061 (HY000) Sequence 'test.x' values are conflicting > This is not a helpful message, saying "too big number" would be better. - Create better error messages for the test of initial seqeunce values in: bool sequence_definition::check_and_adjust(bool set_reserved_until) But try to create reusable error messages Type: %s must be less than %s Too big value for %s Add also a check the cache can't be < 0 and not equal or bigger than LONGLONG_MAX. - This should give an error for the second create: CREATE TEMPORARY TABLE s1 (s1 INT); CREATE TEMPORARY SEQUENCE s1 (s1 INT); - CREATE TABLE s1 (s1 INT); DROP SEQUENCE s1; > Error 4066 (42S02) 'test.s1' is not a SEQUENCE CREATE TEMPORARY TABLE s1 (s1 INT); DROP TEMPORARY SEQUENCE s1; > Error 4067 (42S02) Unknown SEQUENCE: 'test.s1' The second DROP should also give error 4066 - create trigger s1 before update on sequence_name for each row set @a = 5; The above should fail with a new error 'One can't create a trigger on a sequence" |
| Link |
This issue relates to |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Rucha Deodhar [ rucha174 ] | Oleksandr Byelkin [ sanja ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Oleksandr Byelkin [ sanja ] | Rucha Deodhar [ rucha174 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Assignee | Rucha Deodhar [ rucha174 ] | Oleksandr Byelkin [ sanja ] |
| Status | Stalled [ 10000 ] | In Review [ 10002 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Assignee | Oleksandr Byelkin [ sanja ] | Rucha Deodhar [ rucha174 ] |
| Comment | [ review ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.4.25 [ 27510 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Fix Version/s | 10.5.16 [ 27508 ] | |
| Fix Version/s | 10.6.8 [ 27506 ] | |
| Fix Version/s | 10.7.4 [ 27504 ] | |
| Fix Version/s | 10.8.3 [ 27502 ] | |
| Fix Version/s | 10.9.1 [ 27114 ] |
| Link |
This issue causes |
I am new dev and can help with this. I went through the code base, but couldn't find the code where these bugs are present. Any help is appreciated. Thanks.