Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2, 10.2.6-3
Description
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
Inclusion itself
See MDEV-10965: Add MyRocks into MariaDB repository
Packaging
See MDEV-10966 - Packaging for MariaRocks
Required changes at the SQL layer
A list of changes in the FB tree that touch the SQL layer (based on git log output):
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
- also check if da1d92fd (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
- MariaDB has just got NO_PAD collations:
MDEV-9711. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.
- rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from bc4145e7
- MDEV-10975: Merging of @@rocksdb_skip_unique_check
- MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks
Group Commit with Binlog (and Optimistic Parallel Replication).
MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.
Other issues
- mysql-test-run should not require any additional parameters when running MyRocks tests.
- packaging for myrocks_hotbackup
- Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
- TODO what is missing?
Attachments
Issue Links
- includes
-
MDEV-10965 Add MyRocks into MariaDB repository
-
- Closed
-
-
MDEV-10966 Packaging for MariaRocks
-
- Closed
-
-
MDEV-10975 Merging of @@rocksdb_skip_unique_check
-
- Open
-
-
MDEV-10976 Port MyRocks' Read Free Replication to MariaRocks
-
- Open
-
-
MDEV-11124 MariaRocks: rocksdb.rocksdb fails with a duplicate key error
-
- Closed
-
-
MDEV-11194 MariaRocks: rocksdb.rocksdb_range test failure
-
- Closed
-
-
MDEV-11318 MariaRocks: rocksdb.rocksdb test fails
-
- Closed
-
-
MDEV-11320 MariaRocks: rocksdb.type_text_indexes fails
-
- Closed
-
-
MDEV-11321 MariaRocks: type_binary_indexes, type_blob_indexes fail due to different index statistics
-
- Closed
-
-
MDEV-11329 MariaRocks: rocksdb.add_index_inplace fails
-
- Closed
-
-
MDEV-11462 MariaRocks: rocksdb.type_float_indexes fails
-
- Closed
-
-
MDEV-11477 MariaRocks: rocksdb.type_varchar failure
-
- Closed
-
-
MDEV-11480 MariaRocks port: rocksdb.slow_query_log test (DISABLED)
-
- Open
-
-
MDEV-11481 MariaRocks port: rocksdb.select_for_update_skip_locked_nowait (DISABLED)
-
- Open
-
-
MDEV-11735 MyRocks: Gap Lock detector support
-
- Closed
-
-
MDEV-11901 MariaDB Rocks on Windows
-
- Closed
-
-
MDEV-11934 MariaRocks: Group Commit with binlog
-
- Closed
-
-
MDEV-11946 MariaRocks: review the changes on SQL layer
-
- Closed
-
-
MDEV-12189 MariaRocks packaging: disable x86 builds
-
- Closed
-
-
MDEV-12196 MariaRocks: compile failure on Windows
-
- Closed
-
-
MDEV-12249 MariaRocks: find a way to handle paths to scripts/includes in MTR
-
- Closed
-
-
MDEV-12254 MariaRocks: check whether it gets into packages
-
- Closed
-
-
MDEV-12277 rocksdb.rocksdb fails with Sort Aborted error in server stderr
-
- Closed
-
-
MDEV-12279 rocksdb.tbl_opt_data_index_dir fails, wrong error code
-
- Closed
-
-
MDEV-12280 rocksdb.collation test started to fail with a crash
-
- Closed
-
-
MDEV-12285 MariaRocks: [ERROR] mysqld: Deadlock found when trying to get lock messages in server stderr
-
- Closed
-
-
MDEV-12286 rocksdb.blind_delete_without_tx_api test fails
-
- Open
-
-
MDEV-12316 MariaRocks: dont package ldb binary
-
- Closed
-
-
MDEV-12341 MariaRocks: rocksdb.persistent_cache test fails on some platforms
-
- Open
-
-
MDEV-12380 MariaRocks: repo, tests, and packaging for myrocks_hotbackup
-
- Open
-
-
MDEV-12424 binlog_encryption.encrypted_* tests fail with Can't locate autodie.pm error
-
- Closed
-
-
MDEV-12425 MariaRocks: Tests require too much disk space
-
- Closed
-
-
MDEV-12427 rocksdb.write_sync fails with "SyncWAL() is not supported for this implementation of WAL file"
-
- Closed
-
-
MDEV-12431 MariaRocks unittest does not compile
-
- Open
-
-
MDEV-12433 MariaRocks: rocksdb.collation crashes because of gcc bug.
-
- Open
-
-
MDEV-12439 MariaRocks produces numerous (spurious?) valgrind failures
-
- Closed
-
-
MDEV-12445 Rocksdb does not shutdown worker threads and aborts in memleak check on server shutdown
-
- Open
-
-
MDEV-12528 Run the engine-agnostic test suite on MyRocks, too
-
- Closed
-
-
MDEV-12663 rocksdb.compact_deletes times out and causes other tests to fail
-
- Closed
-
-
MDEV-14103 Testing for group commit in MyRocks
-
- Closed
-
-
MDEV-14181 rocksdb.rocksdb fails: line 1117: query 'reap' succeeded - should have failed
-
- Closed
-
-
MDEV-14892 Porting Rdb_binlog_manager to MariaDB
-
- Open
-
- relates to
-
MDEV-14106 MyRocks: port rocksdb.rpl_gtid_crash_safe test
-
- Open
-
-
MDEV-14109 MyRocks port: do we need manual update of slave_gtid_info?
-
- Open
-
-
MDEV-14372 Fix and enable rocksdb.information_schema test
-
- Open
-
-
MDEV-11172 EXPLAIN shows non-sensical value for key_len with type=index
-
- Closed
-
-
MDEV-14351 MyRocks as an embedded library
-
- Open
-
Activity
Field | Original Value | New Value |
---|---|---|
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - (TODO: that change with doing multiple requests for index_flags()) h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - (TODO: that change with doing multiple requests for index_flags()) h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 - TODO anything else? h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Status | Open [ 1 ] | Confirmed [ 10101 ] |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 - TODO anything else? h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Link |
This issue includes |
Fix Version/s | 10.2 [ 14601 ] |
Assignee | Sergei Petrunia [ psergey ] |
Link |
This issue includes |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
Summary | FR: Add RocksDB as a storage engine to MariaDB Server | Add MyRocks to MariaDB |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Subtasks * * h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Inclusion See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Inclusion See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Inclusion See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h2. Inclusion See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
Description |
MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.
Reference: https://github.com/facebook/mysql-5.6 ("FB tree") h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There *ARE* a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - The code around issue #105 and issue #108 A list of changes in the FB tree that touch the SQL layer: {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled MTR. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled MTR. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what is used. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what is used. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Link | This issue includes MDEV-10975 [ MDEV-10975 ] |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 * MDEV-10975: Merging of @@rocksdb_skip_unique_check h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Link | This issue includes MDEV-10976 [ MDEV-10976 ] |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 * MDEV-10975: Merging of @@rocksdb_skip_unique_check h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 * MDEV-10975: Merging of @@rocksdb_skip_unique_check * MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Description |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): {noformat} 65501b5 Disable unique checks when replica is lagging dd7eeae Issue#250: MyRocks/Innodb different output from query with order ... f0a2ded Per database uuid 9b439ee Add option to exclude tables from gap lock check 5bcb50c Per database uuid e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF 5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions 6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors 782cc5a Optionally block/log queries relying on Gap Locks c2dbe68 Add lock information to lock timeout error message c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys 3c0802f Improve singled thread replication performance 55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan ee00797 Compile rocksdb library with mysql compiler settings 8098b78 Add support for reporting keys/deletes skipped in the extra slow query log bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT ff91c80 Crash safe slave and master in RocksDB {noformat} * also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here: https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5 * MDEV-10975: Merging of @@rocksdb_skip_unique_check * MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.
h2. Inclusion itself See h2. Packaging See h2. Required changes at the SQL layer A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output): [65501b5|https://github.com/facebook/mysql-5.6/commit/65501b5] Disable unique checks when replica is lagging [dd7eeae|https://github.com/facebook/mysql-5.6/commit/dd7eeae] Issue#250: MyRocks/Innodb different output from query with order ... [f0a2ded|https://github.com/facebook/mysql-5.6/commit/f0a2ded] Per database uuid [9b439ee|https://github.com/facebook/mysql-5.6/commit/9b439ee] Add option to exclude tables from gap lock check [5bcb50c|https://github.com/facebook/mysql-5.6/commit/5bcb50c] Per database uuid [e9ef099|https://github.com/facebook/mysql-5.6/commit/e9ef099] Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF [5a82f20|https://github.com/facebook/mysql-5.6/commit/5a82f20] Add gcc function attributes to MyRocks code with a sprinkle of assertions [6078c85|https://github.com/facebook/mysql-5.6/commit/6078c85] Preventing to write "Got error 122.." to err log on Gap Lock errors [782cc5a|https://github.com/facebook/mysql-5.6/commit/782cc5a] Optionally block/log queries relying on Gap Locks [c2dbe68|https://github.com/facebook/mysql-5.6/commit/c2dbe68] Add lock information to lock timeout error message [c1f1f0b|https://github.com/facebook/mysql-5.6/commit/c1f1f0b] Issue #108: Index-only scans do not work for partitioned tables and extended keys [3c0802f|https://github.com/facebook/mysql-5.6/commit/3c0802f] Improve singled thread replication performance [55622f1|https://github.com/facebook/mysql-5.6/commit/55622f1] Issue #75: Prefix bloom filter is not used for LinkBench style range scan [ee00797|https://github.com/facebook/mysql-5.6/commit/ee00797] Compile rocksdb library with mysql compiler settings [8098b78|https://github.com/facebook/mysql-5.6/commit/8098b78] Add support for reporting keys/deletes skipped in the extra slow query log [bcd7646|https://github.com/facebook/mysql-5.6/commit/bcd7646] Supporting START TRANSACTION WITH CONSISTENT \[ROCKSDB] SNAPSHOT [ff91c80|https://github.com/facebook/mysql-5.6/commit/ff91c80] Crash safe slave and master in RocksDB * also check if [da1d92fd|https://github.com/facebook/mysql-5.6/commit/da1d92fd] (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that. * MariaDB has just got NO_PAD collations: https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used. * rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from [bc4145e7|https://github.com/facebook/mysql-5.6/commit/bc4145e7] * MDEV-10975: Merging of @@rocksdb_skip_unique_check * MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks h2. Group Commit with Binlog (and Optimistic Parallel Replication). MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work. h2. Other issues * mysql-test-run should not require any additional parameters when running MyRocks tests. * packaging for {{myrocks_hotbackup}} * Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar. * TODO what is missing? |
Sprint | 10.2.3-2 [ 105 ] |
Rank | Ranked lower |
Status | Confirmed [ 10101 ] | In Progress [ 3 ] |
Link |
This issue includes |
Link |
This issue relates to |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Component/s | Storage Engine - RocksDB [ 13901 ] |
Sprint | 10.2.3-2 [ 105 ] | 10.2.3-2, 10.2.4-4 [ 105, 117 ] |
Rank | Ranked lower |
Link |
This issue includes |
Link |
This issue includes |
Link | This issue includes MDEV-11480 [ MDEV-11480 ] |
Link | This issue includes MDEV-11481 [ MDEV-11481 ] |
Sprint | 10.2.3-2, 10.2.4-4 [ 105, 117 ] | 10.2.3-2, 10.2.4-4, 10.2.4-1 [ 105, 117, 121 ] |
Rank | Ranked lower |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-1 [ 105, 117, 121 ] | 10.2.3-2, 10.2.4-4, 5.5.54 [ 105, 117, 123 ] |
Rank | Ranked higher |
Sprint | 10.2.3-2, 10.2.4-4, 5.5.54 [ 105, 117, 123 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5 [ 105, 117, 125 ] |
Rank | Ranked lower |
Link |
This issue includes |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5 [ 105, 117, 125 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.1.21 [ 105, 117, 125, 130 ] |
Rank | Ranked higher |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.1.21 [ 105, 117, 125, 130 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1 [ 105, 117, 125, 132 ] |
Rank | Ranked lower |
Link |
This issue includes |
Labels | 10.2-ga |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1 [ 105, 117, 125, 132 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2 [ 105, 117, 125, 132, 134 ] |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2 [ 105, 117, 125, 132, 134 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1 [ 105, 117, 125, 132, 134, 144 ] |
Rank | Ranked higher |
Link |
This issue includes |
Link |
This issue includes |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1 [ 105, 117, 125, 132, 134, 144 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-1 [ 105, 117, 125, 132, 134, 144, 146 ] |
Rank | Ranked lower |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Link |
This issue includes |
Link | This issue includes MDEV-12286 [ MDEV-12286 ] |
Link |
This issue includes |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-1 [ 105, 117, 125, 132, 134, 144, 146 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2 [ 105, 117, 125, 132, 134, 144, 148 ] |
Rank | Ranked lower |
Link | This issue includes MDEV-12341 [ MDEV-12341 ] |
Link | This issue includes MDEV-12380 [ MDEV-12380 ] |
Sprint | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2 [ 105, 117, 125, 132, 134, 144, 148 ] | 10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2, 10.2.6-3 [ 105, 117, 125, 132, 134, 144, 148, 150 ] |
Link |
This issue includes |
Link |
This issue includes |
Link | This issue includes MDEV-12431 [ MDEV-12431 ] |
Link | This issue includes MDEV-12433 [ MDEV-12433 ] |
Link |
This issue includes |
Link |
This issue includes |
Link | This issue includes MDEV-12445 [ MDEV-12445 ] |
Link |
This issue includes |
Link |
This issue includes |
Summary | Add MyRocks to MariaDB | Make MyRocks in MariaDB stable |
Link |
This issue includes |
Link | This issue relates to MDEV-14106 [ MDEV-14106 ] |
Link | This issue relates to MDEV-14109 [ MDEV-14109 ] |
Link |
This issue includes |
Link | This issue relates to MDEV-14351 [ MDEV-14351 ] |
Link | This issue relates to MDEV-14372 [ MDEV-14372 ] |
Link | This issue includes MDEV-14892 [ MDEV-14892 ] |
Fix Version/s | 10.3 [ 22126 ] |
Priority | Major [ 3 ] | Critical [ 2 ] |
Fix Version/s | 10.2.16 [ 23110 ] | |
Fix Version/s | 10.3.7 [ 23005 ] | |
Fix Version/s | 10.2 [ 14601 ] | |
Fix Version/s | 10.3 [ 22126 ] | |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Closed [ 6 ] |
Workflow | MariaDB v3 [ 74409 ] | MariaDB v4 [ 132801 ] |