Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12249

MariaRocks: find a way to handle paths to scripts/includes in MTR

    Details

      Description

      MyRocks tests have and use (with shell or perl) extra files. Examples:

      rocksdb/t/compact_deletes_test.inc has

      let $MYSQL_SST_DUMP=../storage/rocksdb/sst_dump;
      exec bash ../storage/rocksdb/mysql-test/rocksdb/t/sst_count_rows.sh $MYSQLTEST_VARDIR $MYSQL_SST_DUMP $no_more_deletes ;
      

      Or storage/rocksdb/mysql-test/rocksdb/t/bloomfilter.inc has this piece

      let tmpl_ddl= ../storage/rocksdb/mysql-test/rocksdb/t/bloomfilter_table_def.tmpl;
      let ddl= $MYSQL_TMP_DIR/bloomfilter_create.sql;
      ...
      --exec sed s/##CF##//g $tmpl_ddl > $ddl
      --source $ddl
      

      Specifying relative paths works for the case when one runs tests from the source tree.

      However, the relative paths are different when one runs tests from the installed server (made with e.g. 'make install' or installing packages).

      This causes failures like this:
      http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-trusty-x86/builds/421/steps/test/logs/stdio

      rocksdb_default_cf_options=write_buffer_size=16k;target_file_size_base=16k;level0_slowdown_writes_trigger=-1;level0_stop_writes_trigger=1000;compression_per_level=kNoCompression;'
      rocksdb.compact_deletes                  w1 [ fail ]
              Test ended at 2017-03-13 08:23:44
      CURRENT_TEST: rocksdb.compact_deletes
      bash: ../storage/rocksdb/mysql-test/rocksdb/t/sst_count_rows.sh: No such file or directory
      mysqltest: In included file "/usr/local/mariadb-10.2.5-linux-i686/mysql-test/plugin/rocksdb/rocksdb/t/compact_deletes_test.inc": 
      included from /usr/local/mariadb-10.2.5-linux-i686/mysql-test/plugin/rocksdb/rocksdb/t/compact_deletes.test at line 43:
      At line 41: exec of 'bash ../storage/rocksdb/mysql-test/rocksdb/t/sst_count_rows.sh /usr/local/mariadb-10.2.5-linux-i686/mysql-test/var/1 ../storage/rocksdb/sst_dump 0 ' failed, error: 32512, status: 127, errno: 0
      Output from before failure:
      sleep(1)
      0
      The result from queries just before the failure was:
      < snip >
      index id1_type (id1, type, value2, value, id2)
      ) engine=rocksdb collate latin1_bin;
      select 'loading data';
      loading data
      loading data
      set global rocksdb_force_flush_memtable_now=1;
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                psergey Sergei Petrunia
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: