[MDEV-9658] Make MyRocks in MariaDB stable - Jira

Colin Charles created issue - 2016-02-29 09:30

Sergei Petrunia made changes - 2016-03-02 09:26

Field	Original Value	New Value
Description	MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine. Reference: https://github.com/facebook/mysql-5.6 It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.	MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine. Reference: https://github.com/facebook/mysql-5.6 ("FB tree") It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1. h1. Inclusion Considerations h2. Dependencies RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there. RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms. h2. Required changes at SQL layer There ARE a few changes at SQL layer required by MyRocks. - set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter - (TODO: that change with doing multiple requests for index_flags()) h2. How to package Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically. FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good? h2. Maintenance after inclusion How does one merge new changes after the initial inclusion? I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions - CMakeLists.txt - Plugin definition. - (TODO, anything else? Ask Serg/ Svoj who merge other engines) MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Sergei Petrunia made changes - 2016-03-02 09:39

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- (TODO: that change with doing multiple requests for index_flags())

h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108
- TODO anything else?

h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Valerii Kravchuk made changes - 2016-03-02 11:25

Status

Open [ 1 ]

Confirmed [ 10101 ]

Sergei Petrunia made changes - 2016-10-06 09:26

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108
- TODO anything else?

h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Sergei Petrunia made changes - 2016-10-06 09:44

Link

This issue includes ~~MDEV-10965~~ [ ~~MDEV-10965~~ ]

Sergei Petrunia made changes - 2016-10-06 09:48

Fix Version/s

10.2 [ 14601 ]

Sergei Petrunia made changes - 2016-10-06 09:48

Assignee

Sergei Petrunia [ psergey ]

Sergei Petrunia made changes - 2016-10-06 09:54

Link

This issue includes ~~MDEV-10966~~ [ ~~MDEV-10966~~ ]

Sergei Petrunia made changes - 2016-10-06 10:01

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

It would be nice to see this in MariaDB Server 10.2, but being an engine, I don't see why it can't also be included in a preview release of 10.1.

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks
* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Sergei Petrunia made changes - 2016-10-06 12:13

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks
* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Sergei Petrunia made changes - 2016-10-06 12:28

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

Sergei Petrunia made changes - 2016-10-06 12:31

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

Sergei Petrunia made changes - 2016-10-06 12:32

Summary

FR: Add RocksDB as a storage engine to MariaDB Server

Add MyRocks to MariaDB

Sergei Petrunia made changes - 2016-10-06 12:35

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

Sergei Petrunia made changes - 2016-10-06 12:38

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Subtasks

* ~~MDEV-10965~~ - Add MyRocks into MariaDB repository
* ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Inclusion

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging
See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

Sergei Petrunia made changes - 2016-10-06 12:39

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Inclusion

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging
See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Inclusion

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging
See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 12:40

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h2. Inclusion

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging
See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 12:41

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

Sergei Petrunia made changes - 2016-10-06 12:42

Description

MyRocks, the RocksDB storage engine is gaining popularity and today you can only get it working from the Facebook tree of MySQL 5.6. It would be great to have this inside of MariaDB Server considering there is a huge amount of distribution of MariaDB Server everywhere. It will increase adoption of the RocksDB engine.

Reference: https://github.com/facebook/mysql-5.6 ("FB tree")

h1. Inclusion Considerations

h2. Dependencies

RocksDB requires a recent C++ compiler. It won't compile on all platforms that MariaDB supports. I think, we already had this issue with TokuDB, and CMake code to make the check is there.

RocksDB depends on compression libraries. Ubuntu seems to have packages for all of them: https://github.com/facebook/mysql-5.6/wiki/Build-Steps (TODO: a new compression lib dependency was added since that page) Not sure about other platforms.

h2. Required changes at SQL layer
There *ARE* a few changes at SQL layer required by MyRocks.
- set_end_range(), da1d92fd46071cd86de61058b6ea39fd9affcd87 is used for bloom prefix filter
- The code around issue #105 and issue #108

A list of changes in the FB tree that touch the SQL layer:
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}
h2. How to package
Is it ok to make MyRocks a loadable plugin? FB tree is set to compile it statically.

FB tree also disallows running InnoDB and MyRocks together. I think this capability should be enabled for those doing INSERT ... SELECT migrations

The reason to use MyRocks is compression/performance. Are the default MyRocks/RocksDB settings any good?

h2. Maintenance after inclusion

How does one merge new changes after the initial inclusion?
I suspect most of MyRocks code can be put into MariaDB without modification. Known exceptions
- CMakeLists.txt
- Plugin definition.
- (TODO, anything else? Ask Serg/ Svoj who merge other engines)

MySQL and MariaDB have different group commit implementations. If MySQL+MyRocks implements group commit, will it be difficult to make MariaDB+MyRocks group commit based on that?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 12:53

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* TODO what is missing?

Mark Callaghan added a comment - 2016-10-06 12:53

Does this mean it is coming to 10.2?

Mark Callaghan added a comment - 2016-10-06 12:53 Does this mean it is coming to 10.2?

Sergei Petrunia made changes - 2016-10-06 12:54

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 12:55

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (or RocksDB) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 13:06

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled MTR.
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 13:07

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled MTR.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 14:49

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what is used.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-06 14:50

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what is used.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Petrunia added a comment - 2016-10-06 22:11

mdcallag, yes, that is the plan.

Sergei Petrunia added a comment - 2016-10-06 22:11 mdcallag , yes, that is the plan.

Sergei Petrunia made changes - 2016-10-07 09:02

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Richard Bensley added a comment - 2016-10-07 12:50 - edited

Exciting!

For anyone else that is new to this thread; Callaghan and Co. have some myrocks docs here:
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks,
and some deep-dive-slides from April.

MariaDB and TokuDB DBA's like myself are probably more interested in the hot backup tool!
https://github.com/facebook/mysql-5.6/wiki/Physical-backup-with-myrocks_hotbackup

Will rocks ever become compatible with the Online DDL implementation in MariaDB?

Richard Bensley added a comment - 2016-10-07 12:50 - edited Exciting! For anyone else that is new to this thread; Callaghan and Co. have some myrocks docs here: https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks , and some deep-dive-slides from April. MariaDB and TokuDB DBA's like myself are probably more interested in the hot backup tool! https://github.com/facebook/mysql-5.6/wiki/Physical-backup-with-myrocks_hotbackup Will rocks ever become compatible with the Online DDL implementation in MariaDB?

Sergei Petrunia made changes - 2016-10-07 14:09

Link

This issue includes MDEV-10975 [ MDEV-10975 ]

Sergei Petrunia made changes - 2016-10-07 14:10

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

* MDEV-10975: Merging of @@rocksdb_skip_unique_check

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Petrunia made changes - 2016-10-07 14:33

Link

This issue includes MDEV-10976 [ MDEV-10976 ]

Sergei Petrunia made changes - 2016-10-07 14:33

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

* MDEV-10975: Merging of @@rocksdb_skip_unique_check

h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

* MDEV-10975: Merging of @@rocksdb_skip_unique_check
* MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks
h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Golubchik made changes - 2016-10-09 09:25

Description

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
{noformat}
65501b5 Disable unique checks when replica is lagging
dd7eeae Issue#250: MyRocks/Innodb different output from query with order ...
f0a2ded Per database uuid
9b439ee Add option to exclude tables from gap lock check
5bcb50c Per database uuid
e9ef099 Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
5a82f20 Add gcc function attributes to MyRocks code with a sprinkle of assertions
6078c85 Preventing to write "Got error 122.." to err log on Gap Lock errors
782cc5a Optionally block/log queries relying on Gap Locks
c2dbe68 Add lock information to lock timeout error message
c1f1f0b Issue #108: Index-only scans do not work for partitioned tables and extended keys
3c0802f Improve singled thread replication performance
55622f1 Issue #75: Prefix bloom filter is not used for LinkBench style range scan
ee00797 Compile rocksdb library with mysql compiler settings
8098b78 Add support for reporting keys/deletes skipped in the extra slow query log
bcd7646 Supporting START TRANSACTION WITH CONSISTENT [ROCKSDB] SNAPSHOT
ff91c80 Crash safe slave and master in RocksDB
{noformat}

* also check if da1d92fd46071cd86de61058b6ea39fd9affcd87 (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from here:
https://github.com/facebook/mysql-5.6/commit/bc4145e76dc34f576e3e468ca9d0fee35fe388d5

* MDEV-10975: Merging of @@rocksdb_skip_unique_check
* MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks
h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

This is the umbrella task for including MyRocks Storage Engine from https://github.com/facebook/mysql-5.6 ("FB tree") into MariaDB.

h2. Inclusion itself

See ~~MDEV-10965~~: Add MyRocks into MariaDB repository

h2. Packaging

See ~~MDEV-10966~~ - Packaging for MariaRocks

h2. Required changes at the SQL layer

A list of changes in the FB tree that touch the SQL layer (based on {{git log}} output):
[65501b5|https://github.com/facebook/mysql-5.6/commit/65501b5] Disable unique checks when replica is lagging
[dd7eeae|https://github.com/facebook/mysql-5.6/commit/dd7eeae] Issue#250: MyRocks/Innodb different output from query with order ...
[f0a2ded|https://github.com/facebook/mysql-5.6/commit/f0a2ded] Per database uuid
[9b439ee|https://github.com/facebook/mysql-5.6/commit/9b439ee] Add option to exclude tables from gap lock check
[5bcb50c|https://github.com/facebook/mysql-5.6/commit/5bcb50c] Per database uuid
[e9ef099|https://github.com/facebook/mysql-5.6/commit/e9ef099] Improve code style for classes RDBSE_TABLE_DEF and RDBSE_KEYDEF
[5a82f20|https://github.com/facebook/mysql-5.6/commit/5a82f20] Add gcc function attributes to MyRocks code with a sprinkle of assertions
[6078c85|https://github.com/facebook/mysql-5.6/commit/6078c85] Preventing to write "Got error 122.." to err log on Gap Lock errors
[782cc5a|https://github.com/facebook/mysql-5.6/commit/782cc5a] Optionally block/log queries relying on Gap Locks
[c2dbe68|https://github.com/facebook/mysql-5.6/commit/c2dbe68] Add lock information to lock timeout error message
[c1f1f0b|https://github.com/facebook/mysql-5.6/commit/c1f1f0b] Issue #108: Index-only scans do not work for partitioned tables and extended keys
[3c0802f|https://github.com/facebook/mysql-5.6/commit/3c0802f] Improve singled thread replication performance
[55622f1|https://github.com/facebook/mysql-5.6/commit/55622f1] Issue #75: Prefix bloom filter is not used for LinkBench style range scan
[ee00797|https://github.com/facebook/mysql-5.6/commit/ee00797] Compile rocksdb library with mysql compiler settings
[8098b78|https://github.com/facebook/mysql-5.6/commit/8098b78] Add support for reporting keys/deletes skipped in the extra slow query log
[bcd7646|https://github.com/facebook/mysql-5.6/commit/bcd7646] Supporting START TRANSACTION WITH CONSISTENT \[ROCKSDB] SNAPSHOT
[ff91c80|https://github.com/facebook/mysql-5.6/commit/ff91c80] Crash safe slave and master in RocksDB

* also check if [da1d92fd|https://github.com/facebook/mysql-5.6/commit/da1d92fd] (set_end_range) is ported from mysql-5.6 because MyRocks' bloom prefix filter uses that.
* MariaDB has just got NO_PAD collations: ~~MDEV-9711~~. MyRocks actually had NO_PAD behaviour for PAD collations, and this was a bug
https://github.com/facebook/mysql-5.6/issues/257. MyRocks will have to provide PAD/NO_PAD behaviour, accordingly to what charset is used.

* rdb_perf_context.cc uses my_io_perf_sum_atomic_helper() the function is not in MySQL or MariaDB, it comes from [bc4145e7|https://github.com/facebook/mysql-5.6/commit/bc4145e7]

* MDEV-10975: Merging of @@rocksdb_skip_unique_check
* MDEV-10976: Port MyRocks' Read Free Replication to MariaRocks
h2. Group Commit with Binlog (and Optimistic Parallel Replication).

MyRocks (actually, RocksDB and MyRocks together) need support for high-priority transactions to get MariaDB's optimistic Parallel Replication to work.

h2. Other issues
* mysql-test-run should not require any additional parameters when running MyRocks tests.
* packaging for {{myrocks_hotbackup}}
* Do we include MyRocks' RQG tests? It has some MTR tests which actually just run the bundled RQG with a special grammar.
* TODO what is missing?

Sergei Golubchik added a comment - 2016-10-09 09:30

Not all these required server changes might be needed for MariaDB. For example (I just picked one commit at random) per-database uuids were obviously created for MySQL GTID implementation, and might be not needed for MariaDB GTID implementation.

Sergei Golubchik added a comment - 2016-10-09 09:30 Not all these required server changes might be needed for MariaDB. For example (I just picked one commit at random) per-database uuids were obviously created for MySQL GTID implementation, and might be not needed for MariaDB GTID implementation.

Kristian Nielsen added a comment - 2016-10-10 08:48

Mail thread about support for optimistic parallel replication:

https://lists.launchpad.net/maria-developers/msg09989.html

Kristian Nielsen added a comment - 2016-10-10 08:48 Mail thread about support for optimistic parallel replication: https://lists.launchpad.net/maria-developers/msg09989.html

Rasmus Johansson (Inactive) made changes - 2016-10-13 06:32

Sprint

10.2.3-2 [ 105 ]

Rasmus Johansson (Inactive) made changes - 2016-10-13 06:32

Rank

Ranked lower

Sergei Petrunia made changes - 2016-10-24 12:54

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Sergei Petrunia made changes - 2016-10-24 12:55

Link

This issue includes ~~MDEV-11124~~ [ ~~MDEV-11124~~ ]

Sergei Petrunia added a comment - 2016-10-25 14:48

Status update:

the code in 10.2-mariarocks tree now compiles.
a LOT of things related to replication and synchronization with binlog are still disabled (under #ifdef MARIAROCKS_NOT_YET) and are not expected to work yet.
There are rocksdb MTR testcases that pass, but most testcases fail still

Sergei Petrunia added a comment - 2016-10-25 14:48 Status update: the code in 10.2-mariarocks tree now compiles. a LOT of things related to replication and synchronization with binlog are still disabled (under #ifdef MARIAROCKS_NOT_YET) and are not expected to work yet. There are rocksdb MTR testcases that pass, but most testcases fail still

Sergei Petrunia added a comment - 2016-10-25 16:48

With the 'rocksdb' test suite I currently get:

Completed: Failed 134/200 tests, 33.00% were successful.

Sergei Petrunia added a comment - 2016-10-25 16:48 With the 'rocksdb' test suite I currently get: Completed: Failed 134/200 tests, 33.00% were successful.

Mark Callaghan added a comment - 2016-10-25 16:54

What is the magic to compile it? Using ubuntu 16.04

cmake was:
prefix=$1
cmake \
-DBUILD_CONFIG=mysql_release \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DCMAKE_INSTALL_PREFIX:PATH=$prefix \
-DWITH_ZLIB="bundled" \
-DMYSQL_DATADIR="${prefix}/data" \
-DMYSQL_UNIX_ADDR="${prefix}/var/mysql.sock" \
-DMYSQL_USER="mysql" \
-DENABLED_LOCAL_INFILE=1 \
-DMYSQL_MAINTAINER_MODE=1 \
.
Error is:
./mariadb/mysys/charset.c: In function ‘get_charsets_dir’:
./mariadb/mysys/charset.c:509:22: error: ‘DEFAULT_CHARSET_HOME’ undeclared (first use in this function)
is_prefix(sharedir, DEFAULT_CHARSET_HOME))

Mark Callaghan added a comment - 2016-10-25 16:54 What is the magic to compile it? Using ubuntu 16.04 cmake was: prefix=$1 cmake \ -DBUILD_CONFIG=mysql_release \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_INSTALL_PREFIX:PATH=$prefix \ -DWITH_ZLIB="bundled" \ -DMYSQL_DATADIR="${prefix}/data" \ -DMYSQL_UNIX_ADDR="${prefix}/var/mysql.sock" \ -DMYSQL_USER="mysql" \ -DENABLED_LOCAL_INFILE=1 \ -DMYSQL_MAINTAINER_MODE=1 \ . Error is: ./mariadb/mysys/charset.c: In function ‘get_charsets_dir’: ./mariadb/mysys/charset.c:509:22: error: ‘DEFAULT_CHARSET_HOME’ undeclared (first use in this function) is_prefix(sharedir, DEFAULT_CHARSET_HOME))

Sergei Petrunia added a comment - 2016-10-25 20:24 - edited

mdcallag, I wanted to note again that most of replication/binlog-related features are still disabled and do not work yet. Judging from the number of test failures, a number of other things are broken as well.

Having said that, here are the steps I just used on Ubuntu 16.04.1 to build:

sudo apt-get update

sudo apt-get install g++ cmake libbz2-dev libaio-dev bison zlib1g-dev libsnappy-dev

sudo apt-get install libgflags-dev libreadline6-dev libncurses5-dev libssl-dev liblz4-dev gdb git

git clone https://github.com/MariaDB/server.git mariadb-10.2

cd  mariadb-10.2

git checkout 10.2-mariarocks

git submodule init

git submodule update

cmake . -DCMAKE_BUILD_TYPE=Debug -DWITHOUT_MROONGA:bool=1 -DWITHOUT_TOKUDB:bool=1

make -j16

(-DWITHOUT_TOKUDB and -DWITHOUT_MROONGA are just to make the build faster)
A test that works:

cd mysql-test

./mysql-test-run --mysqld=--default-storage-engine=rocksdb --mysqld=--skip-innodb --mysqld=--default-tmp-storage-engine=MyISAM --mysqld=--rocksdb rocksdb.type_binary

Also tried with -DCMAKE_BUILD_TYPE=RelWithDebInfo and it worked (I mean compilation finished and a few tests ran).

Sergei Petrunia added a comment - 2016-10-25 20:24 - edited mdcallag , I wanted to note again that most of replication/binlog-related features are still disabled and do not work yet. Judging from the number of test failures, a number of other things are broken as well. Having said that, here are the steps I just used on Ubuntu 16.04.1 to build: sudo apt-get update sudo apt-get install g++ cmake libbz2-dev libaio-dev bison zlib1g-dev libsnappy-dev sudo apt-get install libgflags-dev libreadline6-dev libncurses5-dev libssl-dev liblz4-dev gdb git git clone https://github.com/MariaDB/server.git mariadb-10.2 cd mariadb-10.2 git checkout 10.2-mariarocks git submodule init git submodule update cmake . -DCMAKE_BUILD_TYPE=Debug -DWITHOUT_MROONGA:bool=1 -DWITHOUT_TOKUDB:bool=1 make -j16 (-DWITHOUT_TOKUDB and -DWITHOUT_MROONGA are just to make the build faster) A test that works: cd mysql-test ./mysql-test-run --mysqld=--default-storage-engine=rocksdb --mysqld=--skip-innodb --mysqld=--default-tmp-storage-engine=MyISAM --mysqld=--rocksdb rocksdb.type_binary Also tried with -DCMAKE_BUILD_TYPE=RelWithDebInfo and it worked (I mean compilation finished and a few tests ran).

Mark Callaghan added a comment - 2016-10-26 00:31 - edited

Still trying the release build on ubuntu 16.04. Must be more dependencies. I get this failure:

cd /home/mdcallag/git/mariadb/client && /usr/bin/cmake -E cmake_link_script CMakeFiles/mysqltest.dir/link.txt --verbose=1

/usr/bin/c++    -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -O3 -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -D_FORTIFY_SOURCE=2 -DDBUG_OFF  -Wl,--export-dynamic CMakeFiles/mysqltest.dir/mysqltest.cc.o  -o mysqltest  -lpthread ../libmariadb/libmariadb/libmariadbclient.a ../mysys/libmysys.a ../pcre/libpcre.a ../pcre/libpcreposix.a -lpthread -lc -lgnutls ../dbug/libdbug.a ../mysys_ssl/libmysys_ssl.a ../mysys/libmysys.a ../dbug/libdbug.a ../mysys_ssl/libmysys_ssl.a ../zlib/libzlib.a -ldl -lm ../strings/libstrings.a ../extra/yassl/libyassl.a ../extra/yassl/taocrypt/libtaocrypt.a ../pcre/libpcre.a -lpthread

/usr/bin/ld: ../mysys/libmysys.a(stacktrace.c.o): undefined reference to symbol '__bss_start'

//usr/lib/x86_64-linux-gnu/libgmp.so.10: error adding symbols: DSO missing from command line

collect2: error: ld returned 1 exit status

client/CMakeFiles/mysqltest.dir/build.make:110: recipe for target 'client/mysqltest' failed

Mark Callaghan added a comment - 2016-10-26 00:31 - edited Still trying the release build on ubuntu 16.04. Must be more dependencies. I get this failure: cd /home/mdcallag/git/mariadb/client && /usr/bin/cmake -E cmake_link_script CMakeFiles/mysqltest.dir/link.txt --verbose=1 /usr/bin/c++ -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -O3 -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wl,--export-dynamic CMakeFiles/mysqltest.dir/mysqltest.cc.o -o mysqltest -lpthread ../libmariadb/libmariadb/libmariadbclient.a ../mysys/libmysys.a ../pcre/libpcre.a ../pcre/libpcreposix.a -lpthread -lc -lgnutls ../dbug/libdbug.a ../mysys_ssl/libmysys_ssl.a ../mysys/libmysys.a ../dbug/libdbug.a ../mysys_ssl/libmysys_ssl.a ../zlib/libzlib.a -ldl -lm ../strings/libstrings.a ../extra/yassl/libyassl.a ../extra/yassl/taocrypt/libtaocrypt.a ../pcre/libpcre.a -lpthread /usr/bin/ld: ../mysys/libmysys.a(stacktrace.c.o): undefined reference to symbol '__bss_start' //usr/lib/x86_64-linux-gnu/libgmp.so.10: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status client/CMakeFiles/mysqltest.dir/build.make:110: recipe for target 'client/mysqltest' failed

Sergei Petrunia added a comment - 2016-10-29 12:24

There is a number of similar test failures in

type_varchar
type_fixed_indexes
type_enum
type_date_time_indexes

etc. They all look like this failure in rocksdb.type_varchar:

  create table t (id int primary key, email varchar(100), KEY email_i (email(30)));

  insert into t values (1, 'abcabcabcabcabcabcabcabcabcabcabc  ');

  explain select 'email_i' as index_name, count(*) AS count from t force index(email_i);

  id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra

-  1	SIMPLE	t	index	NULL	email_i	33	NULL	#	Using index

+  1	SIMPLE	t	ALL	NULL	NULL	NULL	NULL	#

Debugging it, I can see that in MariaDB:

(gdb) p table->field[0]->part_of_key

  $67 = {map = 1}

while in MySQL

(gdb) p table->field[0]->part_of_key

  $20 = {map = 3}

and the cause of that is this commit in MariaDB: b6b5f9fabe4866a8753e81e1f80593b645f35d8e

In particular the chunk of code in table.cc that starts with:

/*

          Do not extend the key that contains a component

          defined over the beginning of a field.

*/

I'll need to check with Igor what was the exact reason for this logic. MyRocks relies ALL keys having PK extension. (there is already one exception: SQL layer doesn't generate extensions for unique secondary indexes. MyRocks has code to produce index extension for its internal data structures).

Sergei Petrunia added a comment - 2016-10-29 12:24 There is a number of similar test failures in type_varchar type_fixed_indexes type_enum type_date_time_indexes etc. They all look like this failure in rocksdb.type_varchar: create table t (id int primary key, email varchar(100), KEY email_i (email(30))); insert into t values (1, 'abcabcabcabcabcabcabcabcabcabcabc '); explain select 'email_i' as index_name, count(*) AS count from t force index(email_i); id select_type table type possible_keys key key_len ref rows Extra - 1 SIMPLE t index NULL email_i 33 NULL # Using index + 1 SIMPLE t ALL NULL NULL NULL NULL # Debugging it, I can see that in MariaDB: (gdb) p table->field[0]->part_of_key $67 = {map = 1} while in MySQL (gdb) p table->field[0]->part_of_key $20 = {map = 3} and the cause of that is this commit in MariaDB: b6b5f9fabe4866a8753e81e1f80593b645f35d8e In particular the chunk of code in table.cc that starts with: /* Do not extend the key that contains a component defined over the beginning of a field. */ I'll need to check with Igor what was the exact reason for this logic. MyRocks relies ALL keys having PK extension. (there is already one exception: SQL layer doesn't generate extensions for unique secondary indexes. MyRocks has code to produce index extension for its internal data structures).

Sergei Petrunia added a comment - 2016-10-29 13:19

rocksdb.type_char_indexes fails like this:

 rocksdb.type_char_indexes

--- /home/psergey/dev-git/10.2-mariarocks/storage/rocksdb/mysql-test/rocksdb/r/type_char_indexes.result 2016-10-06 17:30:25.595958776 +0000

+++ /home/psergey/dev-git/10.2-mariarocks/storage/rocksdb/mysql-test/rocksdb/r/type_char_indexes.reject 2016-10-29 13:16:57.672889620 +0000

@@ -45,7 +45,7 @@

 INSERT INTO t1 (c,c20,v16,v128,pk) VALUES ('a','char1','varchar1a','varchar1b','1'),('a','char2','varchar2a','varchar2b','2'),('b','char3','varchar1a','varchar1b','3'),('c','char4','varchar3a','varchar3b','4');

 EXPLAIN SELECT SUBSTRING(v16,0,3) FROM t1 WHERE v16 LIKE 'varchar%';

 id     select_type     table   type    possible_keys   key     key_len ref     rows    Extra

-1      SIMPLE  t1      index   v16     v16     19      NULL    #       Using where; Using index

+1      SIMPLE  t1      index   v16     v16     21      NULL    #       Using where; Using index

 SELECT SUBSTRING(v16,7,3) FROM t1 WHERE v16 LIKE 'varchar%';

 SUBSTRING(v16,7,3)

r1a

.
The reason - it's a bug in MariaDB, ~~MDEV-11172~~. It has no visible harm effects, so I'll just update the .result file.

Sergei Petrunia added a comment - 2016-10-29 13:19 rocksdb.type_char_indexes fails like this: rocksdb.type_char_indexes --- /home/psergey/dev-git/10.2-mariarocks/storage/rocksdb/mysql-test/rocksdb/r/type_char_indexes.result 2016-10-06 17:30:25.595958776 +0000 +++ /home/psergey/dev-git/10.2-mariarocks/storage/rocksdb/mysql-test/rocksdb/r/type_char_indexes.reject 2016-10-29 13:16:57.672889620 +0000 @@ -45,7 +45,7 @@ INSERT INTO t1 (c,c20,v16,v128,pk) VALUES ('a','char1','varchar1a','varchar1b','1'),('a','char2','varchar2a','varchar2b','2'),('b','char3','varchar1a','varchar1b','3'),('c','char4','varchar3a','varchar3b','4'); EXPLAIN SELECT SUBSTRING(v16,0,3) FROM t1 WHERE v16 LIKE 'varchar%'; id select_type table type possible_keys key key_len ref rows Extra -1 SIMPLE t1 index v16 v16 19 NULL # Using where; Using index +1 SIMPLE t1 index v16 v16 21 NULL # Using where; Using index SELECT SUBSTRING(v16,7,3) FROM t1 WHERE v16 LIKE 'varchar%'; SUBSTRING(v16,7,3) r1a . The reason - it's a bug in MariaDB, MDEV-11172 . It has no visible harm effects, so I'll just update the .result file.

Sergei Petrunia made changes - 2016-10-29 13:26

Link

This issue relates to ~~MDEV-11172~~ [ ~~MDEV-11172~~ ]

Sergei Petrunia made changes - 2016-10-31 16:26

Link

This issue includes ~~MDEV-11194~~ [ ~~MDEV-11194~~ ]

Sergei Petrunia added a comment - 2016-10-31 16:28

rocksdb.rocksdb_range test failure and similar ones - see ~~MDEV-11194~~

Sergei Petrunia added a comment - 2016-10-31 16:28 rocksdb.rocksdb_range test failure and similar ones - see MDEV-11194

Sergei Petrunia added a comment - 2016-11-07 08:15

Got more tests to work, currently an attempt to run rocksdb test suite gives:

Completed: Failed 85/200 tests, 57.50% were successful.

Sergei Petrunia added a comment - 2016-11-07 08:15 Got more tests to work, currently an attempt to run rocksdb test suite gives: Completed: Failed 85/200 tests, 57.50% were successful.

Sergei Petrunia made changes - 2016-11-20 12:36

Link

This issue includes ~~MDEV-11318~~ [ ~~MDEV-11318~~ ]

Sergei Petrunia made changes - 2016-11-20 22:19

Link

This issue includes ~~MDEV-11320~~ [ ~~MDEV-11320~~ ]

Sergei Petrunia made changes - 2016-11-21 00:05

Link

This issue includes ~~MDEV-11321~~ [ ~~MDEV-11321~~ ]

Sergei Petrunia made changes - 2016-11-21 18:17

Link

This issue includes ~~MDEV-11329~~ [ ~~MDEV-11329~~ ]

Sergei Petrunia added a comment - 2016-11-22 14:21 - edited

Current status with tests is:

Completed: Failed 65/199 tests, 67.34% were successful.

Sergei Petrunia added a comment - 2016-11-22 14:21 - edited Current status with tests is: Completed: Failed 65/199 tests, 67.34% were successful.

Sergei Petrunia made changes - 2016-11-22 15:34

Component/s

Storage Engine - RocksDB [ 13901 ]

Rasmus Johansson (Inactive) made changes - 2016-11-24 12:06

Sprint

10.2.3-2 [ 105 ]

10.2.3-2, 10.2.4-4 [ 105, 117 ]

Rasmus Johansson (Inactive) made changes - 2016-11-24 12:06

Rank

Ranked lower

Sergei Petrunia made changes - 2016-12-02 13:41

Link

This issue includes ~~MDEV-11462~~ [ ~~MDEV-11462~~ ]

Sergei Petrunia made changes - 2016-12-02 20:35

Link

This issue includes ~~MDEV-11477~~ [ ~~MDEV-11477~~ ]

Sergei Petrunia made changes - 2016-12-03 20:34

Link

This issue includes MDEV-11480 [ MDEV-11480 ]

Sergei Petrunia made changes - 2016-12-03 20:54

Link

This issue includes MDEV-11481 [ MDEV-11481 ]

Sergei Petrunia added a comment - 2016-12-06 18:21

Current status with tests is:

Completed: Failed 39/194 tests, 79.90% were successful.

which gives a speed of 26 tests/10 work days

Sergei Petrunia added a comment - 2016-12-06 18:21 Current status with tests is: Completed: Failed 39/194 tests, 79.90% were successful. which gives a speed of 26 tests/10 work days

Rasmus Johansson (Inactive) made changes - 2016-12-08 11:49

Sprint

10.2.3-2, 10.2.4-4 [ 105, 117 ]

10.2.3-2, 10.2.4-4, 10.2.4-1 [ 105, 117, 121 ]

Rasmus Johansson (Inactive) made changes - 2016-12-08 11:49

Rank

Ranked lower

Rasmus Johansson (Inactive) made changes - 2016-12-14 20:45

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-1 [ 105, 117, 121 ]

10.2.3-2, 10.2.4-4, 5.5.54 [ 105, 117, 123 ]

Rasmus Johansson (Inactive) made changes - 2016-12-14 20:45

Rank

Ranked higher

Sergei Petrunia added a comment - 2016-12-20 18:43

Current status is

Completed: Failed 25/184 tests, 86.41% were successful.

Sergei Petrunia added a comment - 2016-12-20 18:43 Current status is Completed: Failed 25/184 tests, 86.41% were successful.

Rasmus Johansson (Inactive) made changes - 2016-12-21 11:50

Sprint

10.2.3-2, 10.2.4-4, 5.5.54 [ 105, 117, 123 ]

10.2.3-2, 10.2.4-4, 10.2.4-5 [ 105, 117, 125 ]

Rasmus Johansson (Inactive) made changes - 2016-12-21 11:50

Rank

Ranked lower

Sergei Petrunia added a comment - 2017-01-01 23:36

Merged in the current MyRocks code.

This caused more tests to fail. Fixed some of these, but still have:

Completed: Failed 38/199 tests, 80.90% were successful.

Sergei Petrunia added a comment - 2017-01-01 23:36 Merged in the current MyRocks code. This caused more tests to fail. Fixed some of these, but still have: Completed: Failed 38/199 tests, 80.90% were successful.

Sergei Petrunia added a comment - 2017-01-02 20:32

Got the number of failures back down to

Completed: Failed 24/197 tests, 87.82% were successful.

Sergei Petrunia added a comment - 2017-01-02 20:32 Got the number of failures back down to Completed: Failed 24/197 tests, 87.82% were successful.

Sergei Petrunia added a comment - 2017-01-03 15:04

Merged with the current MariaDB-10.2. After test result update, now have:

Completed: Failed 23/197 tests, 88.32% were successful.

Sergei Petrunia added a comment - 2017-01-03 15:04 Merged with the current MariaDB-10.2. After test result update, now have: Completed: Failed 23/197 tests, 88.32% were successful.

Sergei Petrunia made changes - 2017-01-06 20:29

Link

This issue includes ~~MDEV-11735~~ [ ~~MDEV-11735~~ ]

Sergei Petrunia added a comment - 2017-01-10 10:27

Fixed or disabled a few more tests. Current status:

Completed: Failed 17/195 tests, 91.28% were successful.

Sergei Petrunia added a comment - 2017-01-10 10:27 Fixed or disabled a few more tests. Current status: Completed: Failed 17/195 tests, 91.28% were successful.

Rasmus Johansson (Inactive) made changes - 2017-01-11 08:13

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5 [ 105, 117, 125 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.1.21 [ 105, 117, 125, 130 ]

Rasmus Johansson (Inactive) made changes - 2017-01-11 08:13

Rank

Ranked higher

Sergei Petrunia added a comment - 2017-01-17 18:34

From now on, will also run rocksdb_sys_vars test suite.

Current status is:

Completed: Failed 18/295 tests, 93.90% were successful.

Of 18 failing tests

17 failing are from rocksdb
1 test is from rocksdb_sys_vars

The tree is now in the buildbot:
https://github.com/MariaDB/server/commits/bb-10.2-mariarocks

A few builders: kvm-deb-trusty-amd64, work-amd64-valgrind build and run it.

Sergei Petrunia added a comment - 2017-01-17 18:34 From now on, will also run rocksdb_sys_vars test suite. Current status is: Completed: Failed 18/295 tests, 93.90% were successful. Of 18 failing tests 17 failing are from rocksdb 1 test is from rocksdb_sys_vars The tree is now in the buildbot: https://github.com/MariaDB/server/commits/bb-10.2-mariarocks A few builders: kvm-deb-trusty-amd64, work-amd64-valgrind build and run it.

Rasmus Johansson (Inactive) made changes - 2017-01-18 10:04

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.1.21 [ 105, 117, 125, 130 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1 [ 105, 117, 125, 132 ]

Rasmus Johansson (Inactive) made changes - 2017-01-18 10:04

Rank

Ranked lower

Sergei Petrunia added a comment - 2017-01-19 13:32

Differences wrt stock MariaDB on the SQL layer: https://gist.github.com/spetrunia/e5d9fb8e94292ae7a7bc623a9c078111

Sergei Petrunia added a comment - 2017-01-19 13:32 Differences wrt stock MariaDB on the SQL layer: https://gist.github.com/spetrunia/e5d9fb8e94292ae7a7bc623a9c078111

Sergei Petrunia made changes - 2017-01-24 14:36

Link

This issue includes ~~MDEV-11901~~ [ ~~MDEV-11901~~ ]

Elena Stepanova made changes - 2017-01-24 16:51

Labels

10.2-ga

Elena Stepanova added a comment - 2017-01-24 16:51

Setting to 10.2-ga because of the server changes. The plugin itself can come later, if necessary.

Elena Stepanova added a comment - 2017-01-24 16:51 Setting to 10.2-ga because of the server changes. The plugin itself can come later, if necessary.

Rasmus Johansson (Inactive) made changes - 2017-01-26 10:37

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1 [ 105, 117, 125, 132 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2 [ 105, 117, 125, 132, 134 ]

Sergei Petrunia added a comment - 2017-01-27 21:01

Reduced the amount of changes wrt stock MariaDB outside of storage/rocksdb directory. The new diff: https://gist.github.com/spetrunia/c7665515f9c5e714dd8869701fdabcc0 .
serg, Please take a look.

Sergei Petrunia added a comment - 2017-01-27 21:01 Reduced the amount of changes wrt stock MariaDB outside of storage/rocksdb directory. The new diff: https://gist.github.com/spetrunia/c7665515f9c5e714dd8869701fdabcc0 . serg , Please take a look.

Sergei Petrunia made changes - 2017-01-29 17:02

Link

This issue includes ~~MDEV-11934~~ [ ~~MDEV-11934~~ ]

Sergei Petrunia made changes - 2017-01-30 21:25

Link

This issue includes ~~MDEV-11946~~ [ ~~MDEV-11946~~ ]

Sergei Petrunia made changes - 2017-03-07 07:50

Link

This issue includes ~~MDEV-12189~~ [ ~~MDEV-12189~~ ]

Sergei Petrunia made changes - 2017-03-07 08:24

Link

This issue includes ~~MDEV-12196~~ [ ~~MDEV-12196~~ ]

Rasmus Johansson (Inactive) made changes - 2017-03-08 11:10

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2 [ 105, 117, 125, 132, 134 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1 [ 105, 117, 125, 132, 134, 144 ]

Rasmus Johansson (Inactive) made changes - 2017-03-08 11:10

Rank

Ranked higher

Sergei Petrunia made changes - 2017-03-13 20:03

Link

This issue includes ~~MDEV-12249~~ [ ~~MDEV-12249~~ ]

Sergei Petrunia made changes - 2017-03-14 09:53

Link

This issue includes ~~MDEV-12254~~ [ ~~MDEV-12254~~ ]

Sergei Petrunia added a comment - 2017-03-14 20:21

Attempt to classify the new test failures after last merge:

Timeout

rocksdb.drop_table3 rocksdb.cardinality rocksdb.statistics rocksdb.truncate_table3 rocksdb.records_in_range rocksdb.rocksdb_checksums rocksdb.bloomfilter4 rocksdb.singledelete rocksdb.bloomfilter_skip rocksdb.drop_table rocksdb.optimize_table rocksdb.rocksdb_dead rocksdb.bloomfilter rocksdb.bloomfilter2 rocksdb.blind_delete rocksdb.deadlock rocksdb.drop_table2 rocksdb.commit_in_the_middle_ddl rocksdb.rocksdb_dead rocksdb.rocksdb_tabl w4 [ fail ] timeout after 900 seconds
w3 [ fail ] timeout after 900 seconds
w1 [ fail ] timeout after 900 seconds
w4 [ fail ] timeout after 900 seconds
w1 [ fail ] timeout after 900 seconds
w3 [ fail ] timeout after 900 seconds
w4 [ fail ] timeout after 900 seconds
w2 [ fail ] timeout after 900 seconds
w1 [ fail ] timeout after 900 seconds
w3 [ fail ] timeout after 900 seconds
w4 [ fail ] timeout after 900 seconds
lock_stress_rc w2 [ fail ] timeout after 900 seconds
w1 [ fail ] timeout after 900 seconds
w3 [ fail ] timeout after 900 seconds
_without_tx_api 'row' w2 [ fail ] timeout after 900 seconds
w4 [ fail ] timeout after 900 seconds
w2 [ fail ] timeout after 900 seconds
w1 [ fail ] timeout after 900 seconds
lock_stress_rr w3 [ fail ] timeout after 900 seconds
e_stats_sampling_pct_change w2 [ fail ] timeout after 900 seconds

after rocksdb_deadlock_stress_rr on one machine and rocksdb_deadlock_stress_rc
on another, there are always loads of

2017-03-13 22:19:10 140500730528512 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction

2017-03-13 22:19:10 140500731134720 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction

2017-03-13 22:19:10 140500730831616 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction

errors in the log

Deadlock

rocksdb.unique_sec w2 [ fail ] Found warnings/errors in server log file!
rocksdb.rocksdb_locks w4 [ fail ] Found warnings/errors in server log file!
rocksdb.unique_sec_rev_cf w4 [ fail ] Found warnings/errors in server log file!
rocksdb.issue111 w4 [ fail ] Found warnings/errors in server log file!
rocksdb.rocksdb_deadlock_detect_rr w3 [ fail ] Found warnings/errors in server log file!
rocksdb.hermitage w1 [ fail ] Found warnings/errors in server log file!
rocksdb.level_repeatable_read w4 [ fail ] Found warnings/errors in server log file!

2017-03-14  0:19:17 139935554990848 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction

Crash in the client

rocksdb.rocksdb_range w3 [ fail ]
rocksdb.misc w3 [ fail ]

Crash in the client?

Different failures affecting single tests

rocksdb.rocksdb w3 [ fail ] Found warnings/errors in server log file!

"Sort aborted" after DELETE.

rocksdb.collation w2 [ fail ]

Crash in sysvar update.

rocksdb.show_engine w2 [ fail ]

SHOW ENGINE rocksdB TRANSACTION STATUS

rocksdb.blind_delete_without_tx_api 'mix' w2 [ fail ]
rocksdb.blind_delete_without_tx_api 'stmt' w4 [ fail ]
mysqltest: At line 23: query '$insert' failed: 1105: Can't execute updates on master with binlog_format != ROW.

Misc failures

rocksdb.rpl_row_not_found 'row' w4 [ fail ]

2017-03-14  0:20:26 140674317531008 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: Error while setting value 'SEMI_STRICT' to 'slave_exec_mode'

rocksdb.rpl_row_stats 'row' w4 [ fail ]
(result file difference)

rocksdb.rpl_row_triggers 'row' w4 [ fail ]
rocksdb.rpl_savepoint 'row' w4 [ fail ]

rocksdb.trx_info_rpl 'row' w4 [ fail ]

2017-03-14  0:21:04 140149053159296 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: unknown variable 'rpl_skip_tx_api=ON'

rocksdb.rocksdb_datadir w3 [ fail ]

2017-03-14  0:55:24 140347962312576 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: unknown variable 'rocksdb_datadir=/home/psergey/dev-git/10.2-mariarocks/mysql-test/var/tmp/3/.rocksdb_datadir.test'

rocksdb.tbl_opt_data_index_dir w1 [ fail ]

mysqltest: At line 14: query 'CREATE TABLE t1 (a INT PRIMARY KEY, b CHAR(8)) ENGINE=rocksdb DATA DIRECTORY = '/foo/bar/data'' failed with wrong errno 1005: 'Can't create table `test`.`t1` (errno: 198 "Unknown error 198")', instead of 1296...

Sergei Petrunia added a comment - 2017-03-14 20:21 Attempt to classify the new test failures after last merge: Timeout rocksdb.drop_table3 w4 [ fail ] timeout after 900 seconds rocksdb.cardinality w3 [ fail ] timeout after 900 seconds rocksdb.statistics w1 [ fail ] timeout after 900 seconds rocksdb.truncate_table3 w4 [ fail ] timeout after 900 seconds rocksdb.records_in_range w1 [ fail ] timeout after 900 seconds rocksdb.rocksdb_checksums w3 [ fail ] timeout after 900 seconds rocksdb.bloomfilter4 w4 [ fail ] timeout after 900 seconds rocksdb.singledelete w2 [ fail ] timeout after 900 seconds rocksdb.bloomfilter_skip w1 [ fail ] timeout after 900 seconds rocksdb.drop_table w3 [ fail ] timeout after 900 seconds rocksdb.optimize_table w4 [ fail ] timeout after 900 seconds rocksdb.rocksdb_deadlock_stress_rc w2 [ fail ] timeout after 900 seconds rocksdb.bloomfilter w1 [ fail ] timeout after 900 seconds rocksdb.bloomfilter2 w3 [ fail ] timeout after 900 seconds rocksdb.blind_delete_without_tx_api 'row' w2 [ fail ] timeout after 900 seconds rocksdb.deadlock w4 [ fail ] timeout after 900 seconds rocksdb.drop_table2 w2 [ fail ] timeout after 900 seconds rocksdb.commit_in_the_middle_ddl w1 [ fail ] timeout after 900 seconds rocksdb.rocksdb_deadlock_stress_rr w3 [ fail ] timeout after 900 seconds rocksdb.rocksdb_table_stats_sampling_pct_change w2 [ fail ] timeout after 900 seconds after rocksdb_deadlock_stress_rr on one machine and rocksdb_deadlock_stress_rc on another, there are always loads of 2017-03-13 22:19:10 140500730528512 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction 2017-03-13 22:19:10 140500731134720 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction 2017-03-13 22:19:10 140500730831616 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction errors in the log Deadlock rocksdb.unique_sec w2 [ fail ] Found warnings/errors in server log file! rocksdb.rocksdb_locks w4 [ fail ] Found warnings/errors in server log file! rocksdb.unique_sec_rev_cf w4 [ fail ] Found warnings/errors in server log file! rocksdb.issue111 w4 [ fail ] Found warnings/errors in server log file! rocksdb.rocksdb_deadlock_detect_rr w3 [ fail ] Found warnings/errors in server log file! rocksdb.hermitage w1 [ fail ] Found warnings/errors in server log file! rocksdb.level_repeatable_read w4 [ fail ] Found warnings/errors in server log file! 2017-03-14 0:19:17 139935554990848 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction Crash in the client rocksdb.rocksdb_range w3 [ fail ] rocksdb.misc w3 [ fail ] Crash in the client? Different failures affecting single tests rocksdb.rocksdb w3 [ fail ] Found warnings/errors in server log file! "Sort aborted" after DELETE. rocksdb.collation w2 [ fail ] Crash in sysvar update. rocksdb.show_engine w2 [ fail ] SHOW ENGINE rocksdB TRANSACTION STATUS rocksdb.blind_delete_without_tx_api 'mix' w2 [ fail ] rocksdb.blind_delete_without_tx_api 'stmt' w4 [ fail ] mysqltest: At line 23: query '$insert' failed: 1105: Can't execute updates on master with binlog_format != ROW. Misc failures rocksdb.rpl_row_not_found 'row' w4 [ fail ] 2017-03-14 0:20:26 140674317531008 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: Error while setting value 'SEMI_STRICT' to 'slave_exec_mode' rocksdb.rpl_row_stats 'row' w4 [ fail ] (result file difference) rocksdb.rpl_row_triggers 'row' w4 [ fail ] rocksdb.rpl_savepoint 'row' w4 [ fail ] rocksdb.trx_info_rpl 'row' w4 [ fail ] 2017-03-14 0:21:04 140149053159296 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: unknown variable 'rpl_skip_tx_api=ON' rocksdb.rocksdb_datadir w3 [ fail ] 2017-03-14 0:55:24 140347962312576 [ERROR] /home/psergey/dev-git/10.2-mariarocks/sql/mysqld: unknown variable 'rocksdb_datadir=/home/psergey/dev-git/10.2-mariarocks/mysql-test/var/tmp/3/.rocksdb_datadir.test' rocksdb.tbl_opt_data_index_dir w1 [ fail ] mysqltest: At line 14: query 'CREATE TABLE t1 (a INT PRIMARY KEY, b CHAR(8)) ENGINE=rocksdb DATA DIRECTORY = '/foo/bar/data'' failed with wrong errno 1005: 'Can't create table `test`.`t1` (errno: 198 "Unknown error 198")', instead of 1296...

Sergei Petrunia added a comment - 2017-03-14 20:27

error logs themselves:

an aws instance https://gist.github.com/spetrunia/7bf36db2bf0ed4fbb8045ecd34a21358
psergey-desktop: https://gist.github.com/spetrunia/0babf9e3a9f7b11487bb0ad78d641f9c

Sergei Petrunia added a comment - 2017-03-14 20:27 error logs themselves: an aws instance https://gist.github.com/spetrunia/7bf36db2bf0ed4fbb8045ecd34a21358 psergey-desktop: https://gist.github.com/spetrunia/0babf9e3a9f7b11487bb0ad78d641f9c

Rasmus Johansson (Inactive) made changes - 2017-03-15 10:27

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1 [ 105, 117, 125, 132, 134, 144 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-1 [ 105, 117, 125, 132, 134, 144, 146 ]

Rasmus Johansson (Inactive) made changes - 2017-03-15 10:27

Rank

Ranked lower

Sergei Petrunia added a comment - 2017-03-15 20:28

A lot of timeouts go away if I set @@rocksdb_flush_logs_at_trx_commit to 0 for the rocksdb test suite:

https://gist.github.com/spetrunia/d61bf3f92ca248cd57a3e87504daece0
https://gist.github.com/spetrunia/19eed7367eeb05b3500d062ca7e0e49e

Sergei Petrunia added a comment - 2017-03-15 20:28 A lot of timeouts go away if I set @@rocksdb_flush_logs_at_trx_commit to 0 for the rocksdb test suite: https://gist.github.com/spetrunia/d61bf3f92ca248cd57a3e87504daece0 https://gist.github.com/spetrunia/19eed7367eeb05b3500d062ca7e0e49e

Sergei Petrunia made changes - 2017-03-15 22:18

Link

This issue includes ~~MDEV-12277~~ [ ~~MDEV-12277~~ ]

Sergei Petrunia added a comment - 2017-03-16 08:27

Current status : we are down to 14 test failures, of which 7 are "something with deadlock detector" and another 7 are individual issues.

MTR log: https://gist.github.com/spetrunia/e58537b1efa5094f62ecf5b7b6f60573

Something with deadlock detector

rocksdb.rocksdb_locks
rocksdb.rocksdb_deadlock_stress_rc
rocksdb.unique_sec
rocksdb.unique_sec_rev_cf
rocksdb.locking_issues
rocksdb.rocksdb_deadlock_detect_rr
rocksdb.rocksdb_deadlock_stress_rr

Loads of errors in the log like this

2017-03-16  7:04:48 140240146146048 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction

Isolated failures

rocksdb.misc
Dumb .result difference

rocksdb.collation

mysqltest: At line 188: query 'SET GLOBAL rocksdb_strict_collation_exceptions=null' failed: 2013: Lost connection to MySQL server during query

rocksdb.tbl_opt_data_index_dir

  query 'CREATE TABLE t1 (a INT PRIMARY KEY, b CHAR(8)) ENGINE=rocksdb DATA DIRECTORY = '/foo/bar/data'' failed with wrong errno

rocksdb.rpl_row_stats
Counter increment difference

rocksdb.rpl_savepoint

  query 'rollback to savepoint a' succeeded - should have failed with errno 1105...

rocksdb.blind_delete_without_tx_api

wait timeout, not always repeatable

rocksdb.rocksdb_datadir

/home/ubuntu/mariadb-10.2-dbg/sql/mysqld: unknown variable 'rocksdb_datadir=/home/ubuntu/mariadb-10.2-dbg/mysql-test/var/tmp/2/.rocksdb_datadir.test

Sergei Petrunia added a comment - 2017-03-16 08:27 Current status : we are down to 14 test failures, of which 7 are "something with deadlock detector" and another 7 are individual issues. MTR log: https://gist.github.com/spetrunia/e58537b1efa5094f62ecf5b7b6f60573 Something with deadlock detector rocksdb.rocksdb_locks rocksdb.rocksdb_deadlock_stress_rc rocksdb.unique_sec rocksdb.unique_sec_rev_cf rocksdb.locking_issues rocksdb.rocksdb_deadlock_detect_rr rocksdb.rocksdb_deadlock_stress_rr Loads of errors in the log like this 2017-03-16 7:04:48 140240146146048 [ERROR] mysqld: Deadlock found when trying to get lock; try restarting transaction Isolated failures rocksdb.misc Dumb .result difference rocksdb.collation mysqltest: At line 188: query 'SET GLOBAL rocksdb_strict_collation_exceptions=null' failed: 2013: Lost connection to MySQL server during query rocksdb.tbl_opt_data_index_dir query 'CREATE TABLE t1 (a INT PRIMARY KEY, b CHAR(8)) ENGINE=rocksdb DATA DIRECTORY = '/foo/bar/data'' failed with wrong errno rocksdb.rpl_row_stats Counter increment difference rocksdb.rpl_savepoint query 'rollback to savepoint a' succeeded - should have failed with errno 1105... rocksdb.blind_delete_without_tx_api wait timeout, not always repeatable rocksdb.rocksdb_datadir /home/ubuntu/mariadb-10.2-dbg/sql/mysqld: unknown variable 'rocksdb_datadir=/home/ubuntu/mariadb-10.2-dbg/mysql-test/var/tmp/2/.rocksdb_datadir.test

Sergei Petrunia made changes - 2017-03-16 09:12

Link

This issue includes ~~MDEV-12279~~ [ ~~MDEV-12279~~ ]

Sergei Petrunia made changes - 2017-03-16 09:17

Link

This issue includes ~~MDEV-12280~~ [ ~~MDEV-12280~~ ]

Sergei Petrunia made changes - 2017-03-16 17:54

Link

This issue includes ~~MDEV-12285~~ [ ~~MDEV-12285~~ ]

Sergei Petrunia added a comment - 2017-03-16 18:47 - edited

Down to 7 4 test failures on the AWS instance: https://gist.github.com/spetrunia/8349449919264626a1f93dfb34be18a6

rocksdb.collation
~~rocksdb.misc~~
~~rocksdb.rocksdb_datadir~~
rocksdb.tbl_opt_data_index_dir
~~rocksdb.rpl_row_stats~~
~~rocksdb.rpl_savepoint~~
~~rocksdb.blind_delete_without_tx_api~~
These are the "Isolated failures" mentioned above.

On psergey-desktop, debug build, I get 10 failures: https://gist.github.com/spetrunia/d658ea3d195d420156feb8560a4d7b92 . Same as above plus three more.

Sergei Petrunia added a comment - 2017-03-16 18:47 - edited Down to 7 4 test failures on the AWS instance: https://gist.github.com/spetrunia/8349449919264626a1f93dfb34be18a6 rocksdb.collation rocksdb.misc rocksdb.rocksdb_datadir rocksdb.tbl_opt_data_index_dir rocksdb.rpl_row_stats rocksdb.rpl_savepoint rocksdb.blind_delete_without_tx_api These are the "Isolated failures" mentioned above. On psergey-desktop, debug build, I get 10 failures: https://gist.github.com/spetrunia/d658ea3d195d420156feb8560a4d7b92 . Same as above plus three more.

Sergei Petrunia added a comment - 2017-03-16 22:24 - edited

Latest status: 4 3 test failures (6 in debug build):
https://gist.github.com/spetrunia/82a89d4bd35d1402145cef5ca11f1eda
https://gist.github.com/spetrunia/b19425d2bfd280fc29ee95151c9f2478

Sergei Petrunia added a comment - 2017-03-16 22:24 - edited Latest status: 4 3 test failures (6 in debug build): https://gist.github.com/spetrunia/82a89d4bd35d1402145cef5ca11f1eda https://gist.github.com/spetrunia/b19425d2bfd280fc29ee95151c9f2478

Sergei Petrunia made changes - 2017-03-17 01:31

Link

This issue includes MDEV-12286 [ MDEV-12286 ]

Sergei Petrunia added a comment - 2017-03-17 10:43 - edited

Latest status:
https://gist.github.com/spetrunia/ed35780f02121b5ee381c76fc6e765a3
https://gist.github.com/spetrunia/d3d7f715761026265f6d51ae8c65e188

3 2 1 in release build: rocksdb.rocksdb ~~rocksdb.collation~~ ~~rocksdb.tbl_opt_data_index_dir~~
5 4 2 in debug build: rocksdb.rocksdb ~~rocksdb.collation~~ ~~rocksdb.tbl_opt_data_index_dir~~ rocksdb.persistent_cache (<- this is an upstream issue, see MDEV-1234) rocksdb.unique_check

There is a new failure - rocksdb.rocksdb. It is not easily reproducible. It doesn't look very bad - it might be a race condition in the test.

Sergei Petrunia added a comment - 2017-03-17 10:43 - edited Latest status: https://gist.github.com/spetrunia/ed35780f02121b5ee381c76fc6e765a3 https://gist.github.com/spetrunia/d3d7f715761026265f6d51ae8c65e188 3 2 1 in release build: rocksdb.rocksdb rocksdb.collation rocksdb.tbl_opt_data_index_dir 5 4 2 in debug build: rocksdb.rocksdb rocksdb.collation rocksdb.tbl_opt_data_index_dir rocksdb.persistent_cache (<- this is an upstream issue, see MDEV-1234) rocksdb.unique_check There is a new failure - rocksdb.rocksdb. It is not easily reproducible. It doesn't look very bad - it might be a race condition in the test.

Sergei Petrunia made changes - 2017-03-21 09:30

Link

This issue includes ~~MDEV-12316~~ [ ~~MDEV-12316~~ ]

Rasmus Johansson (Inactive) made changes - 2017-03-22 09:50

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-1 [ 105, 117, 125, 132, 134, 144, 146 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2 [ 105, 117, 125, 132, 134, 144, 148 ]

Rasmus Johansson (Inactive) made changes - 2017-03-22 09:50

Rank

Ranked lower

Sergei Petrunia added a comment - 2017-03-22 17:57

Current status:
(debug) https://gist.github.com/spetrunia/e9e08238479816c6c2e8bca9e4ec404e

Sergei Petrunia added a comment - 2017-03-22 17:57 Current status: (debug) https://gist.github.com/spetrunia/e9e08238479816c6c2e8bca9e4ec404e

Sergei Petrunia made changes - 2017-03-23 09:03

Link

This issue includes MDEV-12341 [ MDEV-12341 ]

Sergei Petrunia made changes - 2017-03-28 10:51

Link

This issue includes MDEV-12380 [ MDEV-12380 ]

Rasmus Johansson (Inactive) made changes - 2017-03-29 10:55

Sprint

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2 [ 105, 117, 125, 132, 134, 144, 148 ]

10.2.3-2, 10.2.4-4, 10.2.4-5, 10.2.4-1, 10.2.4-2, 10.2.5-1, 10.2.6-2, 10.2.6-3 [ 105, 117, 125, 132, 134, 144, 148, 150 ]

Sergei Petrunia made changes - 2017-04-02 07:58

Link

This issue includes ~~MDEV-12424~~ [ ~~MDEV-12424~~ ]

Sergei Petrunia made changes - 2017-04-02 10:59

Link

This issue includes ~~MDEV-12425~~ [ ~~MDEV-12425~~ ]

Sergei Petrunia made changes - 2017-04-03 07:27

Link

This issue includes MDEV-12431 [ MDEV-12431 ]

Sergei Petrunia made changes - 2017-04-03 09:53

Link

This issue includes MDEV-12433 [ MDEV-12433 ]

Sergei Petrunia made changes - 2017-04-04 08:19

Link

This issue includes ~~MDEV-12439~~ [ ~~MDEV-12439~~ ]

Sergei Petrunia made changes - 2017-04-04 15:02

Link

This issue includes ~~MDEV-12427~~ [ ~~MDEV-12427~~ ]

Sergei Petrunia made changes - 2017-04-05 05:44

Link

This issue includes MDEV-12445 [ MDEV-12445 ]

Sergei Petrunia made changes - 2017-04-19 13:40

Link

This issue includes ~~MDEV-12528~~ [ ~~MDEV-12528~~ ]

Sergei Petrunia made changes - 2017-05-02 13:53

Link

This issue includes ~~MDEV-12663~~ [ ~~MDEV-12663~~ ]

Oren Bissick (Inactive) added a comment - 2017-05-24 16:36

Will Galera be supported?

Oren Bissick (Inactive) added a comment - 2017-05-24 16:36 Will Galera be supported?

Sergei Petrunia added a comment - 2017-06-05 07:21

obissick, currently there are no plans for Galera support. Galera integrates tightly with the storage engine, and at the moment the only engine it has integration with is InnoDB/XtraDB.

Sergei Petrunia added a comment - 2017-06-05 07:21 obissick , currently there are no plans for Galera support. Galera integrates tightly with the storage engine, and at the moment the only engine it has integration with is InnoDB/XtraDB.

Sergei Petrunia added a comment - 2017-10-18 07:22

Current status is:

Upstream is merged up to

    commit 184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c

    Author: Abhinav Sharma <abhinavsharma@fb.com>

    Date:   Thu Sep 14 11:40:08 2017 -0700

Most of the features are in the 10.2 tree
The candidate code for "Group Commit with Binlog" (~~MDEV-11934~~) feature is in bb-10.2-mariarocks tree.

Sergei Petrunia added a comment - 2017-10-18 07:22 Current status is: Upstream is merged up to commit 184a4a2d82f4f6f3cbcb1015bcdb32bebe73315c Author: Abhinav Sharma <abhinavsharma@fb.com> Date: Thu Sep 14 11:40:08 2017 -0700 Most of the features are in the 10.2 tree The candidate code for "Group Commit with Binlog" ( MDEV-11934 ) feature is in bb-10.2-mariarocks tree.

Sergei Petrunia made changes - 2017-10-19 14:05

Summary

Add MyRocks to MariaDB

Make MyRocks in MariaDB stable

Sergei Petrunia made changes - 2017-10-22 14:46

Link

This issue includes ~~MDEV-14103~~ [ ~~MDEV-14103~~ ]

Sergei Petrunia added a comment - 2017-10-22 14:47

Filed ~~MDEV-14103~~, it is on elenst's plate now.

Sergei Petrunia added a comment - 2017-10-22 14:47 Filed MDEV-14103 , it is on elenst 's plate now.

Elena Stepanova added a comment - 2017-10-22 20:56

psergey,
The previous comment is ambiguous, could you please specify what exactly is on my plate – ~~MDEV-14103~~ or "making MyRocks in MariaDB stable"?
I acknowledge receiving of ~~MDEV-14103~~ (Testing for group commit in MyRocks), but it cannot possibly be the only obstacle between the current state and declaring MyRocks stable.
We have 7 open buildbot bugs for RocksDB which need to be closed before declaring MyRocks stable, and quite a few other open bugs/tasks, priority of which needs to be revised, because it was initially set based on the fact that MyRocks was alpha/beta.

Elena Stepanova added a comment - 2017-10-22 20:56 psergey , The previous comment is ambiguous, could you please specify what exactly is on my plate – MDEV-14103 or "making MyRocks in MariaDB stable"? I acknowledge receiving of MDEV-14103 (Testing for group commit in MyRocks), but it cannot possibly be the only obstacle between the current state and declaring MyRocks stable. We have 7 open buildbot bugs for RocksDB which need to be closed before declaring MyRocks stable, and quite a few other open bugs/tasks, priority of which needs to be revised, because it was initially set based on the fact that MyRocks was alpha/beta.

Sergei Petrunia added a comment - 2017-10-23 09:50

elenst, it is only ~~MDEV-14103~~ that is on your plate. Sorry for the confusion.

Sergei Petrunia added a comment - 2017-10-23 09:50 elenst , it is only MDEV-14103 that is on your plate. Sorry for the confusion.

Sergei Petrunia made changes - 2017-10-23 10:32

Link

This issue relates to MDEV-14106 [ MDEV-14106 ]

Sergei Petrunia made changes - 2017-10-23 16:50

Link

This issue relates to MDEV-14109 [ MDEV-14109 ]

Sergei Petrunia made changes - 2017-10-28 07:36

Link

This issue includes ~~MDEV-14181~~ [ ~~MDEV-14181~~ ]

Sergei Petrunia made changes - 2017-11-10 15:47

Link

This issue relates to MDEV-14351 [ MDEV-14351 ]

Sergei Petrunia made changes - 2017-11-13 03:54

Link

This issue relates to MDEV-14372 [ MDEV-14372 ]

Sergei Petrunia made changes - 2018-01-08 14:17

Link

This issue includes MDEV-14892 [ MDEV-14892 ]

Sergei Petrunia made changes - 2018-05-08 13:26

Fix Version/s

10.3 [ 22126 ]

Sergei Petrunia made changes - 2018-05-08 13:26

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Petrunia made changes - 2018-06-20 08:02

Fix Version/s		10.2.16 [ 23110 ]
Fix Version/s		10.3.7 [ 23005 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:23

Workflow

MariaDB v3 [ 74409 ]

MariaDB v4 [ 132801 ]

MariaDB Server

Make MyRocks in MariaDB stable

Details

Description

Inclusion itself

Packaging

Required changes at the SQL layer

Group Commit with Binlog (and Optimistic Parallel Replication).

Other issues

Attachments

Issue Links

Activity

Timeout

Deadlock

Crash in the client

Different failures affecting single tests

Misc failures

Something with deadlock detector

Isolated failures

People

Dates

Git Integration