Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31606

Refactor check_db_name() to get a const argument

Details

    Description

      This task was originally a part of MDEV-31531, but now is a separate task, because it'll be quite a big change itself.

      check_db_name() converts the argument to lower case if lower_case_table_name>0.
      It uses my_casedn_str(), which converts the data to lower case in-place. As far as in-place conversion won't be possible after we switch to Unicode-14 casefolding rules (because conversion to lower case can increase the string length in Unicode-14), we need to refactor all uses of check_db_name() not to use in-place casefolding conversion.

      The current implementation of:

      bool check_db_name(LEX_STRING *db);

      should be changed to get a constant argument:

      bool check_db_name(const LEX_CSTRING &db);

      All old-style check_db_name() use cases should be changed in the way that in case of lower_case_table_names>1 the following sequence is done:

      • Convert an existing database name to a new database name in lower case into a NEW memory location.
      • Call the NEW version of check_db_name() on the NEW memory location.

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27490 Allow full utf8mb4 for identifiers

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          is blocked by

          Task - A task that needs to be done. MDEV-31948 Add class DBNameBuffer, split check_db_name() into stages

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31950 Cleanup: Move MEM_ROOT allocation methods from THD to Query_arena

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31954 Cleanup in check_table_name() and check_db_name()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31972 Change parameter of make_sp_name*() from LEX_CSTRING to Lex_ident_sys_st

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31974 Remove global function normalize_db_name()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31978 Turn ok_for_lower_case_names() to a method in Lex_ident_fs

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31982 Remove old check_db_name() from prepare_db_action()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31986 Remove old check_db_name() from make_table_name_list()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31989 Cleanup Lex_ident_fs::check_body()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31991 Split class Database_qualified_name

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31992 Automatic conversion from LEX_STRING to LEX_CSTRING

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32002 Remove my_casedn_str() in append_identifier() context

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32013 Add Field::val_lex_string_strmake()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32019 Replace my_casedn_str(local_buffer) to CharBuffer::copy_casedn()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32026 lowercase_table2.test failures in 11.3

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-32081 Remove my_casedn_str() from get_canonical_filename()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Alexander Barkov made transition -
            Open In Progress
            		1d 20h 52m 1
            Alexander Barkov made transition -
            In Progress In Review
            		33s 1
            Dmitry Shulga made transition -
            In Review Stalled
            		64d 22h 22m 1
            Alexander Barkov made transition -
            Stalled In Testing
            		4d 23h 53m 1
            Ramesh Sivaraman made transition -
            In Testing Stalled
            		27d 3h 4m 1
            Alexander Barkov made transition -
            Stalled Closed
            		6d 20h 47m 1

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.