Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31531

Remove my_casedn_str() and my_caseup_str()

Details

    Description

      We use my_casedn_str() to convert identifiers to cover case.
      This function uses the fact that utf8mb3_bin and utf8mb3_general_ci (used for identifiers internally) cannot increase string length, so it performs conversion in place.

      Under terms of MDEV-27490 we'll add support for non-BMP identifiers and upgrade casefolding information to Unicode version 14.0.0.

      In Unicode-14.0.0 conversion to lower case can increase binary length, so conversion cannot be done in place.

      Let's remove all use of my_casedn_str() and replace them to calls for a similar function CHARSET_INFO::casedn(), which has separate pointers to the source and the destination.

      For symmetry, let's also remove my_caseup_str() calls and replace them to calls for CHARSET_INFO::caseup().

      Attachments

        Issue Links

          Activity

            Hello, julien.fritsch. I hope it should not take more than one week.

            bar Alexander Barkov added a comment - Hello, julien.fritsch . I hope it should not take more than one week.
            bar Alexander Barkov added a comment - Hello serg , Please review this patch: https://github.com/MariaDB/server/commit/2821cf816a4e99821bfe58f318d697967e79dc41 Thanks.

            Hello serg,

            Please review a new patch version here:

            https://github.com/MariaDB/server/commit/ae0320daef76c7c00f1c7dddd2920afed4344a90

            I replied review comments by email.

            Thanks.

            bar Alexander Barkov added a comment - Hello serg , Please review a new patch version here: https://github.com/MariaDB/server/commit/ae0320daef76c7c00f1c7dddd2920afed4344a90 I replied review comments by email. Thanks.

            Hello serg,

            Please review a new patch version here:

            https://github.com/MariaDB/server/commit/d2de9a89d801cbced9701479e564644340a64fca

            See aslo my reply by email

            Thanks.

            bar Alexander Barkov added a comment - Hello serg , Please review a new patch version here: https://github.com/MariaDB/server/commit/d2de9a89d801cbced9701479e564644340a64fca See aslo my reply by email Thanks.

            d2de9a89d80 is ok to push after taking into account comments from the email review

            serg Sergei Golubchik added a comment - d2de9a89d80 is ok to push after taking into account comments from the email review

            bar Testing looks good.

            ramesh Ramesh Sivaraman added a comment - bar Testing looks good.

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.