Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31531

Remove my_casedn_str() and my_caseup_str()

    XMLWordPrintable

Details

    Description

      We use my_casedn_str() to convert identifiers to cover case.
      This function uses the fact that utf8mb3_bin and utf8mb3_general_ci (used for identifiers internally) cannot increase string length, so it performs conversion in place.

      Under terms of MDEV-27490 we'll add support for non-BMP identifiers and upgrade casefolding information to Unicode version 14.0.0.

      In Unicode-14.0.0 conversion to lower case can increase binary length, so conversion cannot be done in place.

      Let's remove all use of my_casedn_str() and replace them to calls for a similar function CHARSET_INFO::casedn(), which has separate pointers to the source and the destination.

      For symmetry, let's also remove my_caseup_str() calls and replace them to calls for CHARSET_INFO::caseup().

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27490 Allow full utf8mb4 for identifiers

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33223 Assertion `dst_size > 4' failed in size_t Identifier_chain2::make_sep_name_opt_casedn(char*, size_t, int, bool) const

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33733 Galera tests fail with wrong result due to a wrong case in status variables

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-31948 Add class DBNameBuffer, split check_db_name() into stages

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31972 Change parameter of make_sp_name*() from LEX_CSTRING to Lex_ident_sys_st

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31974 Remove global function normalize_db_name()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31978 Turn ok_for_lower_case_names() to a method in Lex_ident_fs

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31982 Remove old check_db_name() from prepare_db_action()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31986 Remove old check_db_name() from make_table_name_list()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31989 Cleanup Lex_ident_fs::check_body()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31991 Split class Database_qualified_name

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-31992 Automatic conversion from LEX_STRING to LEX_CSTRING

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32002 Remove my_casedn_str() in append_identifier() context

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32013 Add Field::val_lex_string_strmake()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-32019 Replace my_casedn_str(local_buffer) to CharBuffer::copy_casedn()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32025 Crashes in MDL_key::mdl_key_init with lower-case-table-names=2

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32026 lowercase_table2.test failures in 11.3

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-32081 Remove my_casedn_str() from get_canonical_filename()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-31340 Remove MY_COLLATION_HANDLER::strcasecmp()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32071 Bad case letter in *.ibd files with --lower-case-table-names=2

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33019 The database part is not case sensitive in SP names

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33020 The database part is not case sensitive in SP names in PERFORMANCE_SCHEMA

          • Major - Major loss of function.
          • Open

          Activity

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.