Type:
Task
Priority:
Major
Resolution:
Fixed
Let's add automatic conversion operator from LEX_STRING to LEX_CSTRING.
struct st_mysql_lex_string
{
char *str;
size_t length;
#ifdef __cplusplus
// Allow automatic cast from LEX_STRING to LEX_CSTRING in c++.
operator struct st_mysql_const_lex_string() const
{
return {str, length};
}
#endif
This will help to remove some duplicate functions/methods accepting LEX_CSTRING and LEX_STRING and to avoid adding duplicate functions/methods in the future.
Duplicate methods:
Lex_cstring_with_compare( const LEX_STRING src) :
Lex_cstring(src.str, src.length)
{ }
Lex_cstring_with_compare( const LEX_CSTRING src) : Lex_cstring(src.str, src.length)
{ }
Storage_engine_name( const LEX_CSTRING &name)
:m_storage_engine_name(name)
{ }
Storage_engine_name( const LEX_STRING &name)
{
m_storage_engine_name.str= name.str;
m_storage_engine_name.length= name.length;
}
// Append with optional character set conversion from ASCII (e.g. to UCS2)
bool append( const LEX_STRING *ls)
{
DBUG_ASSERT(ls->length < UINT_MAX32 &&
((ls->length == 0 && !ls->str) ||
ls->length == strlen (ls->str)));
return append(ls->str, (uint32) ls->length);
}
bool append( const LEX_CSTRING *ls)
{
DBUG_ASSERT(ls->length < UINT_MAX32 &&
((ls->length == 0 && !ls->str) ||
ls->length == strlen (ls->str)));
return append(ls->str, (uint32) ls->length);
}
The version with LEX_STRING should be removed.
There are no comments yet on this issue.
{"report":{"fcp":709,"ttfb":231,"pageVisibility":"visible","entityId":124456,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"e5fab3d5-6ea0-4147-a892-1d9befcc02cc","navigationType":0,"readyForUser":788.1000000238419,"redirectCount":0,"resourceLoadedEnd":858,"resourceLoadedStart":236,"resourceTiming":[{"duration":5.800000071525574,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":236,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":236,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":241.80000007152557,"responseStart":0,"secureConnectionStart":0},{"duration":6.199999928474426,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":236.30000007152557,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":236.30000007152557,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":242.5,"responseStart":0,"secureConnectionStart":0},{"duration":63.800000071525574,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":236.5,"connectEnd":236.5,"connectStart":236.5,"domainLookupEnd":236.5,"domainLookupStart":236.5,"fetchStart":236.5,"redirectEnd":0,"redirectStart":0,"requestStart":236.5,"responseEnd":300.3000000715256,"responseStart":300.3000000715256,"secureConnectionStart":236.5},{"duration":169.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":236.5,"connectEnd":236.5,"connectStart":236.5,"domainLookupEnd":236.5,"domainLookupStart":236.5,"fetchStart":236.5,"redirectEnd":0,"redirectStart":0,"requestStart":236.5,"responseEnd":406.2000000476837,"responseStart":406.2000000476837,"secureConnectionStart":236.5},{"duration":173.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":236.70000004768372,"connectEnd":236.70000004768372,"connectStart":236.70000004768372,"domainLookupEnd":236.70000004768372,"domainLookupStart":236.70000004768372,"fetchStart":236.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":236.70000004768372,"responseEnd":410,"responseStart":410,"secureConnectionStart":236.70000004768372},{"duration":173.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":236.80000007152557,"connectEnd":236.80000007152557,"connectStart":236.80000007152557,"domainLookupEnd":236.80000007152557,"domainLookupStart":236.80000007152557,"fetchStart":236.80000007152557,"redirectEnd":0,"redirectStart":0,"requestStart":236.80000007152557,"responseEnd":410.40000009536743,"responseStart":410.40000009536743,"secureConnectionStart":236.80000007152557},{"duration":174.29999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":236.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":236.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":411.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":173.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":236.90000009536743,"connectEnd":236.90000009536743,"connectStart":236.90000009536743,"domainLookupEnd":236.90000009536743,"domainLookupStart":236.90000009536743,"fetchStart":236.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":236.90000009536743,"responseEnd":410.7000000476837,"responseStart":410.7000000476837,"secureConnectionStart":236.90000009536743},{"duration":174.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":237,"connectEnd":237,"connectStart":237,"domainLookupEnd":237,"domainLookupStart":237,"fetchStart":237,"redirectEnd":0,"redirectStart":0,"requestStart":237,"responseEnd":411.2000000476837,"responseStart":411.2000000476837,"secureConnectionStart":237},{"duration":174.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":237.10000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":237.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":411.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":174.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":237.20000004768372,"connectEnd":237.20000004768372,"connectStart":237.20000004768372,"domainLookupEnd":237.20000004768372,"domainLookupStart":237.20000004768372,"fetchStart":237.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":237.20000004768372,"responseEnd":411.7000000476837,"responseStart":411.7000000476837,"secureConnectionStart":237.20000004768372},{"duration":614.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":242.60000002384186,"connectEnd":242.60000002384186,"connectStart":242.60000002384186,"domainLookupEnd":242.60000002384186,"domainLookupStart":242.60000002384186,"fetchStart":242.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":242.60000002384186,"responseEnd":856.8000000715256,"responseStart":856.8000000715256,"secureConnectionStart":242.60000002384186},{"duration":615.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":242.60000002384186,"connectEnd":242.60000002384186,"connectStart":242.60000002384186,"domainLookupEnd":242.60000002384186,"domainLookupStart":242.60000002384186,"fetchStart":242.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":242.60000002384186,"responseEnd":858,"responseStart":858,"secureConnectionStart":242.60000002384186},{"duration":406,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":451.2000000476837,"connectEnd":451.2000000476837,"connectStart":451.2000000476837,"domainLookupEnd":451.2000000476837,"domainLookupStart":451.2000000476837,"fetchStart":451.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":451.2000000476837,"responseEnd":857.2000000476837,"responseStart":857.2000000476837,"secureConnectionStart":451.2000000476837},{"duration":156,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":702.6000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":702.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":858.6000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":79.39999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":862.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":862.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":941.6000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":79,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":863,"connectEnd":863,"connectStart":863,"domainLookupEnd":863,"domainLookupStart":863,"fetchStart":863,"redirectEnd":0,"redirectStart":0,"requestStart":863,"responseEnd":942,"responseStart":942,"secureConnectionStart":863},{"duration":104.69999992847443,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":863.4000000953674,"connectEnd":863.4000000953674,"connectStart":863.4000000953674,"domainLookupEnd":863.4000000953674,"domainLookupStart":863.4000000953674,"fetchStart":863.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":863.4000000953674,"responseEnd":968.1000000238419,"responseStart":968.1000000238419,"secureConnectionStart":863.4000000953674}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":59,"responseStart":231,"responseEnd":235,"domLoading":234,"domInteractive":933,"domContentLoadedEventStart":933,"domContentLoadedEventEnd":973,"domComplete":1087,"loadEventStart":1087,"loadEventEnd":1088,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":917.7000000476837},{"name":"bigPipe.sidebar-id.end","time":918.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":918.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":919.2000000476837},{"name":"activityTabFullyLoaded","time":980.9000000953674}],"measures":[],"correlationId":"5692ebd85b1c23","effectiveType":"4g","downlink":9.6,"rtt":0,"serverDuration":102,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}