[MDEV-31531] Remove my_casedn_str() and my_caseup_str() Created: 2023-06-23 Updated: 2024-01-16 |
|
| Status: | In Testing |
| Project: | MariaDB Server |
| Component/s: | Character Sets |
| Fix Version/s: | 11.5 |
| Type: | Task | Priority: | Critical |
| Reporter: | Alexander Barkov | Assignee: | Ramesh Sivaraman |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
We use my_casedn_str() to convert identifiers to cover case. Under terms of MDEV-27490 we'll add support for non-BMP identifiers and upgrade casefolding information to Unicode version 14.0.0. In Unicode-14.0.0 conversion to lower case can increase binary length, so conversion cannot be done in place. Let's remove all use of my_casedn_str() and replace them to calls for a similar function CHARSET_INFO::casedn(), which has separate pointers to the source and the destination. For symmetry, let's also remove my_caseup_str() calls and replace them to calls for CHARSET_INFO::caseup(). |
| Comments |
| Comment by Alexander Barkov [ 2023-11-20 ] |
|
Hello, julien.fritsch. I hope it should not take more than one week. |
| Comment by Alexander Barkov [ 2023-11-24 ] |
|
Hello serg, Please review this patch: Thanks. |
| Comment by Alexander Barkov [ 2023-12-12 ] |
|
Hello serg, Please review a new patch version here: https://github.com/MariaDB/server/commit/ae0320daef76c7c00f1c7dddd2920afed4344a90 I replied review comments by email. Thanks. |
| Comment by Alexander Barkov [ 2023-12-14 ] |
|
Hello serg, Please review a new patch version here: https://github.com/MariaDB/server/commit/d2de9a89d801cbced9701479e564644340a64fca See aslo my reply by email Thanks. |
| Comment by Sergei Golubchik [ 2023-12-19 ] |
|
d2de9a89d80 is ok to push after taking into account comments from the email review |