Type:
Task
Priority:
Major
Resolution:
Fixed
The code in check_table_name() and check_db_name() looks confusing.
Let's do minor cleanups:
Rename the parameter check_for_path_char to a more self-descriptive disallow_path_chars
Rename the variable name_length in check_table_name() to a more self-descriptive char_length.
Fix the while loop in check_table_name() into a for loop and replace multiple char_length+ (the former name_length + ) statements to a signle increment statement in the for loop header.
blocks
MDEV-31606
Refactor check_db_name() to get a const argument
Closed
There are no comments yet on this issue.
{"report":{"fcp":1074.0999999046326,"ttfb":374.8999996185303,"pageVisibility":"visible","entityId":124338,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"655235fb-6355-470c-9230-7f8e6d738d2a","navigationType":0,"readyForUser":1150.5,"redirectCount":0,"resourceLoadedEnd":924.0999999046326,"resourceLoadedStart":382.59999990463257,"resourceTiming":[{"duration":121.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":382.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":382.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":504,"responseStart":0,"secureConnectionStart":0},{"duration":122.2000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":382.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":382.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":505.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":202.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":383.09999990463257,"connectEnd":383.09999990463257,"connectStart":383.09999990463257,"domainLookupEnd":383.09999990463257,"domainLookupStart":383.09999990463257,"fetchStart":383.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":507.8999996185303,"responseEnd":585.5999999046326,"responseStart":522.8999996185303,"secureConnectionStart":383.09999990463257},{"duration":377.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":383.2999997138977,"connectEnd":383.2999997138977,"connectStart":383.2999997138977,"domainLookupEnd":383.2999997138977,"domainLookupStart":383.2999997138977,"fetchStart":383.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":510.09999990463257,"responseEnd":760.5999999046326,"responseStart":525.2999997138977,"secureConnectionStart":383.2999997138977},{"duration":144.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":383.5,"connectEnd":383.5,"connectStart":383.5,"domainLookupEnd":383.5,"domainLookupStart":383.5,"fetchStart":383.5,"redirectEnd":0,"redirectStart":0,"requestStart":510.59999990463257,"responseEnd":528.0999999046326,"responseStart":526.7999997138977,"secureConnectionStart":383.5},{"duration":147.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":383.59999990463257,"connectEnd":383.59999990463257,"connectStart":383.59999990463257,"domainLookupEnd":383.59999990463257,"domainLookupStart":383.59999990463257,"fetchStart":383.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":511.3999996185303,"responseEnd":531.1999998092651,"responseStart":529.2999997138977,"secureConnectionStart":383.59999990463257},{"duration":150.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":383.7999997138977,"connectEnd":383.7999997138977,"connectStart":383.7999997138977,"domainLookupEnd":383.7999997138977,"domainLookupStart":383.7999997138977,"fetchStart":383.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":513.5999999046326,"responseEnd":534,"responseStart":532.1999998092651,"secureConnectionStart":383.7999997138977},{"duration":128.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":384,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":384,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":512.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":156.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":384.19999980926514,"connectEnd":384.19999980926514,"connectStart":384.19999980926514,"domainLookupEnd":384.19999980926514,"domainLookupStart":384.19999980926514,"fetchStart":384.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":522.0999999046326,"responseEnd":541.0999999046326,"responseStart":539.7999997138977,"secureConnectionStart":384.19999980926514},{"duration":129.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":384.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":384.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":514.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":158.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":384.59999990463257,"connectEnd":384.59999990463257,"connectStart":384.59999990463257,"domainLookupEnd":384.59999990463257,"domainLookupStart":384.59999990463257,"fetchStart":384.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":522.6999998092651,"responseEnd":542.7999997138977,"responseStart":541.2999997138977,"secureConnectionStart":384.59999990463257},{"duration":390.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":404,"connectEnd":404,"connectStart":404,"domainLookupEnd":404,"domainLookupStart":404,"fetchStart":404,"redirectEnd":0,"redirectStart":0,"requestStart":628.2999997138977,"responseEnd":794.2999997138977,"responseStart":786.8999996185303,"secureConnectionStart":404},{"duration":520,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":404.09999990463257,"connectEnd":404.09999990463257,"connectStart":404.09999990463257,"domainLookupEnd":404.09999990463257,"domainLookupStart":404.09999990463257,"fetchStart":404.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":903.3999996185303,"responseEnd":924.0999999046326,"responseStart":923,"secureConnectionStart":404.09999990463257},{"duration":223,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":715.3999996185303,"connectEnd":715.3999996185303,"connectStart":715.3999996185303,"domainLookupEnd":715.3999996185303,"domainLookupStart":715.3999996185303,"fetchStart":715.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":903.5999999046326,"responseEnd":938.3999996185303,"responseStart":937.5999999046326,"secureConnectionStart":715.3999996185303},{"duration":204.10000038146973,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1005.8999996185303,"connectEnd":1005.8999996185303,"connectStart":1005.8999996185303,"domainLookupEnd":1005.8999996185303,"domainLookupStart":1005.8999996185303,"fetchStart":1005.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":1175.6999998092651,"responseEnd":1210,"responseStart":1209,"secureConnectionStart":1005.8999996185303}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":230,"responseStart":375,"responseEnd":403,"domLoading":378,"domInteractive":1258,"domContentLoadedEventStart":1258,"domContentLoadedEventEnd":1303,"domComplete":1719,"loadEventStart":1719,"loadEventEnd":1719,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1221.3999996185303},{"name":"bigPipe.sidebar-id.end","time":1222.2999997138977},{"name":"bigPipe.activity-panel-pipe-id.start","time":1222.3999996185303},{"name":"bigPipe.activity-panel-pipe-id.end","time":1222.8999996185303},{"name":"activityTabFullyLoaded","time":1316.5}],"measures":[],"correlationId":"1d70c45aed708b","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":88,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}