Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29993

myrocks_hotbackup.1 and test suite files installed when engine is disabled

Details

    Description

      With the RocksDB engine disabled the CMake bits do not obey the engine being disabled and still install the myrocks_hotbackup.1 man page and the test suite files for RocksDB.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          brad0 Brad Smith created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Priority Critical [ 2 ] Major [ 3 ]
          serg Sergei Golubchik made changes -
          Assignee Daniel Black [ danblack ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          Fix Version/s 10.8 [ 26121 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          serg Sergei Golubchik made changes -
          Affects Version/s 10.3 [ 22126 ]
          Affects Version/s 10.4 [ 22408 ]
          Affects Version/s 10.5 [ 23123 ]
          Affects Version/s 10.6 [ 24028 ]
          Affects Version/s 10.7 [ 24805 ]
          Affects Version/s 10.8 [ 26121 ]
          Affects Version/s 10.9 [ 26905 ]
          Affects Version/s 10.10 [ 27530 ]
          danblack Daniel Black added a comment -

          Thanks for the bug report Brad.

          It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt

          IF(PLUGIN_ROCKSDB STREQUAL "NO")
          		 
            RETURN()
          		 
          ENDIF()

          Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't.

          See https://github.com/MariaDB/server/pull/2334 for how to disable man pages.

          PRs welcome.

          danblack Daniel Black added a comment - Thanks for the bug report Brad. It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt IF(PLUGIN_ROCKSDB STREQUAL "NO") RETURN() ENDIF() Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't. See https://github.com/MariaDB/server/pull/2334 for how to disable man pages. PRs welcome.
          brad0 Brad Smith added a comment -

          I'll see about a PR after the PR you pointed out goes in.

          brad0 Brad Smith added a comment - I'll see about a PR after the PR you pointed out goes in.
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.7 [ 24805 ]
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.3 [ 22126 ]
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.8 [ 26121 ]
          danblack Daniel Black made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ] Andrew Hutchings [ JIRAUSER52179 ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          danblack Daniel Black added a comment -

          Thanks brad0 finally got to it.

          danblack Daniel Black added a comment - Thanks brad0 finally got to it.
          danblack Daniel Black made changes -
          Fix Version/s 10.4.32 [ 29300 ]
          Fix Version/s 10.5.23 [ 29012 ]
          Fix Version/s 10.6.16 [ 29014 ]
          Fix Version/s 10.10.7 [ 29018 ]
          Fix Version/s 10.11.6 [ 29020 ]
          Fix Version/s 11.0.4 [ 29021 ]
          Fix Version/s 11.1.3 [ 29023 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          Assignee Andrew Hutchings [ JIRAUSER52179 ] Daniel Black [ danblack ]
          Resolution Fixed [ 1 ]
          Status In Review [ 10002 ] Closed [ 6 ]

          People

            danblack Daniel Black
            brad0 Brad Smith
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.