[MDEV-29993] myrocks_hotbackup.1 and test suite files installed when engine is disabled Created: 2022-11-10  Updated: 2023-09-25  Resolved: 2023-09-19

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Affects Version/s: 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3

Type: Bug Priority: Major
Reporter: Brad Smith Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: None


 Description   

With the RocksDB engine disabled the CMake bits do not obey the engine being disabled and still install the myrocks_hotbackup.1 man page and the test suite files for RocksDB.

 Comments   
Comment by Daniel Black [ 2022-11-18 ]

Thanks for the bug report Brad.

It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt

IF(PLUGIN_ROCKSDB STREQUAL "NO")
 
  RETURN()
 
ENDIF()

Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't.

See https://github.com/MariaDB/server/pull/2334 for how to disable man pages.

PRs welcome.

Comment by Brad Smith [ 2022-11-18 ]

I'll see about a PR after the PR you pointed out goes in.

Comment by Daniel Black [ 2023-09-19 ]

Thanks brad0 finally got to it.

Generated at Thu Feb 08 10:12:50 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.