Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29993

myrocks_hotbackup.1 and test suite files installed when engine is disabled

Details

    Description

      With the RocksDB engine disabled the CMake bits do not obey the engine being disabled and still install the myrocks_hotbackup.1 man page and the test suite files for RocksDB.

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          danblack Daniel Black added a comment -

          Thanks brad0 finally got to it.

          danblack Daniel Black added a comment - Thanks brad0 finally got to it.
          brad0 Brad Smith added a comment -

          I'll see about a PR after the PR you pointed out goes in.

          brad0 Brad Smith added a comment - I'll see about a PR after the PR you pointed out goes in.
          danblack Daniel Black added a comment -

          Thanks for the bug report Brad.

          It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt

          IF(PLUGIN_ROCKSDB STREQUAL "NO")
          		 
            RETURN()
          		 
          ENDIF()

          Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't.

          See https://github.com/MariaDB/server/pull/2334 for how to disable man pages.

          PRs welcome.

          danblack Daniel Black added a comment - Thanks for the bug report Brad. It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt IF(PLUGIN_ROCKSDB STREQUAL "NO") RETURN() ENDIF() Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't. See https://github.com/MariaDB/server/pull/2334 for how to disable man pages. PRs welcome.

          People

            danblack Daniel Black
            brad0 Brad Smith
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.