[MDEV-29993] myrocks_hotbackup.1 and test suite files installed when engine is disabled - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL)
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3
Component/s: Storage Engine - RocksDB
Labels:
None

Description

With the RocksDB engine disabled the CMake bits do not obey the engine being disabled and still install the myrocks_hotbackup.1 man page and the test suite files for RocksDB.

Attachments

Activity

Ascending order - Click to sort in descending order

Daniel Black added a comment - 2022-11-18 03:11

Thanks for the bug report Brad.

It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt

IF(PLUGIN_ROCKSDB STREQUAL "NO")

  RETURN()

ENDIF()

Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't.

See https://github.com/MariaDB/server/pull/2334 for how to disable man pages.

PRs welcome.

Daniel Black added a comment - 2022-11-18 03:11 Thanks for the bug report Brad. It looks in need of something like the following towards the top of the storage/rocksdb/CMakeList.txt IF(PLUGIN_ROCKSDB STREQUAL "NO") RETURN() ENDIF() Test suite - INSTALL_MYSQL_TEST in cmake/plugin.cmake looks like its enabled even if the plugin isn't. See https://github.com/MariaDB/server/pull/2334 for how to disable man pages. PRs welcome.

Brad Smith added a comment - 2022-11-18 03:37

I'll see about a PR after the PR you pointed out goes in.

Brad Smith added a comment - 2022-11-18 03:37 I'll see about a PR after the PR you pointed out goes in.

Daniel Black added a comment - 2023-09-19 22:20

Thanks brad0 finally got to it.

Daniel Black added a comment - 2023-09-19 22:20 Thanks brad0 finally got to it.

People

Assignee:: Daniel Black

Reporter:: Brad Smith

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2022-11-10 06:43

Updated:: 2023-09-25 03:20

Resolved:: 2023-09-19 22:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server