Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28097

use-after-free when WHERE has subquery with an outer reference in HAVING

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 10.4, 10.5, 10.6, 10.7, 10.9.0
    • Fix Version/s: 10.4.25, 10.5.16, 10.6.8, 10.7.4
    • Component/s: Optimizer
    • Labels:
      None
    • Environment:
      Linux jie-2 5.4.143-1-pve #1 SMP PVE 5.4.143-1 (Tue, 28 Sep 2021 09:10:37 +0200) x86_64 x86_64 x86_64 GNU/Linux

      Description

      PoC:

      CREATE TEMPORARY TABLE v0 ( v1 TEXT ( 60 ) NOT NULL ) ;
       INSERT INTO v0 ( ) VALUES ( v1 IN ( 127 , -1 = v1 OR -1 , 0 ) ) , ( 0 ) ;
       SELECT DISTINCT * FROM v0 WHERE '' IN ( SELECT + 'x' LIKE v1 HAVING + v1 LIKE v1 ORDER BY v1 + v1 ) ;
      

      report (compiled with ASAN):

      ==9327==ERROR: AddressSanitizer: heap-use-after-free on address 0x6290000c8288 at pc 0x000002b241e8 bp 0x7f3952747de0 sp 0x7f3952747dd8
      READ of size 1 at 0x6290000c8288 thread T17
          #0 0x2b241e7 in my_wildcmp_8bit_impl /root/mariadb/strings/ctype-simple.c:964:12
          #1 0x2b2397a in my_wildcmp_8bit /root/mariadb/strings/ctype-simple.c:1050:10
          #2 0x16eea86 in charset_info_st::wildcmp(char const*, char const*, char const*, char const*, int, int, int) const /root/mariadb/include/m_ctype.h:910:12
          #3 0x16eea86 in Item_func_like::val_int() /root/mariadb/sql/item_cmpfunc.cc:5627:35
          #4 0x1315e0d in Type_handler_int_result::Item_val_bool(Item*) const /root/mariadb/sql/sql_type.cc:5105:16
          #5 0x16ec0f7 in Item_cond_and::val_int() /root/mariadb/sql/item_cmpfunc.cc:5421:16
          #6 0xdc6895 in JOIN::exec_inner() /root/mariadb/sql/sql_select.cc:4610:31
          #7 0xdc344c in JOIN::exec() /root/mariadb/sql/sql_select.cc:4527:3
          #8 0x1952e43 in subselect_single_select_engine::exec() /root/mariadb/sql/item_subselect.cc:4115:11
          #9 0x1928ebb in Item_subselect::exec() /root/mariadb/sql/item_subselect.cc:853:21
          #10 0x1928ebb in Item_in_subselect::exec() /root/mariadb/sql/item_subselect.cc:1035:3
          #11 0x193469a in Item_in_subselect::val_bool() /root/mariadb/sql/item_subselect.cc:1965:7
          #12 0x16bcbca in Item_in_optimizer::val_int() /root/mariadb/sql/item_cmpfunc.cc:1637:17
          #13 0x1675138 in Item_cache_int::cache_value() /root/mariadb/sql/item.cc:10054:19
          #14 0x1666bec in Item_cache_wrapper::cache() /root/mariadb/sql/item.cc:8839:15
          #15 0x1666bec in Item_cache_wrapper::val_int() /root/mariadb/sql/item.cc:8893:3
          #16 0xe30e35 in evaluate_join_record(JOIN*, st_join_table*, int) /root/mariadb/sql/sql_select.cc:21193:25
          #17 0xd4c23d in sub_select(JOIN*, st_join_table*, bool) /root/mariadb/sql/sql_select.cc:21134:9
          #18 0xdc6797 in do_select(JOIN*, Procedure*) /root/mariadb/sql/sql_select.cc:20640:14
          #19 0xdc6797 in JOIN::exec_inner() /root/mariadb/sql/sql_select.cc:4749:50
          #20 0xdc344c in JOIN::exec() /root/mariadb/sql/sql_select.cc:4527:3
          #21 0xd4e4e8 in mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) /root/mariadb/sql/sql_select.cc:5007:9
          #22 0xd4d74b in handle_select(THD*, LEX*, select_result*, unsigned long) /root/mariadb/sql/sql_select.cc:543:10
          #23 0xc74410 in execute_sqlcom_select(THD*, TABLE_LIST*) /root/mariadb/sql/sql_parse.cc:6252:12
          #24 0xc609c9 in mysql_execute_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:3943:12
          #25 0xc4a67e in mysql_parse(THD*, char*, unsigned int, Parser_state*) /root/mariadb/sql/sql_parse.cc:8027:18
          #26 0xc41ba9 in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /root/mariadb/sql/sql_parse.cc:1894:7
          #27 0xc4b74b in do_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:1402:17
          #28 0x111f9f2 in do_handle_one_connection(CONNECT*, bool) /root/mariadb/sql/sql_connect.cc:1418:11
          #29 0x111f248 in handle_one_connection /root/mariadb/sql/sql_connect.cc:1312:5
          #30 0x1f3f9dd in pfs_spawn_thread /root/mariadb/storage/perfschema/pfs.cc:2201:3
          #31 0x7f3978f38608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477:8
          #32 0x7f3978c4e162 in clone /build/glibc-sMfBJT/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
       
      0x6290000c8288 is located 136 bytes inside of 16512-byte region [0x6290000c8200,0x6290000cc280)
      freed by thread T17 here:
          #0 0x80f732 in free (/usr/local/mysql/bin/mariadbd+0x80f732)
          #1 0x243e1b8 in mem_heap_free(mem_block_info_t*) /root/mariadb/storage/innobase/include/mem0mem.inl:419:3
          #2 0x243e1b8 in row_mysql_prebuilt_free_blob_heap(row_prebuilt_t*) /root/mariadb/storage/innobase/row/row0mysql.cc:101:2
          #3 0x24b554c in row_sel_store_mysql_rec(unsigned char*, row_prebuilt_t*, unsigned char const*, dtuple_t const*, bool, dict_index_t const*, unsigned short const*) /root/mariadb/storage/innobase/row/row0sel.cc:3109:3
          #4 0x24afa37 in row_search_mvcc(unsigned char*, page_cur_mode_t, row_prebuilt_t*, unsigned long, unsigned long) /root/mariadb/storage/innobase/row/row0sel.cc:5656:9
          #5 0x217429c in ha_innobase::general_fetch(unsigned char*, unsigned int, unsigned int) /root/mariadb/storage/innobase/handler/ha_innodb.cc:9236:24
          #6 0x15c44c3 in handler::ha_rnd_next(unsigned char*) /root/mariadb/sql/handler.cc:3393:5
          #7 0x930064 in rr_sequential(READ_RECORD*) /root/mariadb/sql/records.cc:519:35
          #8 0xd4c3e1 in READ_RECORD::read_record() /root/mariadb/sql/records.h:81:30
          #9 0xd4c3e1 in sub_select(JOIN*, st_join_table*, bool) /root/mariadb/sql/sql_select.cc:21114:18
          #10 0xdc6797 in do_select(JOIN*, Procedure*) /root/mariadb/sql/sql_select.cc:20640:14
          #11 0xdc6797 in JOIN::exec_inner() /root/mariadb/sql/sql_select.cc:4749:50
          #12 0xdc344c in JOIN::exec() /root/mariadb/sql/sql_select.cc:4527:3
          #13 0xd4e4e8 in mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) /root/mariadb/sql/sql_select.cc:5007:9
          #14 0xd4d74b in handle_select(THD*, LEX*, select_result*, unsigned long) /root/mariadb/sql/sql_select.cc:543:10
          #15 0xc74410 in execute_sqlcom_select(THD*, TABLE_LIST*) /root/mariadb/sql/sql_parse.cc:6252:12
          #16 0xc609c9 in mysql_execute_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:3943:12
          #17 0xc4a67e in mysql_parse(THD*, char*, unsigned int, Parser_state*) /root/mariadb/sql/sql_parse.cc:8027:18
          #18 0xc41ba9 in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /root/mariadb/sql/sql_parse.cc:1894:7
          #19 0xc4b74b in do_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:1402:17
          #20 0x111f9f2 in do_handle_one_connection(CONNECT*, bool) /root/mariadb/sql/sql_connect.cc:1418:11
          #21 0x111f248 in handle_one_connection /root/mariadb/sql/sql_connect.cc:1312:5
          #22 0x1f3f9dd in pfs_spawn_thread /root/mariadb/storage/perfschema/pfs.cc:2201:3
          #23 0x7f3978f38608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477:8
       
      previously allocated by thread T17 here:
          #0 0x80f99d in malloc (/usr/local/mysql/bin/mariadbd+0x80f99d)
          #1 0x215c51e in ut_allocator<unsigned char, true>::allocate(unsigned long, unsigned char const*, unsigned int, bool, bool) /root/mariadb/storage/innobase/include/ut0new.h:375:11
          #2 0x2301754 in mem_heap_create_block_func(mem_block_info_t*, unsigned long, unsigned long) /root/mariadb/storage/innobase/mem/mem0mem.cc:277:37
          #3 0x24be2fc in mem_heap_create_func(unsigned long, unsigned long) /root/mariadb/storage/innobase/include/mem0mem.inl:377:10
          #4 0x24be2fc in row_sel_store_mysql_field(unsigned char*, row_prebuilt_t*, unsigned char const*, dict_index_t const*, unsigned short const*, unsigned long, mysql_row_templ_t const*) /root/mariadb/storage/innobase/row/row0sel.cc:3050:27
          #5 0x24b4ea9 in row_sel_store_mysql_rec(unsigned char*, row_prebuilt_t*, unsigned char const*, dtuple_t const*, bool, dict_index_t const*, unsigned short const*) /root/mariadb/storage/innobase/row/row0sel.cc:3196:8
          #6 0x24afa37 in row_search_mvcc(unsigned char*, page_cur_mode_t, row_prebuilt_t*, unsigned long, unsigned long) /root/mariadb/storage/innobase/row/row0sel.cc:5656:9
          #7 0x21739c3 in ha_innobase::index_read(unsigned char*, unsigned char const*, unsigned int, ha_rkey_function) /root/mariadb/storage/innobase/handler/ha_innodb.cc:8970:5
          #8 0x2174d99 in ha_innobase::index_first(unsigned char*) /root/mariadb/storage/innobase/handler/ha_innodb.cc:9339:14
          #9 0x2174d99 in ha_innobase::rnd_next(unsigned char*) /root/mariadb/storage/innobase/handler/ha_innodb.cc:9432:11
          #10 0x15c44c3 in handler::ha_rnd_next(unsigned char*) /root/mariadb/sql/handler.cc:3393:5
          #11 0x930064 in rr_sequential(READ_RECORD*) /root/mariadb/sql/records.cc:519:35
          #12 0xd4c04d in sub_select(JOIN*, st_join_table*, bool) /root/mariadb/sql/sql_select.cc:21092:12
          #13 0xdc6797 in do_select(JOIN*, Procedure*) /root/mariadb/sql/sql_select.cc:20640:14
          #14 0xdc6797 in JOIN::exec_inner() /root/mariadb/sql/sql_select.cc:4749:50
          #15 0xdc344c in JOIN::exec() /root/mariadb/sql/sql_select.cc:4527:3
          #16 0xd4e4e8 in mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) /root/mariadb/sql/sql_select.cc:5007:9
          #17 0xd4d74b in handle_select(THD*, LEX*, select_result*, unsigned long) /root/mariadb/sql/sql_select.cc:543:10
          #18 0xc74410 in execute_sqlcom_select(THD*, TABLE_LIST*) /root/mariadb/sql/sql_parse.cc:6252:12
          #19 0xc609c9 in mysql_execute_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:3943:12
          #20 0xc4a67e in mysql_parse(THD*, char*, unsigned int, Parser_state*) /root/mariadb/sql/sql_parse.cc:8027:18
          #21 0xc41ba9 in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /root/mariadb/sql/sql_parse.cc:1894:7
          #22 0xc4b74b in do_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:1402:17
          #23 0x111f9f2 in do_handle_one_connection(CONNECT*, bool) /root/mariadb/sql/sql_connect.cc:1418:11
          #24 0x111f248 in handle_one_connection /root/mariadb/sql/sql_connect.cc:1312:5
          #25 0x1f3f9dd in pfs_spawn_thread /root/mariadb/storage/perfschema/pfs.cc:2201:3
          #26 0x7f3978f38608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477:8
       
      Thread T17 created by T0 here:
          #0 0x7f9cfc in pthread_create (/usr/local/mysql/bin/mariadbd+0x7f9cfc)
          #1 0x1f3fd39 in my_thread_create(unsigned long*, pthread_attr_t const*, void* (*)(void*), void*) /root/mariadb/storage/perfschema/my_thread.h:52:10
          #2 0x1f3fd39 in pfs_spawn_thread_v1 /root/mariadb/storage/perfschema/pfs.cc:2252:15
          #3 0x85cef4 in inline_mysql_thread_create(unsigned int, unsigned long*, pthread_attr_t const*, void* (*)(void*), void*) /root/mariadb/include/mysql/psi/mysql_thread.h:1139:11
          #4 0x85cef4 in create_thread_to_handle_connection(CONNECT*) /root/mariadb/sql/mysqld.cc:5975:19
          #5 0x85e72a in create_new_thread(CONNECT*) /root/mariadb/sql/mysqld.cc:6034:3
          #6 0x85e72a in handle_accepted_socket(st_mysql_socket, st_mysql_socket) /root/mariadb/sql/mysqld.cc:6096:5
          #7 0x85a34c in handle_connections_sockets() /root/mariadb/sql/mysqld.cc:6220:9
          #8 0x84e9ef in mysqld_main(int, char**) /root/mariadb/sql/mysqld.cc:5870:3
          #9 0x7f3978b530b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
       
      SUMMARY: AddressSanitizer: heap-use-after-free /root/mariadb/strings/ctype-simple.c:964:12 in my_wildcmp_8bit_impl
      Shadow bytes around the buggy address:
        0x0c5280011000: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
        0x0c5280011010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
        0x0c5280011020: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
        0x0c5280011030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
        0x0c5280011040: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      =>0x0c5280011050: fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd fd
        0x0c5280011060: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
        0x0c5280011070: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
        0x0c5280011080: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
        0x0c5280011090: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
        0x0c52800110a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      Shadow byte legend (one shadow byte represents 8 application bytes):
        Addressable:           00
        Partially addressable: 01 02 03 04 05 06 07 
        Heap left redzone:       fa
        Freed heap region:       fd
        Stack left redzone:      f1
        Stack mid redzone:       f2
        Stack right redzone:     f3
        Stack after return:      f5
        Stack use after scope:   f8
        Global redzone:          f9
        Global init order:       f6
        Poisoned by user:        f7
        Container overflow:      fc
        Array cookie:            ac
        Intra object redzone:    bb
        ASan internal:           fe
        Left alloca redzone:     ca
        Right alloca redzone:    cb
        Shadow gap:              cc
      ==9327==ABORTING
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              serg Sergei Golubchik
              Reporter:
              fuboat Jingzhou Fu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.