Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27730

Add PLUGIN_VAR_DEPRECATED flag to plugin variables

Details

    Description

      The sys_var class has the deprecation_substitute member to mark the deprecated variables. As it's set the server produces warnings when these variables are used. However, the plugin has no means to utilize that functionality.

      So the PLUGIN_VAR_DEPRECATED flag is proposed to set that deprecation_substitute with the empty string. A non-empty string can make the warning more informative, but there's no nice way seen to specify it, and not that needed at the moment.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-27228 Deprecate Spider plugin variables that result in excessive tweak

          • Major - Major loss of function.
          • Stalled
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30332 PLUGIN_VAR_DEPRECATED fails to throw a warning on startup

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32917 Documentation - no easy way to determine deprecated/removed variables

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            holyfoot Please review https://github.com/MariaDB/server/commit/2a55054243d81d98d5fe6b44b7882ef6fd331659

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - holyfoot Please review https://github.com/MariaDB/server/commit/2a55054243d81d98d5fe6b44b7882ef6fd331659
            holyfoot Alexey Botchkov added a comment -

            Ok to push.

            holyfoot Alexey Botchkov added a comment - Ok to push.

            People

              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              holyfoot Alexey Botchkov
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.