[MDEV-19246] Change database and table used for Mariabackup's history - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 10.11.0
Component/s: mariabackup
Labels:
None

Description

Mariabackup still uses the PERCONA_SCHEMA.xtrabackup_history table to store history:

https://mariadb.com/kb/en/library/mariabackup-options/#-history

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/xtrabackup.cc#L1123

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/backup_mysql.cc#L584

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/backup_mysql.cc#L1439

Maybe we should rename this database and table?

Attachments

Issue Links

relates to

MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

Closed

MDEV-18347 mariabackup doesn't read all server option groups from configuration files

Closed

MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

Stalled

MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

Closed

MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariadb_backup_*

Closed

MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

Closed

MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

Closed

MDEV-20552 Remove innobackupex mode from Mariabackup

Stalled

MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

Closed

is part of: DOCSCOLLAB-291 Loading...

(4 relates to, 1 is part of)

Activity

Ascending order - Click to sort in descending order

Geoff Montee (Inactive) created issue - 2019-04-12 22:07

Geoff Montee (Inactive) made changes - 2019-04-12 22:07

Field	Original Value	New Value
Link		This issue relates to MDEV-15379 [ MDEV-15379 ]

Geoff Montee (Inactive) made changes - 2019-04-12 22:11

Assignee

Vladislav Vaintroub [ wlad ]

Geoff Montee (Inactive) made changes - 2019-04-15 17:52

Assignee

Vladislav Vaintroub [ wlad ]

Vladislav Lesin [ vlad.lesin ]

Geoff Montee (Inactive) made changes - 2019-04-15 18:24

Description

Mariabackup still uses the PERCONA_SCHEMA.xtrabackup_history table to store history:

https://mariadb.com/kb/en/library/mariabackup-options/#-history

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/xtrabackup.cc#L1123

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/backup_mysql.cc#L584

https://github.com/MariaDB/server/blob/mariadb-10.4.4/extra/mariabackup/backup_mysql.cc#L1439

Maybe we should rename these?

Geoff Montee (Inactive) made changes - 2019-04-16 22:38

Link

This issue relates to ~~MDEV-19264~~ [ ~~MDEV-19264~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:39

Link

This issue relates to ~~MDEV-18931~~ [ ~~MDEV-18931~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:41

Link

This issue relates to ~~MDEV-18985~~ [ ~~MDEV-18985~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:41

Link

This issue relates to ~~MDEV-18917~~ [ ~~MDEV-18917~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to MDEV-18405 [ MDEV-18405 ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to ~~MDEV-18347~~ [ ~~MDEV-18347~~ ]

Geoff Montee (Inactive) made changes - 2019-04-16 22:47

Link

This issue relates to ~~MDEV-14746~~ [ ~~MDEV-14746~~ ]

Geoff Montee (Inactive) made changes - 2019-06-13 23:41

Link

This issue relates to MDEV-19753 [ MDEV-19753 ]

Geoff Montee (Inactive) made changes - 2019-09-11 03:16

Link

This issue relates to ~~MDEV-20556~~ [ ~~MDEV-20556~~ ]

Geoff Montee (Inactive) made changes - 2019-09-11 03:17

Link

This issue relates to MDEV-20552 [ MDEV-20552 ]

Geoff Montee (Inactive) made changes - 2021-02-05 17:49

Assignee

Vladislav Lesin [ vlad.lesin ]

Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]

Ralf Gebhardt made changes - 2021-04-12 10:25

Fix Version/s

10.4 [ 22408 ]

Ralf Gebhardt made changes - 2021-04-12 10:26

Epic/Theme

MariaDB_Branding

Ralf Gebhardt made changes - 2021-07-01 12:39

Fix Version/s		10.7 [ 24805 ]
Priority	Major [ 3 ]	Critical [ 2 ]

Ralf Gebhardt made changes - 2021-07-01 12:42

Assignee

Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]

Geoff Montee (Inactive) made changes - 2021-08-31 16:23

Link

This issue blocks MENT-1184 [ MENT-1184 ]

Geoff Montee (Inactive) made changes - 2021-08-31 16:24

Link

This issue relates to MENT-1184 [ MENT-1184 ]

Sergei Golubchik made changes - 2021-09-04 12:39

Priority

Critical [ 2 ]

Major [ 3 ]

Julien Fritsch made changes - 2021-09-09 14:26

Assignee

Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]

Sergei Golubchik made changes - 2021-09-10 07:32

Link

This issue blocks MENT-1184 [ MENT-1184 ]

Ralf Gebhardt made changes - 2021-10-12 21:14

Fix Version/s

10.7 [ 24805 ]

Ralf Gebhardt made changes - 2021-10-27 17:46

Assignee

Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]

Sergei Golubchik made changes - 2021-12-06 21:21

Workflow

MariaDB v3 [ 95359 ]

MariaDB v4 [ 131061 ]

Ralf Gebhardt made changes - 2022-01-28 09:59

Assignee

Sergei Golubchik [ serg ]

Sergei Golubchik added a comment - 2022-03-25 12:44

is this table only used by mariabackup itself for incremental backups? Does it have any other usages, other tools that use it, perhaps?

Sergei Golubchik added a comment - 2022-03-25 12:44 is this table only used by mariabackup itself for incremental backups? Does it have any other usages, other tools that use it, perhaps?

Sergei Golubchik made changes - 2022-03-25 12:44

Status

Open [ 1 ]

Needs Feedback [ 10501 ]

Geoff Montee (Inactive) added a comment - 2022-03-25 16:39

I am not aware of any tools other than Percona XtraBackup and mariabackup that use the table.

According to the Percona XtraBackup documentation, the table is primarily intended for maintaining a history of backups for informational purposes:

Percona XtraBackup supports storing the backups history on the server. This feature was implemented in Percona XtraBackup 2.2. Storing backup history on the server was implemented to provide users with additional information about backups that are being taken. Backup history information will be stored in the PERCONA_SCHEMA.XTRABACKUP_HISTORY table.

https://www.percona.com/doc/percona-xtrabackup/LATEST/xtrabackup_bin/backup.history.html

Geoff Montee (Inactive) added a comment - 2022-03-25 16:39 I am not aware of any tools other than Percona XtraBackup and mariabackup that use the table. According to the Percona XtraBackup documentation, the table is primarily intended for maintaining a history of backups for informational purposes: Percona XtraBackup supports storing the backups history on the server. This feature was implemented in Percona XtraBackup 2.2. Storing backup history on the server was implemented to provide users with additional information about backups that are being taken. Backup history information will be stored in the PERCONA_SCHEMA.XTRABACKUP_HISTORY table. https://www.percona.com/doc/percona-xtrabackup/LATEST/xtrabackup_bin/backup.history.html

Geoff Montee (Inactive) made changes - 2022-03-25 16:45

Status

Needs Feedback [ 10501 ]

Open [ 1 ]

Ralf Gebhardt added a comment - 2022-04-04 09:28

But it is not only to log a history, XtraBackup can also use this history to for incremental backups

Ralf Gebhardt added a comment - 2022-04-04 09:28 But it is not only to log a history, XtraBackup can also use this history to for incremental backups

Sergei Golubchik added a comment - 2022-04-04 14:00 - edited

okay, if there aren't any tools that would break because of this change, then yet, let's do it.
What should be the new name? mysql.mariabackup_history ?

Sergei Golubchik added a comment - 2022-04-04 14:00 - edited okay, if there aren't any tools that would break because of this change, then yet, let's do it. What should be the new name? mysql.mariabackup_history ?

Ralf Gebhardt made changes - 2022-04-11 07:03

Link

This issue blocks MENT-1184 [ MENT-1184 ]

Julien Fritsch made changes - 2022-04-21 09:28

Priority

Major [ 3 ]

Blocker [ 1 ]

Julien Fritsch made changes - 2022-04-21 09:28

Priority

Blocker [ 1 ]

Critical [ 2 ]

Ralf Gebhardt made changes - 2022-06-20 17:20

Fix Version/s

10.11 [ 27614 ]

Ralf Gebhardt made changes - 2022-07-05 14:29

Assignee

Sergei Golubchik [ serg ]

Alexander Barkov [ bar ]

AirFocus made changes - 2022-08-09 16:10

Description

Mariabackup still uses the PERCONA_SCHEMA.xtrabackup_history table to store history:

https://mariadb.com/kb/en/library/mariabackup-options/#-history

https://github.com/MariaDB/server/blob/mariadb\-10.4.4/extra/mariabackup/xtrabackup.cc#L1123

https://github.com/MariaDB/server/blob/mariadb\-10.4.4/extra/mariabackup/backup\_mysql.cc#L584

https://github.com/MariaDB/server/blob/mariadb\-10.4.4/extra/mariabackup/backup\_mysql.cc#L1439

Maybe we should rename this database and table?

Alexander Barkov made changes - 2022-09-09 08:14

Status

Open [ 1 ]

In Progress [ 3 ]

Alexander Barkov added a comment - 2022-09-09 08:14

Hello serg,

Can you please review this patch:

https://github.com/MariaDB/server/commit/24d3f2cb8037f40dfce4b6da7ca243c838aa9800

Thanks!

Alexander Barkov added a comment - 2022-09-09 08:14 Hello serg , Can you please review this patch: https://github.com/MariaDB/server/commit/24d3f2cb8037f40dfce4b6da7ca243c838aa9800 ? Thanks!

Alexander Barkov made changes - 2022-09-09 08:14

Assignee	Alexander Barkov [ bar ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik added a comment - 2022-09-09 12:50

24d3f2cb8037f40dfce4b6da7ca243c838aa9800 is ok to push

Sergei Golubchik added a comment - 2022-09-09 12:50 24d3f2cb8037f40dfce4b6da7ca243c838aa9800 is ok to push

Sergei Golubchik made changes - 2022-09-09 12:50

Assignee	Sergei Golubchik [ serg ]	Alexander Barkov [ bar ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Sergei Golubchik added a comment - 2022-09-09 20:16

The primary name is mariadb-backup, but it'd be inconvenient to have a dash in the identifier (table name), it'd always need to be quoted. So mariabackup_history or maria_backup_history. And I think between those two either is fine.

Sergei Golubchik added a comment - 2022-09-09 20:16 The primary name is mariadb-backup, but it'd be inconvenient to have a dash in the identifier (table name), it'd always need to be quoted. So mariabackup_history or maria_backup_history . And I think between those two either is fine.

Alexander Barkov added a comment - 2022-09-12 09:56

Let's go with mariadb_backup_history. It's closest possible to the program name, just using an underscore instead of a dash.

Alexander Barkov added a comment - 2022-09-12 09:56 Let's go with mariadb_backup_history . It's closest possible to the program name, just using an underscore instead of a dash.

Alexander Barkov made changes - 2022-09-12 10:55

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Alexander Barkov made changes - 2022-09-12 10:55

Fix Version/s		10.11.0 [ 28411 ]
Fix Version/s	10.11 [ 27614 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Anne Strasser (Inactive) made changes - 2023-04-18 21:51

Remote Link

This issue links to "DOCSCOLLAB-291 (Jira)" [ 35218 ]

Anne Strasser (Inactive) made changes - 2023-04-18 21:52

Remote Link

This issue links to "DOCSCOLLAB-291 (Jira)" [ 35218 ]

Jira Automation (IT) made changes - 2024-07-04 04:03

Zendesk Related Tickets		201675
Zendesk active tickets		201675

People

Assignee:: Alexander Barkov

Reporter:: Geoff Montee (Inactive)

Votes:: 1 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 2019-04-12 22:07

Updated:: 2024-09-05 21:21

Resolved:: 2022-09-12 10:55

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration