Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
Description
This task is a proposal to introduce new variables
log_slow_queries_not_using_indexes: alias of log_queries_not_using_indexes
log_slow_queries_not_using_indexes_filter: filter based on task MDEV-7566
log_slow_query_time: alias of long_query_time
log_slow_throttle_queries_not_using_indexes; alias of log_throttle_queries_not_using_indexes introduced in 5.6
log_slow_min_examined_row_limit: alias of min_examined_row_limit
Attachments
Issue Links
- blocks
-
MDEV-7566 log_queries_not_using_index reduce verbosity
-
- Open
-
- causes
-
MDEV-29297 remove aliases of system variables
-
- Open
-
-
MDEV-29594 sys_vars tests fail on 32-bit with wrong data types / max values
-
- Closed
-
-
MDEV-29595 Adjust variable name for slow log file and help referring to the value
-
- Closed
-
-
MDEV-29598 long_query_time description refers to its old name
-
- Closed
-
-
MDEV-29625 Some clients/scripts refer to old slow log variables
-
- Closed
-
-
MDEV-29626 Assertion `self == &Sys_slow_query_log' failed in fix_log_state
-
- Closed
-
-
MDEV-29689 Incorrect variable log_slow_query_file_name in KB
-
- Closed
-
- is part of
-
MDEV-29547 prepare 10.11.0 preview releases
-
- Closed
-
- relates to
-
MDEV-29629 Session state tracking does not track variable changes via aliases
-
- Closed
-
There was some back-and-forth in this task, so, to summarize, as of bb-10.11-
MDEV-75673b3ce1fbca here is what is de-facto there:log_slow_min_examined_row_limit (min_examined_row_limit)
log_slow_query (slow_query_log)
log_slow_query_file_name (slow_query_log_file)
log_slow_query_time (long_query_time)
It remains unclear what was the role-model for log_slow_query_file_name.
We have a variety of patterns with similar meaning:
general_log_file
relay_log_info_file
wsrep_status_file
pid_file
log_error
log_bin_basename
innodb_buffer_pool_filename
but I couldn't find any %_file_name (maybe somewhere in optional plugins, those I didn't check).
So, maybe it should be just log_slow_query_file, like several existing _file's. Or even just log_slow_file, given the variable list
+---------------------------------+
| log_slow_min_examined_row_limit |
| log_slow_slave_statements |
| log_slow_query_time |
| log_slow_verbosity |
| log_slow_admin_statements |
| log_slow_disabled_statements |
| log_slow_query |
| log_slow_query_file_name |
| log_slow_rate_limit |
| log_slow_filter |
+---------------------------------+
Filed as
MDEV-29595so that it's not forgotten, with an additional note for an extra fix in help text.