Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29625

Some clients/scripts refer to old slow log variables

Details

    Description

      There are some scripts/files which use old slow-log-related variables. They should probably be updated now, to refer either to new names or both, depending on the context – new names should be enough if they look into the server, and both are needed if they look into the config files. Otherwise those which refer to config options may start malfunctioning as soon as users put new names in the configs, and those which refer to the server variables may be forgotten when the old variables get removed.

      So far I've found

      • client/mysqldump.c (setting SLOW_QUERY_LOG))
      • debian/additions/mariadb.conf.d/50-server.cnf (variable examples)
      • debian/additions/mariadb-report (reading variables)
      • scripts/mysqldumpslow.sh (retrieving slow file log name)
      • scripts/mysql_system_tables_fix.sql (unsetting slow logging temporarily)
      • scripts/wsrep_sst_mysqldump.sh (unsetting slow logging temporarily)
      • scripts/sys_schema/procedures/ps_trace_thread_57.sql, scripts/sys_schema/procedures/ps_trace_thread.sql - using long query time in a condition
      • tests/mysql_client_test.c (changing the variables)

      The list may be incomplete, and naturally it doesn't include MTR which will hopefully notice when the variables get finally removed (or if it doesn't notice, it's useless anyway).

      Attachments

        Issue Links

          Activity

            elenst Elena Stepanova added a comment - - edited

            From the list in the description, mariadb-report, mysqldumpslow.sh and mysql_client_test remained unchanged. Is it intentional?

            Upd: Confirmed as intentional

            elenst Elena Stepanova added a comment - - edited From the list in the description, mariadb-report , mysqldumpslow.sh and mysql_client_test remained unchanged. Is it intentional? Upd: Confirmed as intentional

            Also, binlog/replication tests failed massively on 36b42630a due to a change for max_insert_delayed_threads in mysqlbinlog (which isn't related to MDEV-7567 and wasn't listed, but now the tests need to be fixed according to the change)

            CURRENT_TEST: rpl.rpl_blackhole_row_annotate
            --- /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/rpl/r/rpl_blackhole_row_annotate.result	2022-09-26 20:41:28.000000000 +0300
            +++ /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/rpl/r/rpl_blackhole_row_annotate.reject	2022-09-26 23:16:55.373241458 +0300
            @@ -179,7 +179,7 @@
             slave-bin.000001	#	Query	1	#	use `test`; DROP TABLE IF EXISTS `t1`,`t2` /* generated by server */
             slave-bin.000001	#	Rotate	2	#	slave-bin.000002;pos=4
             /*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=1*/;
            -/*!40019 SET @@session.max_insert_delayed_threads=0*/;
            +/*!40019 SET @@session.max_delayed_threads=0*/;
             /*!50003 SET @OLD_COMPLETION_TYPE=@@COMPLETION_TYPE,COMPLETION_TYPE=0*/;
             DELIMITER /*!*/;
             # at #
             
            mysqltest: Result length mismatch
            

            elenst Elena Stepanova added a comment - Also, binlog/replication tests failed massively on 36b42630a due to a change for max_insert_delayed_threads in mysqlbinlog (which isn't related to MDEV-7567 and wasn't listed, but now the tests need to be fixed according to the change) CURRENT_TEST: rpl.rpl_blackhole_row_annotate --- /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/rpl/r/rpl_blackhole_row_annotate.result 2022-09-26 20:41:28.000000000 +0300 +++ /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/rpl/r/rpl_blackhole_row_annotate.reject 2022-09-26 23:16:55.373241458 +0300 @@ -179,7 +179,7 @@ slave-bin.000001 # Query 1 # use `test`; DROP TABLE IF EXISTS `t1`,`t2` /* generated by server */ slave-bin.000001 # Rotate 2 # slave-bin.000002;pos=4 /*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=1*/; -/*!40019 SET @@session.max_insert_delayed_threads=0*/; +/*!40019 SET @@session.max_delayed_threads=0*/; /*!50003 SET @OLD_COMPLETION_TYPE=@@COMPLETION_TYPE,COMPLETION_TYPE=0*/; DELIMITER /*!*/; # at #   mysqltest: Result length mismatch

            People

              serg Sergei Golubchik
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.