[MDEV-6128] [PATCH] mysqlcheck wrongly escapes '.' in table names - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 5.5.36, 5.5.37, 10.0.7, 10.0.10
Fix Version/s: 5.5.42, 10.0.17, 10.1.3
Component/s: OTHER
Labels:
- upstream
Environment:
linux

Description

mysqlcheck encloses dots in a table in backticks, this doesn't make sense though as never expects to see a db.table combination (database and table names are passed in as separate parameters)

This breaks mysqlcheck, and indirectly mysql_upgrade, for tables with a dot in their name

test case:

  CREATE TABLE test.`foo.bar`(id int primary key);

then run

  mysqlcheck test foo.bar

  mysql_upgrade --force

This was introduced in revision 1810.3494.1 ( http://bazaar.launchpad.net/~mysql/mysql-server/5.6/revision/1810.3494.1 ) as part of a fix for http://bugs.mysql.com/bug.php?id=30654

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

mdev-6128.patch
0.6 kB
2014-04-17 16:13

Issue Links

links to

MySQL:72382 - mysqlcheck wrongly escapes '.' in table names

Activity

Ascending order - Click to sort in descending order

Hartmut Holzgraefe created issue - 2014-04-17 16:11

Hartmut Holzgraefe added a comment - 2014-04-17 16:11 - edited

proposed fix:

=== modified file 'client/mysqlcheck.c'

--- client/mysqlcheck.c	2013-05-07 11:05:09 +0000

+++ client/mysqlcheck.c	2014-04-17 12:57:31 +0000

@@ -513,8 +513,6 @@

     if (*p == '`')

       extra_length++;

-    else if (*p == '.')

-      extra_length+= 2;

   DBUG_RETURN((uint) ((p - name) + extra_length));

@@ -529,11 +527,6 @@

   for (; *src; src++)

     switch (*src) {

-    case '.':            /* add backticks around '.' */

-      *dest++= '`';

-      *dest++= '.';

-      *dest++= '`';

-      break;

     case '`':            /* escape backtick character */

       *dest++= '`';

       /* fall through */

Hartmut Holzgraefe added a comment - 2014-04-17 16:11 - edited proposed fix: === modified file 'client/mysqlcheck.c' --- client/mysqlcheck.c 2013-05-07 11:05:09 +0000 +++ client/mysqlcheck.c 2014-04-17 12:57:31 +0000 @@ -513,8 +513,6 @@ { if (*p == '`') extra_length++; - else if (*p == '.') - extra_length+= 2; } DBUG_RETURN((uint) ((p - name) + extra_length)); @@ -529,11 +527,6 @@ for (; *src; src++) { switch (*src) { - case '.': /* add backticks around '.' */ - *dest++= '`'; - *dest++= '.'; - *dest++= '`'; - break; case '`': /* escape backtick character */ *dest++= '`'; /* fall through */

Hartmut Holzgraefe added a comment - 2014-04-17 16:13

proposed patch

Hartmut Holzgraefe added a comment - 2014-04-17 16:13 proposed patch

Hartmut Holzgraefe made changes - 2014-04-17 16:13

Field	Original Value	New Value
Attachment		mdev-6128.patch [ 29117 ]

Hartmut Holzgraefe added a comment - 2014-04-18 23:22

looks as if this is fixed in 5.7, but something is odd about it on launchpad

check

http://bazaar.launchpad.net/~mysql/mysql-server/5.6/annotate/head:/client/mysqlcheck.c#L52...

and

http://bazaar.launchpad.net/~mysql/mysql-server/5.7/annotate/head:/client/mysqlcheck.c#L52...

the code escaping the '.' is gone in 5.7, but launchpad still lists the old changeset from 2007 for this part of the code?

see also http://bugs.mysql.com/bug.php?id=72382

Hartmut Holzgraefe added a comment - 2014-04-18 23:22 looks as if this is fixed in 5.7, but something is odd about it on launchpad check http://bazaar.launchpad.net/~mysql/mysql-server/5.6/annotate/head:/client/mysqlcheck.c#L52 ... and http://bazaar.launchpad.net/~mysql/mysql-server/5.7/annotate/head:/client/mysqlcheck.c#L52 ... the code escaping the '.' is gone in 5.7, but launchpad still lists the old changeset from 2007 for this part of the code? see also http://bugs.mysql.com/bug.php?id=72382

Hartmut Holzgraefe added a comment - 2014-04-18 23:40

Oracle's actual fix change sets are here:

http://bazaar.launchpad.net/~mysql/mysql-server/5.7/revision/7416
http://bazaar.launchpad.net/~mysql/mysql-server/5.7/revision/7481

looks as if there is a little more work needed as at some point it actually used db.table names internally ...

my local 5.7 checkout also shows the wrong old changeset with "bzr annotate client/mysqlcheck.c",
but "bzr log client/mysqlcheck.c" so there seems to be a bzr bug? Or has Oracle somehow managed to corrupt their 5.7 tree?

Hartmut Holzgraefe added a comment - 2014-04-18 23:40 Oracle's actual fix change sets are here: http://bazaar.launchpad.net/~mysql/mysql-server/5.7/revision/7416 http://bazaar.launchpad.net/~mysql/mysql-server/5.7/revision/7481 looks as if there is a little more work needed as at some point it actually used db.table names internally ... my local 5.7 checkout also shows the wrong old changeset with "bzr annotate client/mysqlcheck.c", but "bzr log client/mysqlcheck.c" so there seems to be a bzr bug? Or has Oracle somehow managed to corrupt their 5.7 tree?

Elena Stepanova made changes - 2014-04-20 23:10

Fix Version/s		10.0.12 [ 15201 ]
Fix Version/s		5.5.38 [ 15400 ]
Affects Version/s		5.5.37 [ 15000 ]
Affects Version/s		10.0.10 [ 14500 ]
Affects Version/s		10.0.7 [ 14100 ]
Affects Version/s	10.0.7-galera [ 14800 ]
Labels		upstream

Elena Stepanova made changes - 2014-04-20 23:11

Remote Link

This issue links to "MySQL:72382 - http://bugs.mysql.com/bug.php?id=72382 (Web Link)" [ 16400 ]

Elena Stepanova made changes - 2014-04-20 23:12

Remote Link

This issue links to "MySQL:72382 - http://bugs.mysql.com/bug.php?id=72382 (Web Link)" [ 16400 ]

Elena Stepanova made changes - 2014-04-20 23:12

Remote Link

This issue links to "MySQL:72382 - mysqlcheck wrongly escapes '.' in table names (Web Link)" [ 16401 ]

Elena Stepanova made changes - 2014-04-20 23:13

Summary

mysqlcheck wrongly escapes '.' in table names

[PATCH] mysqlcheck wrongly escapes '.' in table names

Sergei Golubchik made changes - 2014-04-21 00:18

Description

mysqlcheck encloses dots in a table in backticks, this doesn't make sense though as never expects to see a db.table combination (database and table names are passed in as separate parameters)

This breaks mysqlcheck, and indirectly mysql_upgrade, for tables with a dot in their name

test case:

  CREATE TABLE test.`foo.bar`(id int primary key);

then run

  mysqlcheck test foo.bar

or

  mysql_upgrade --force

This was introduced in revision 1810.3494.1 ( http://bazaar.launchpad.net/~mysql/mysql-server/5.6/revision/1810.3494.1 ) as part of a fix for http://bugs.mysql.com/bug.php?id=30654

mysqlcheck encloses dots in a table in backticks, this doesn't make sense though as never expects to see a db.table combination (database and table names are passed in as separate parameters)

This breaks mysqlcheck, and indirectly mysql_upgrade, for tables with a dot in their name

test case:
{code:sql}
  CREATE TABLE test.`foo.bar`(id int primary key);
{code}
then run
{noformat}
  mysqlcheck test foo.bar
{noformat}
or
{noformat}
  mysql_upgrade --force
{noformat}
This was introduced in revision 1810.3494.1 ( http://bazaar.launchpad.net/~mysql/mysql-server/5.6/revision/1810.3494.1 ) as part of a fix for http://bugs.mysql.com/bug.php?id=30654

Sergei Golubchik made changes - 2014-04-21 00:18

Priority

Minor [ 4 ]

Major [ 3 ]

Sergei Golubchik made changes - 2014-05-28 12:04

Priority

Major [ 3 ]

Minor [ 4 ]

Sergei Golubchik made changes - 2014-06-06 10:26

Fix Version/s		5.5.39 [ 15800 ]
Fix Version/s	5.5.38 [ 15400 ]

Sergei Golubchik made changes - 2014-06-13 15:06

Workflow

defaullt [ 38946 ]

MariaDB v2 [ 43150 ]

Sergei Golubchik made changes - 2014-06-16 13:27

Fix Version/s		10.0.13 [ 16000 ]
Fix Version/s	10.0.12 [ 15201 ]

Oleksandr Byelkin made changes - 2015-01-27 16:41

Assignee

Oleksandr Byelkin [ sanja ]

Oleksandr Byelkin made changes - 2015-01-27 16:41

Priority

Minor [ 4 ]

Critical [ 2 ]

Oleksandr Byelkin made changes - 2015-01-27 16:41

Status

Open [ 1 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2015-01-28 11:08

test suite (just for record):

CREATE TABLE test.`t.1` (id int);

--echo mysqlcheck test t.1

--exec $MYSQL_CHECK test t.1

drop table test.`t.1`;

Oleksandr Byelkin added a comment - 2015-01-28 11:08 test suite (just for record): CREATE TABLE test.`t.1` (id int); --echo mysqlcheck test t.1 --exec $MYSQL_CHECK test t.1 drop table test.`t.1`;

Oleksandr Byelkin added a comment - 2015-01-28 13:13

patch is pushed to 5.5

Oleksandr Byelkin added a comment - 2015-01-28 13:13 patch is pushed to 5.5

Oleksandr Byelkin made changes - 2015-01-28 13:13

Component/s		OTHER [ 10125 ]
Fix Version/s		10.0.17 [ 18300 ]
Fix Version/s		10.1.3 [ 18000 ]
Fix Version/s		5.5.42 [ 18102 ]
Fix Version/s	5.5 [ 15800 ]
Fix Version/s	10.0 [ 16000 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 43150 ]

MariaDB v3 [ 66173 ]

Sergei Golubchik made changes - 2021-12-06 21:40

Workflow

MariaDB v3 [ 66173 ]

MariaDB v4 [ 147807 ]

People

Assignee:: Oleksandr Byelkin

Reporter:: Hartmut Holzgraefe

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2014-04-17 16:11

Updated:: 2016-08-08 19:27

Resolved:: 2015-01-28 13:13

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration