Type:
Task
Priority:
Critical
Resolution:
Fixed
To fix MDEV-27744 and to remove duplicate code, let's add a new class as follows:
/*
Save the current sql_mode. Switch off sql_mode flags which can prevent
normal parsing of VIEWs, expressions in generated columns.
Restore the old sql_mode on destructor.
*/
class Sql_mode_save_for_frm_handling: public Sql_mode_save
{
public :
Sql_mode_save_for_frm_handling(THD *thd)
:Sql_mode_save(thd)
{
/*
- MODE_REAL_AS_FLOAT affect only CREATE TABLE parsing
+ MODE_PIPES_AS_CONCAT affect expression parsing
+ MODE_ANSI_QUOTES affect expression parsing
+ MODE_IGNORE_SPACE affect expression parsing
- MODE_IGNORE_BAD_TABLE_OPTIONS affect only CREATE/ALTER TABLE parsing
* MODE_ONLY_FULL_GROUP_BY affect execution
* MODE_NO_UNSIGNED_SUBTRACTION affect execution
- MODE_NO_DIR_IN_CREATE affect table creation only
- MODE_POSTGRESQL compounded from other modes
+ MODE_ORACLE affects Item creation (e.g for CONCAT)
- MODE_MSSQL compounded from other modes
- MODE_DB2 compounded from other modes
- MODE_MAXDB affect only CREATE TABLE parsing
- MODE_NO_KEY_OPTIONS affect only SHOW
- MODE_NO_TABLE_OPTIONS affect only SHOW
- MODE_NO_FIELD_OPTIONS affect only SHOW
- MODE_MYSQL323 affect only SHOW
- MODE_MYSQL40 affect only SHOW
- MODE_ANSI compounded from other modes
(+ transaction mode)
? MODE_NO_AUTO_VALUE_ON_ZERO affect UPDATEs
+ MODE_NO_BACKSLASH_ESCAPES affect expression parsing
+ MODE_EMPTY_STRING_IS_NULL affect expression parsing
*/
thd->variables.sql_mode&= ~(MODE_PIPES_AS_CONCAT | MODE_ANSI_QUOTES |
MODE_IGNORE_SPACE | MODE_NO_BACKSLASH_ESCAPES |
MODE_ORACLE | MODE_EMPTY_STRING_IS_NULL);
};
};
and reuse it in all places where we reset sql_mode for unambiguous and equal re-parsing.
Currently there are multiple places resetting different sql_mode flags, e.g.:
generate_partition_syntax_for_frm:
sql_mode_t old_mode= thd->variables.sql_mode;
thd->variables.sql_mode &= ~MODE_ANSI_QUOTES;
mysql_register_view:
sql_mode_t sql_mode= thd->variables.sql_mode & MODE_ANSI_QUOTES;
thd->variables.sql_mode&= ~MODE_ANSI_QUOTES;
mysql_make_view:
thd->variables.sql_mode&= ~(MODE_PIPES_AS_CONCAT | MODE_ANSI_QUOTES |
MODE_IGNORE_SPACE | MODE_NO_BACKSLASH_ESCAPES |
MODE_ORACLE);
parse_vcol_defs:
thd->variables.sql_mode &= ~(MODE_NO_BACKSLASH_ESCAPES | MODE_EMPTY_STRING_IS_NULL);
build_frm_image:
sql_mode_t save_sql_mode= thd->variables.sql_mode;
thd->variables.sql_mode &= ~MODE_ANSI_QUOTES;
/
blocks
MDEV-27744
LPAD in vcol created in ORACLE mode makes table corrupted in non-ORACLE
Closed
{"report":{"fcp":1004.7999997138977,"ttfb":363.69999980926514,"pageVisibility":"visible","entityId":121581,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"063e5ce8-6e42-4b93-a093-b1a20fbe8233","navigationType":0,"readyForUser":1092,"redirectCount":0,"resourceLoadedEnd":1028.1999998092651,"resourceLoadedStart":369.59999990463257,"resourceTiming":[{"duration":55.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":369.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":369.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":425,"responseStart":0,"secureConnectionStart":0},{"duration":56.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":369.7999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":369.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":426.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":120.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":370.09999990463257,"connectEnd":370.09999990463257,"connectStart":370.09999990463257,"domainLookupEnd":370.09999990463257,"domainLookupStart":370.09999990463257,"fetchStart":370.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":370.09999990463257,"responseEnd":490.90000009536743,"responseStart":490.90000009536743,"secureConnectionStart":370.09999990463257},{"duration":186.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":370.19999980926514,"connectEnd":370.19999980926514,"connectStart":370.19999980926514,"domainLookupEnd":370.19999980926514,"domainLookupStart":370.19999980926514,"fetchStart":370.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":370.19999980926514,"responseEnd":556.9000000953674,"responseStart":556.9000000953674,"secureConnectionStart":370.19999980926514},{"duration":190.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":370.5,"connectEnd":370.5,"connectStart":370.5,"domainLookupEnd":370.5,"domainLookupStart":370.5,"fetchStart":370.5,"redirectEnd":0,"redirectStart":0,"requestStart":370.5,"responseEnd":560.7999997138977,"responseStart":560.7999997138977,"secureConnectionStart":370.5},{"duration":190.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":370.69999980926514,"connectEnd":370.69999980926514,"connectStart":370.69999980926514,"domainLookupEnd":370.69999980926514,"domainLookupStart":370.69999980926514,"fetchStart":370.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":370.69999980926514,"responseEnd":561.1999998092651,"responseStart":561.1999998092651,"secureConnectionStart":370.69999980926514},{"duration":190.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":370.90000009536743,"connectEnd":370.90000009536743,"connectStart":370.90000009536743,"domainLookupEnd":370.90000009536743,"domainLookupStart":370.90000009536743,"fetchStart":370.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":370.90000009536743,"responseEnd":561.6999998092651,"responseStart":561.6999998092651,"secureConnectionStart":370.90000009536743},{"duration":264.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":371.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":371.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":635.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":191.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":371.19999980926514,"connectEnd":371.19999980926514,"connectStart":371.19999980926514,"domainLookupEnd":371.19999980926514,"domainLookupStart":371.19999980926514,"fetchStart":371.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":371.19999980926514,"responseEnd":562.2999997138977,"responseStart":562.2999997138977,"secureConnectionStart":371.19999980926514},{"duration":263.8999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":371.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":371.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":635.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":191.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":371.5,"connectEnd":371.5,"connectStart":371.5,"domainLookupEnd":371.5,"domainLookupStart":371.5,"fetchStart":371.5,"redirectEnd":0,"redirectStart":0,"requestStart":371.5,"responseEnd":562.7999997138977,"responseStart":562.7999997138977,"secureConnectionStart":371.5},{"duration":337.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":372.40000009536743,"connectEnd":372.40000009536743,"connectStart":372.40000009536743,"domainLookupEnd":372.40000009536743,"domainLookupStart":372.40000009536743,"fetchStart":372.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":372.40000009536743,"responseEnd":709.9000000953674,"responseStart":709.9000000953674,"secureConnectionStart":372.40000009536743},{"duration":532.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":372.5,"connectEnd":372.5,"connectStart":372.5,"domainLookupEnd":372.5,"domainLookupStart":372.5,"fetchStart":372.5,"redirectEnd":0,"redirectStart":0,"requestStart":372.5,"responseEnd":904.9000000953674,"responseStart":904.7999997138977,"secureConnectionStart":372.5},{"duration":61.799999713897705,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":648.5,"connectEnd":648.5,"connectStart":648.5,"domainLookupEnd":648.5,"domainLookupStart":648.5,"fetchStart":648.5,"redirectEnd":0,"redirectStart":0,"requestStart":648.5,"responseEnd":710.2999997138977,"responseStart":710.2999997138977,"secureConnectionStart":648.5},{"duration":122.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":905.7999997138977,"connectEnd":905.7999997138977,"connectStart":905.7999997138977,"domainLookupEnd":905.7999997138977,"domainLookupStart":905.7999997138977,"fetchStart":905.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":905.7999997138977,"responseEnd":1028.1999998092651,"responseStart":1028.1999998092651,"secureConnectionStart":905.7999997138977},{"duration":136.7999997138977,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":998.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":998.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1135.1999998092651,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":181,"responseStart":363,"responseEnd":365,"domLoading":367,"domInteractive":1162,"domContentLoadedEventStart":1162,"domContentLoadedEventEnd":1212,"domComplete":1268,"loadEventStart":1268,"loadEventEnd":1269,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1137.1999998092651},{"name":"bigPipe.sidebar-id.end","time":1138},{"name":"bigPipe.activity-panel-pipe-id.start","time":1138},{"name":"bigPipe.activity-panel-pipe-id.end","time":1139.0999999046326},{"name":"activityTabFullyLoaded","time":1232.5999999046326}],"measures":[],"correlationId":"fbd63dd6bc8f82","effectiveType":"4g","downlink":9.1,"rtt":0,"serverDuration":108,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Hello Sergei Golubchik, please find the latest patch here:
https://github.com/MariaDB/server/commits/bb-10.4-bar-MDEV-27744-v2
There are three patches in this branch:
MDEV-31184MDEV-31187MDEV-27744Thanks.