Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30664

tests: mysqldump output is truncated on windows

Details

    Description

      Recent example: https://buildbot.mariadb.net/buildbot/builders/winx64-debug/builds/35923
      but it was happening for a few years.

      A possible fix could be

      --- a/client/mysqldump.c
      +++ b/client/mysqldump.c
      @@ -1953,8 +1953,11 @@
       
       static void free_resources()
       {
      -  if (md_result_file && md_result_file != stdout)
      -    my_fclose(md_result_file, MYF(0));
      +  if (md_result_file)
      +    if (md_result_file != stdout)
      +      my_fclose(md_result_file, MYF(0));
      +    else
      +      fflush(md_result_file);
         if (get_table_name_result)
           mysql_free_result(get_table_name_result);
         if (routine_res)
      

      or may be even

      --- a/client/mysqldump.c
      +++ b/client/mysqldump.c
      @@ -1953,7 +1953,7 @@
       
       static void free_resources()
       {
      -  if (md_result_file && md_result_file != stdout)
      +  if (md_result_file)
           my_fclose(md_result_file, MYF(0));
         if (get_table_name_result)
           mysql_free_result(get_table_name_result);
      

      Attachments

        Activity

          serg Sergei Golubchik created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          Fix Version/s 10.8 [ 26121 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.7 [ 24805 ]
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.8 [ 26121 ]
          oleg.smirnov Oleg Smirnov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          oleg.smirnov Oleg Smirnov added a comment -

          serg, please review the patch bb-10.4-mdev-30664

          oleg.smirnov Oleg Smirnov added a comment - serg , please review the patch bb-10.4-mdev-30664
          oleg.smirnov Oleg Smirnov made changes -
          Status In Progress [ 3 ] In Review [ 10002 ]
          oleg.smirnov Oleg Smirnov made changes -
          Assignee Oleg Smirnov [ JIRAUSER50405 ] Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ] Vladislav Vaintroub [ wlad ]
          wlad Vladislav Vaintroub added a comment - https://github.com/MariaDB/server/commit/58883ad04eebdcdb2b23824b1fde42f96b4daaf8 looks good to me,
          wlad Vladislav Vaintroub made changes -
          Status In Review [ 10002 ] Stalled [ 10000 ]
          wlad Vladislav Vaintroub made changes -
          Assignee Vladislav Vaintroub [ wlad ] Oleg Smirnov [ JIRAUSER50405 ]
          oleg.smirnov Oleg Smirnov added a comment -

          Pushed to 10.4, to be merged upstream

          oleg.smirnov Oleg Smirnov added a comment - Pushed to 10.4, to be merged upstream
          oleg.smirnov Oleg Smirnov made changes -
          Fix Version/s 10.4.32 [ 29300 ]
          Fix Version/s 10.5.23 [ 29012 ]
          Fix Version/s 10.6.16 [ 29014 ]
          Fix Version/s 10.10.7 [ 29018 ]
          Fix Version/s 10.11.6 [ 29020 ]
          Fix Version/s 11.0.4 [ 29021 ]
          Fix Version/s 11.1.3 [ 29023 ]
          Fix Version/s 11.2.2 [ 29035 ]
          Fix Version/s 10.9.8 [ 29015 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]

          People

            oleg.smirnov Oleg Smirnov
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.