Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30664

tests: mysqldump output is truncated on windows

Details

    Description

      Recent example: https://buildbot.mariadb.net/buildbot/builders/winx64-debug/builds/35923
      but it was happening for a few years.

      A possible fix could be

      --- a/client/mysqldump.c
      		 
      +++ b/client/mysqldump.c
      		 
      @@ -1953,8 +1953,11 @@
      		 
       
       static void free_resources()
      		 
       {
      		 
      -  if (md_result_file && md_result_file != stdout)
      		 
      -    my_fclose(md_result_file, MYF(0));
      		 
      +  if (md_result_file)
      		 
      +    if (md_result_file != stdout)
      		 
      +      my_fclose(md_result_file, MYF(0));
      		 
      +    else
      		 
      +      fflush(md_result_file);
      		 
         if (get_table_name_result)
      		 
           mysql_free_result(get_table_name_result);
      		 
         if (routine_res)

      or may be even

      --- a/client/mysqldump.c
      		 
      +++ b/client/mysqldump.c
      		 
      @@ -1953,7 +1953,7 @@
      		 
       
       static void free_resources()
      		 
       {
      		 
      -  if (md_result_file && md_result_file != stdout)
      		 
      +  if (md_result_file)
      		 
           my_fclose(md_result_file, MYF(0));
      		 
         if (get_table_name_result)
      		 
           mysql_free_result(get_table_name_result);

      Attachments

        Activity

          People

            oleg.smirnov Oleg Smirnov
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.