[MDEV-30664] tests: mysqldump output is truncated on windows Created: 2023-02-16  Updated: 2023-10-17  Resolved: 2023-10-10

Status: Closed
Project: MariaDB Server
Component/s: Platform Windows, Tests
Affects Version/s: 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.9.8, 10.10.7, 10.11.6, 11.0.4, 11.1.3, 11.2.2

Type: Bug Priority: Major
Reporter: Sergei Golubchik Assignee: Oleg Smirnov
Resolution: Fixed Votes: 0
Labels: None


 Description   

Recent example: https://buildbot.mariadb.net/buildbot/builders/winx64-debug/builds/35923
but it was happening for a few years.

A possible fix could be

--- a/client/mysqldump.c
 
+++ b/client/mysqldump.c
 
@@ -1953,8 +1953,11 @@
 
 
 static void free_resources()
 
 {
 
-  if (md_result_file && md_result_file != stdout)
 
-    my_fclose(md_result_file, MYF(0));
 
+  if (md_result_file)
 
+    if (md_result_file != stdout)
 
+      my_fclose(md_result_file, MYF(0));
 
+    else
 
+      fflush(md_result_file);
 
   if (get_table_name_result)
 
     mysql_free_result(get_table_name_result);
 
   if (routine_res)

or may be even

--- a/client/mysqldump.c
 
+++ b/client/mysqldump.c
 
@@ -1953,7 +1953,7 @@
 
 
 static void free_resources()
 
 {
 
-  if (md_result_file && md_result_file != stdout)
 
+  if (md_result_file)
 
     my_fclose(md_result_file, MYF(0));
 
   if (get_table_name_result)
 
     mysql_free_result(get_table_name_result);



 Comments   
Comment by Oleg Smirnov [ 2023-07-07 ]

serg, please review the patch bb-10.4-mdev-30664

Comment by Vladislav Vaintroub [ 2023-10-09 ]

https://github.com/MariaDB/server/commit/58883ad04eebdcdb2b23824b1fde42f96b4daaf8 looks good to me,

Comment by Oleg Smirnov [ 2023-10-10 ]

Pushed to 10.4, to be merged upstream

Generated at Thu Feb 08 10:17:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.