Type:
Bug
Priority:
Critical
Resolution:
Fixed
Affects Version/s:
10.2(EOL) , 10.3(EOL) , 10.4(EOL) , 10.5 , 10.6
Since MariaDB 10.4.19 most tests succeed when the code is compiled with GCC 9 or 10 and cmake -DWITH_UBSAN (and UBSAN is not instructed to crash on errors by setting an environment variable). But, a clang build would crash on bootstrap, due to dereferencing an invalid constant pointer:
10.4
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==619510==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000010 (pc 0x0000006de2b4 bp 0x000200000000 sp 0x7ffe3fc3bbc0 T619510)
==619510==The signal is caused by a READ memory access.
==619510==Hint: address points to the zero page.
#0 0x6de2b4 in __cxx_global_var_init.1130 /mariadb/10.4/sql/sys_vars.cc:5256:8
#1 0x6de2b4 in _GLOBAL__sub_I_sys_vars.cc /mariadb/10.4/sql/sys_vars.cc
#2 0x23fc874 in __libc_csu_init (/dev/shm/10.4/sql/mysqld+0x23fc874)
#3 0x7fdedcfb8c99 in __libc_start_main csu/../csu/libc-start.c:264:6
#4 0x6ee309 in _start (/dev/shm/10.4/sql/mysqld+0x6ee309)
The crashing instruction is attempting to dereference an invalid constant pointer:
0x00000000006de295 <+36517>: movabs $0x9ddfea08eb382d69,%r14
If applying any offset to the null pointer is undefined behaviour, then surely also applying an offset to an invalid constant pointer should be undefined behaviour:
#define MASTER_INFO_VAR(X) my_offsetof(Master_info, X), sizeof(((Master_info *)0x10)->X)
#define my_offsetof(TYPE, MEMBER) PTR_BYTE_DIFF(&((TYPE *)0x10)->MEMBER, 0x10)
(Note: offsetof is defined for POD, but not for C++ objects. Any use of the macro my_offsetof on C++ objects ought to be undefined behaviour.
The following patch, which removes all use of MASTER_INFO_VAR but not my_offsetof , allows the bootstrap to succeed on clang :
diff --git a/sql/mysqld.cc b/sql/mysqld.cc
index ba1d477882f..90064ac94f5 100644
--- a/sql/mysqld.cc
+++ b/sql/mysqld.cc
@@ -8991,7 +8991,7 @@ static int get_options(int *argc_ptr, char ***argv_ptr)
/* Remember if max_user_connections was 0 at startup */
max_user_connections_checking= global_system_variables.max_user_connections != 0;
-#ifdef HAVE_REPLICATION
+#if 0 // ifdef HAVE_REPLICATION
{
sys_var *max_relay_log_size_var, *max_binlog_size_var;
/* If max_relay_log_size is 0, then set it to max_binlog_size */
diff --git a/sql/rpl_rli.cc b/sql/rpl_rli.cc
index c0ade40b461..5d41552df1b 100644
--- a/sql/rpl_rli.cc
+++ b/sql/rpl_rli.cc
@@ -82,7 +82,9 @@ Relay_log_info::Relay_log_info(bool is_slave_recovery)
group_relay_log_name[0]= event_relay_log_name[0]=
group_master_log_name[0]= 0;
until_log_name[0]= ign_master_log_name_end[0]= 0;
+#if 0
max_relay_log_size= global_system_variables.max_relay_log_size;
+#endif
bzero((char*) &info_file, sizeof(info_file));
bzero((char*) &cache_buf, sizeof(cache_buf));
mysql_mutex_init(key_relay_log_info_run_lock, &run_lock, MY_MUTEX_INIT_FAST);
diff --git a/sql/sql_class.h b/sql/sql_class.h
index 8e2b6eed338..7a5a886a814 100644
--- a/sql/sql_class.h
+++ b/sql/sql_class.h
@@ -595,12 +595,14 @@ typedef struct system_variables
ulonglong default_regex_flags;
ulonglong max_mem_used;
+#if 0
/**
Place holders to store Multi-source variables in sys_var.cc during
update and show of variables.
*/
ulonglong slave_skip_counter;
ulonglong max_relay_log_size;
+#endif
ha_rows select_limit;
ha_rows max_join_size;
diff --git a/sql/sys_vars.cc b/sql/sys_vars.cc
index c52a8f742a8..05dd872796c 100644
--- a/sql/sys_vars.cc
+++ b/sql/sys_vars.cc
@@ -5215,6 +5215,7 @@ bool update_multi_source_variable(sys_var *self_var, THD *thd,
return result;
}
+#if 0
static bool update_slave_skip_counter(sys_var *self, THD *thd, Master_info *mi)
{
if (mi->rli.slave_running)
@@ -5272,6 +5273,7 @@ static Sys_var_multi_source_ulonglong Sys_max_relay_log_size(
MASTER_INFO_VAR(rli.max_relay_log_size),
VALID_RANGE(0, 1024L*1024*1024), DEFAULT(0), BLOCK_SIZE(IO_SIZE),
ON_UPDATE(update_max_relay_log_size));
+#endif
static Sys_var_charptr Sys_slave_skip_errors(
"slave_skip_errors", "Tells the slave thread to continue "
With this patch, clang-12 is reporting some errors that are not reported by GCC 10.2.1:
main.func_math [ fail ] Found warnings/errors in server log file!
Test ended at 2021-07-29 10:12:13
line
/mariadb/10.4/strings/ctype.c:1151:46: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/strings/ctype.c:1151:46 in
/mariadb/10.4/sql/sql_select.cc:3766:22: runtime error: applying non-zero offset 4020089388120 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/sql/sql_select.cc:3766:22 in
/mariadb/10.4/sql/sql_select.cc:3225:32: runtime error: applying non-zero offset 936 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/sql/sql_select.cc:3225:32 in
/mariadb/10.4/sql/sql_show.cc:3828:7: runtime error: call to function rpl_semi_sync_master_show_clients(THD*, st_mysql_show_var*, char*) through pointer to incorrect function type 'int (*)(THD *, st_mysql_show_var *, void *, system_status_var *, enum_var_type)'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/sql/sql_show.cc:3828:7 in
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/strings/decimal.c:1161:8 in
/mariadb/10.4/strings/json_lib.c:1688:26: runtime error: index -1 out of bounds for type 'json_path_step_t [32]'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /mariadb/10.4/strings/json_lib.c:1688:26 in
^ Found warnings in /dev/shm/10.4/mysql-test/var/log/mysqld.1.err
{"report":{"fcp":1352.6000000238419,"ttfb":337.2000000476837,"pageVisibility":"visible","entityId":101634,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"dc9d81bb-1f3b-4639-b328-fac48f571a46","navigationType":0,"readyForUser":1461.6000000238419,"redirectCount":0,"resourceLoadedEnd":1915.6000000238419,"resourceLoadedStart":374,"resourceTiming":[{"duration":468.3000000715256,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":374,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":842.3000000715256,"responseStart":0,"secureConnectionStart":0},{"duration":468.39999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":374.3000000715256,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374.3000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":842.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":473.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":374.5,"connectEnd":374.5,"connectStart":374.5,"domainLookupEnd":374.5,"domainLookupStart":374.5,"fetchStart":374.5,"redirectEnd":0,"redirectStart":0,"requestStart":374.5,"responseEnd":847.7000000476837,"responseStart":847.7000000476837,"secureConnectionStart":374.5},{"duration":548.8999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":374.7000000476837,"connectEnd":374.7000000476837,"connectStart":374.7000000476837,"domainLookupEnd":374.7000000476837,"domainLookupStart":374.7000000476837,"fetchStart":374.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":374.7000000476837,"responseEnd":923.6000000238419,"responseStart":923.6000000238419,"secureConnectionStart":374.7000000476837},{"duration":552.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":374.89999997615814,"connectEnd":374.89999997615814,"connectStart":374.89999997615814,"domainLookupEnd":374.89999997615814,"domainLookupStart":374.89999997615814,"fetchStart":374.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":374.89999997615814,"responseEnd":927.8000000715256,"responseStart":927.8000000715256,"secureConnectionStart":374.89999997615814},{"duration":553.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":375.10000002384186,"connectEnd":375.10000002384186,"connectStart":375.10000002384186,"domainLookupEnd":375.10000002384186,"domainLookupStart":375.10000002384186,"fetchStart":375.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":375.10000002384186,"responseEnd":928.3000000715256,"responseStart":928.3000000715256,"secureConnectionStart":375.10000002384186},{"duration":553.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":375.3000000715256,"connectEnd":375.3000000715256,"connectStart":375.3000000715256,"domainLookupEnd":375.3000000715256,"domainLookupStart":375.3000000715256,"fetchStart":375.3000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":375.3000000715256,"responseEnd":928.7000000476837,"responseStart":928.7000000476837,"secureConnectionStart":375.3000000715256},{"duration":630.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":375.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":375.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1005.6000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":553.5,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":375.60000002384186,"connectEnd":375.60000002384186,"connectStart":375.60000002384186,"domainLookupEnd":375.60000002384186,"domainLookupStart":375.60000002384186,"fetchStart":375.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":375.60000002384186,"responseEnd":929.1000000238419,"responseStart":929.1000000238419,"secureConnectionStart":375.60000002384186},{"duration":630.1000000238419,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":375.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":375.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1005.8000000715256,"responseStart":0,"secureConnectionStart":0},{"duration":553.8000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":376,"connectEnd":376,"connectStart":376,"domainLookupEnd":376,"domainLookupStart":376,"fetchStart":376,"redirectEnd":0,"redirectStart":0,"requestStart":376,"responseEnd":929.8000000715256,"responseStart":929.8000000715256,"secureConnectionStart":376},{"duration":1537.1000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":377.5,"connectEnd":377.5,"connectStart":377.5,"domainLookupEnd":377.5,"domainLookupStart":377.5,"fetchStart":377.5,"redirectEnd":0,"redirectStart":0,"requestStart":377.5,"responseEnd":1914.6000000238419,"responseStart":1914.6000000238419,"secureConnectionStart":377.5},{"duration":1538,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":377.60000002384186,"connectEnd":377.60000002384186,"connectStart":377.60000002384186,"domainLookupEnd":377.60000002384186,"domainLookupStart":377.60000002384186,"fetchStart":377.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":377.60000002384186,"responseEnd":1915.6000000238419,"responseStart":1915.6000000238419,"secureConnectionStart":377.60000002384186},{"duration":515.3999999761581,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1019.3000000715256,"connectEnd":1019.3000000715256,"connectStart":1019.3000000715256,"domainLookupEnd":1019.3000000715256,"domainLookupStart":1019.3000000715256,"fetchStart":1019.3000000715256,"redirectEnd":0,"redirectStart":0,"requestStart":1019.3000000715256,"responseEnd":1534.7000000476837,"responseStart":1534.7000000476837,"secureConnectionStart":1019.3000000715256},{"duration":625.7999999523163,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1341.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1341.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1967,"responseStart":0,"secureConnectionStart":0},{"duration":505.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1538.6000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1538.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2044.3999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":505.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1539.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1539.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2045,"responseStart":0,"secureConnectionStart":0},{"duration":459.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1540.1000000238419,"connectEnd":1540.1000000238419,"connectStart":1540.1000000238419,"domainLookupEnd":1540.1000000238419,"domainLookupStart":1540.1000000238419,"fetchStart":1540.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1540.1000000238419,"responseEnd":1999.8999999761581,"responseStart":1999.8999999761581,"secureConnectionStart":1540.1000000238419},{"duration":472.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1540.6000000238419,"connectEnd":1540.6000000238419,"connectStart":1540.6000000238419,"domainLookupEnd":1540.6000000238419,"domainLookupStart":1540.6000000238419,"fetchStart":1540.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1540.6000000238419,"responseEnd":2012.8999999761581,"responseStart":2012.8999999761581,"secureConnectionStart":1540.6000000238419},{"duration":473.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/e0bf5781d46ea69fb123572974cf39de-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1541.2000000476837,"connectEnd":1541.2000000476837,"connectStart":1541.2000000476837,"domainLookupEnd":1541.2000000476837,"domainLookupStart":1541.2000000476837,"fetchStart":1541.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1541.2000000476837,"responseEnd":2014.8000000715256,"responseStart":2014.8000000715256,"secureConnectionStart":1541.2000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":117,"responseStart":337,"responseEnd":344,"domLoading":371,"domInteractive":1973,"domContentLoadedEventStart":1973,"domContentLoadedEventEnd":2044,"domComplete":2650,"loadEventStart":2650,"loadEventEnd":2651,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1933.6000000238419},{"name":"bigPipe.sidebar-id.end","time":1935.1000000238419},{"name":"bigPipe.activity-panel-pipe-id.start","time":1935.3999999761581},{"name":"bigPipe.activity-panel-pipe-id.end","time":1936.5},{"name":"activityTabFullyLoaded","time":2069.600000023842}],"measures":[],"correlationId":"319b877096c556","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":143,"dbReadsTimeInMs":47,"dbConnsTimeInMs":60,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}