[MDEV-20813] Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' or `!newest_lsn || fil_page_get_type(page)' failed in buf_flush_init_for_writing - Jira

Elena Stepanova created issue - 2019-10-12 11:47

Elena Stepanova made changes - 2019-10-12 11:47

Field	Original Value	New Value
Labels		regression

Elena Stepanova made changes - 2019-10-12 11:47

Labels

regression

affects-tests regression

Elena Stepanova made changes - 2019-10-12 11:54

Summary

Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' failed in buf_flush_init_for_writing

Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' or `!newest_lsn || fil_page_get_type(page)' failed in buf_flush_init_for_writing

Elena Stepanova made changes - 2019-10-12 11:55

Description

_Notes:_
_The failure is not related to the weird column names in the test case, but it is related to the *length* of the names, and I don't want to invent more natural-looking long names._
_The test case uses scrubbing, I have no information whether it's strictly necessary for the failure to happen, or it is only needed for this test case._

{code:sql}
--source include/have_innodb.inc

SET GLOBAL innodb_immediate_scrub_data_uncompressed=ON;

CREATE TABLE t1 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t2 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t3 (
    pk int auto_increment,
    a varchar(257) CHARACTER SET utf8,
    b varchar(257) CHARACTER SET binary,
    c timestamp NULL DEFAULT 0,
    d bigint unsigned,
    e varchar(257) CHARACTER SET latin1,
    f tinyint,
    g tinyint unsigned,
    h bigint,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t4 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t5 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t6 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t7 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g_________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t8 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t9 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t10 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t11 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t12 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t13 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t14 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t15 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t16 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t17 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t18 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t19 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t20 (
    pk int auto_increment,
    a___________________ varchar(257) CHARACTER SET utf8,
    b_________ bigint,
    c__________ tinyint,
    d____________ timestamp NULL DEFAULT 0,
    e__________________ bigint unsigned,
    f___________________ tinyint unsigned,
    g_____________________ varchar(257) CHARACTER SET latin1,
    h_______________________ varchar(257) CHARACTER SET binary,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t21 (
    pk int,
    a_____________________ varchar(257) CHARACTER SET binary,
    b___________________ varchar(257) CHARACTER SET utf8,
    c_________ bigint,
    d____________ timestamp NULL DEFAULT 0,
    e___________________ tinyint unsigned,
    f__________________ bigint unsigned,
    g_____________________ varchar(257) CHARACTER SET latin1,
    h__________ tinyint,
    primary key (pk)
) ENGINE=InnoDB;

CREATE OR REPLACE TABLE t13 (a VARBINARY(290) DEFAULT '') ENGINE=InnoDB;

--source include/restart_mysqld.inc

# Cleanup
DROP TABLE IF EXISTS t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, t11, t12, t13, t14, t15, t16, t17, t18, t19, t20, t21;
{code}

{noformat:title=10.2 4ca0abe9}
2019-10-12 14:43:20 140683148736256 [Note] InnoDB: Starting shutdown...
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Dumping buffer pool(s) to /dev/shm/var_auto_hxN6/mysqld.1/data/ib_buffer_pool
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Instance 0, restricted to 128 pages due to innodb_buf_pool_dump_pct=25
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Buffer pool(s) dump completed at 191012 14:43:20
mysqld: /data/src/10.2/storage/innobase/buf/buf0flu.cc:859: void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t): Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' failed.
191012 14:43:21 [ERROR] mysqld got signal 6 ;

#7 0x00007ff35ebb0f12 in __GI___assert_fail (assertion=0x560f10b97130 "!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)", file=0x560f10b96c28 "/data/src/10.2/storage/innobase/buf/buf0flu.cc", line=859, function=0x560f10b98860 <buf_flush_init_for_writing(buf_block_t const*, unsigned char*, void*, unsigned long)::__PRETTY_FUNCTION__> "void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t)") at assert.c:101
#8 0x0000560f10617758 in buf_flush_init_for_writing (block=0x7ff3594e3e70, page=0x7ff359b54000 "", page_zip_=0x0, newest_lsn=1754532) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:859
#9 0x0000560f1061816f in buf_flush_write_block_low (bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1080
#10 0x0000560f106188a6 in buf_flush_page (buf_pool=0x560f13354920, bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1252
#11 0x0000560f106190f2 in buf_flush_try_neighbors (page_id=..., flush_type=BUF_FLUSH_LIST, n_flushed=261, n_to_flush=18446744073709551614) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1475
#12 0x0000560f10619433 in buf_flush_page_and_try_neighbors (bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, n_to_flush=18446744073709551614, count=0x7ff3517f99e8) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1547
#13 0x0000560f10619f25 in buf_do_flush_list_batch (buf_pool=0x560f13354920, min_n=18446744073709551614, lsn_limit=18446744073709551615) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1806
#14 0x0000560f1061a3c1 in buf_flush_batch (buf_pool=0x560f13354920, flush_type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7ff3517f9c90) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1875
#15 0x0000560f1061aa71 in buf_flush_do_batch (buf_pool=0x560f13354920, type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7ff3517f9c90) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:2045
#16 0x0000560f1061d313 in pc_flush_slot () at /data/src/10.2/storage/innobase/buf/buf0flu.cc:2853
#17 0x0000560f1061e711 in buf_flush_page_cleaner_coordinator () at /data/src/10.2/storage/innobase/buf/buf0flu.cc:3364
#18 0x00007ff3607264a4 in start_thread (arg=0x7ff3517fa700) at pthread_create.c:456
#19 0x00007ff35ec6dd0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
{noformat}

The failure appeared in 10.2 tree after this merge, but I couldn't reproduce it on the latest 10.1:
{noformat}
commit 966d97b5f9ff8673fdb1da0ce6ad51a72b62afc4
Merge: 1fd1ef25c25 c0c003beb48
Author: Marko Mäkelä
Date: Fri Oct 11 18:38:18 2019 +0300

    Merge 10.1 into 10.2
{noformat}

_Notes:_
_The failure is not related to the weird column names in the test case, but it is related to the *length* of the names, and I don't want to invent more natural-looking long names._
_The test case uses scrubbing, I have no information whether it's strictly necessary for the failure to happen, or it is only needed for this test case._

{code:sql}
--source include/have_innodb.inc

SET GLOBAL innodb_immediate_scrub_data_uncompressed=ON;

CREATE TABLE t1 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t2 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t3 (
    pk int auto_increment,
    a varchar(257) CHARACTER SET utf8,
    b varchar(257) CHARACTER SET binary,
    c timestamp NULL DEFAULT 0,
    d bigint unsigned,
    e varchar(257) CHARACTER SET latin1,
    f tinyint,
    g tinyint unsigned,
    h bigint,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t4 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t5 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t6 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g varchar(257) CHARACTER SET binary,
    h tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t7 (
    pk int,
    a bigint,
    b bigint unsigned,
    c timestamp NULL DEFAULT 0,
    d varchar(257) CHARACTER SET latin1,
    e varchar(257) CHARACTER SET utf8,
    f tinyint,
    g_________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t8 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t9 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t10 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t11 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t12 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t13 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t14 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t15 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t16 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t17 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t18 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t19 (
    pk int,
    a_____________________ bigint,
    b_____________________ bigint unsigned,
    c_____________________ timestamp NULL DEFAULT 0,
    d_____________________ varchar(257) CHARACTER SET latin1,
    e_____________________ varchar(257) CHARACTER SET utf8,
    f_____________________ tinyint,
    g_____________________ varchar(257) CHARACTER SET binary,
    h_____________________ tinyint unsigned,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t20 (
    pk int auto_increment,
    a___________________ varchar(257) CHARACTER SET utf8,
    b_________ bigint,
    c__________ tinyint,
    d____________ timestamp NULL DEFAULT 0,
    e__________________ bigint unsigned,
    f___________________ tinyint unsigned,
    g_____________________ varchar(257) CHARACTER SET latin1,
    h_______________________ varchar(257) CHARACTER SET binary,
    primary key (pk)
) ENGINE=InnoDB;

CREATE TABLE t21 (
    pk int,
    a_____________________ varchar(257) CHARACTER SET binary,
    b___________________ varchar(257) CHARACTER SET utf8,
    c_________ bigint,
    d____________ timestamp NULL DEFAULT 0,
    e___________________ tinyint unsigned,
    f__________________ bigint unsigned,
    g_____________________ varchar(257) CHARACTER SET latin1,
    h__________ tinyint,
    primary key (pk)
) ENGINE=InnoDB;

CREATE OR REPLACE TABLE t13 (a VARBINARY(290) DEFAULT '') ENGINE=InnoDB;

--source include/restart_mysqld.inc

# Cleanup
DROP TABLE IF EXISTS t1, t2, t3, t4, t5, t6, t7, t8, t9, t10, t11, t12, t13, t14, t15, t16, t17, t18, t19, t20, t21;
{code}

{noformat:title=10.2 4ca0abe9}
2019-10-12 14:43:20 140683148736256 [Note] InnoDB: Starting shutdown...
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Dumping buffer pool(s) to /dev/shm/var_auto_hxN6/mysqld.1/data/ib_buffer_pool
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Instance 0, restricted to 128 pages due to innodb_buf_pool_dump_pct=25
2019-10-12 14:43:20 140682576516864 [Note] InnoDB: Buffer pool(s) dump completed at 191012 14:43:20
mysqld: /data/src/10.2/storage/innobase/buf/buf0flu.cc:859: void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t): Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' failed.
191012 14:43:21 [ERROR] mysqld got signal 6 ;

#7 0x00007ff35ebb0f12 in __GI___assert_fail (assertion=0x560f10b97130 "!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)", file=0x560f10b96c28 "/data/src/10.2/storage/innobase/buf/buf0flu.cc", line=859, function=0x560f10b98860 <buf_flush_init_for_writing(buf_block_t const*, unsigned char*, void*, unsigned long)::__PRETTY_FUNCTION__> "void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t)") at assert.c:101
#8 0x0000560f10617758 in buf_flush_init_for_writing (block=0x7ff3594e3e70, page=0x7ff359b54000 "", page_zip_=0x0, newest_lsn=1754532) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:859
#9 0x0000560f1061816f in buf_flush_write_block_low (bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1080
#10 0x0000560f106188a6 in buf_flush_page (buf_pool=0x560f13354920, bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1252
#11 0x0000560f106190f2 in buf_flush_try_neighbors (page_id=..., flush_type=BUF_FLUSH_LIST, n_flushed=261, n_to_flush=18446744073709551614) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1475
#12 0x0000560f10619433 in buf_flush_page_and_try_neighbors (bpage=0x7ff3594e3e70, flush_type=BUF_FLUSH_LIST, n_to_flush=18446744073709551614, count=0x7ff3517f99e8) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1547
#13 0x0000560f10619f25 in buf_do_flush_list_batch (buf_pool=0x560f13354920, min_n=18446744073709551614, lsn_limit=18446744073709551615) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1806
#14 0x0000560f1061a3c1 in buf_flush_batch (buf_pool=0x560f13354920, flush_type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7ff3517f9c90) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:1875
#15 0x0000560f1061aa71 in buf_flush_do_batch (buf_pool=0x560f13354920, type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7ff3517f9c90) at /data/src/10.2/storage/innobase/buf/buf0flu.cc:2045
#16 0x0000560f1061d313 in pc_flush_slot () at /data/src/10.2/storage/innobase/buf/buf0flu.cc:2853
#17 0x0000560f1061e711 in buf_flush_page_cleaner_coordinator () at /data/src/10.2/storage/innobase/buf/buf0flu.cc:3364
#18 0x00007ff3607264a4 in start_thread (arg=0x7ff3517fa700) at pthread_create.c:456
#19 0x00007ff35ec6dd0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
{noformat}

The failure appeared in 10.2 tree after this merge, but I couldn't reproduce it on the latest 10.1:
{noformat}
commit 966d97b5f9ff8673fdb1da0ce6ad51a72b62afc4
Merge: 1fd1ef25c25 c0c003beb48
Author: Marko Mäkelä
Date: Fri Oct 11 18:38:18 2019 +0300

    Merge 10.1 into 10.2
{noformat}

{noformat:title=10.3 8e3d85e1}
mysqld: /data/src/10.3/storage/innobase/buf/buf0flu.cc:860: void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t): Assertion `!newest_lsn || fil_page_get_type(page)' failed.
191012 14:53:33 [ERROR] mysqld got signal 6 ;

#7 0x00007f2e0746cf12 in __GI___assert_fail (assertion=0x564d97ac50f0 "!newest_lsn || fil_page_get_type(page)", file=0x564d97ac4c28 "/data/src/10.3/storage/innobase/buf/buf0flu.cc", line=860, function=0x564d97ac68a0 <buf_flush_init_for_writing(buf_block_t const*, unsigned char*, void*, unsigned long)::__PRETTY_FUNCTION__> "void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t)") at assert.c:101
#8 0x0000564d97423f3c in buf_flush_init_for_writing (block=0x7f2e00aee0e0, page=0x7f2e01148000 "", page_zip_=0x0, newest_lsn=1768116) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:860
#9 0x0000564d97424d56 in buf_flush_write_block_low (bpage=0x7f2e00aee0e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1082
#10 0x0000564d974258ed in buf_flush_page (buf_pool=0x564d995f7a10, bpage=0x7f2e00aee0e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1254
#11 0x0000564d97426333 in buf_flush_try_neighbors (page_id=..., flush_type=BUF_FLUSH_LIST, n_flushed=261, n_to_flush=18446744073709551614) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1477
#12 0x0000564d974266b7 in buf_flush_page_and_try_neighbors (bpage=0x7f2e00aee0e0, flush_type=BUF_FLUSH_LIST, n_to_flush=18446744073709551614, count=0x7f2df8ff89d8) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1549
#13 0x0000564d974274a0 in buf_do_flush_list_batch (buf_pool=0x564d995f7a10, min_n=18446744073709551614, lsn_limit=18446744073709551615) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1808
#14 0x0000564d97427b1b in buf_flush_batch (buf_pool=0x564d995f7a10, flush_type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7f2df8ff8c90) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:1878
#15 0x0000564d974282f5 in buf_flush_do_batch (buf_pool=0x564d995f7a10, type=BUF_FLUSH_LIST, min_n=18446744073709551614, lsn_limit=18446744073709551615, n=0x7f2df8ff8c90) at /data/src/10.3/storage/innobase/buf/buf0flu.cc:2036
#16 0x0000564d9742b108 in pc_flush_slot () at /data/src/10.3/storage/innobase/buf/buf0flu.cc:2835
#17 0x0000564d9742c737 in buf_flush_page_cleaner_coordinator () at /data/src/10.3/storage/innobase/buf/buf0flu.cc:3339
#18 0x00007f2e08fe24a4 in start_thread (arg=0x7f2df8ff9700) at pthread_create.c:456
#19 0x00007f2e07529d0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
{noformat}

Elena Stepanova made changes - 2019-10-12 11:55

Fix Version/s		10.3 [ 22126 ]
Affects Version/s		10.3 [ 22126 ]

Marko Mäkelä made changes - 2019-10-12 12:22

Link

This issue relates to ~~MDEV-20805~~ [ ~~MDEV-20805~~ ]

Marko Mäkelä made changes - 2019-10-12 12:22

Link

This issue relates to ~~MDEV-8139~~ [ ~~MDEV-8139~~ ]

Marko Mäkelä made changes - 2019-10-12 12:22

Link

This issue relates to ~~MDEV-15528~~ [ ~~MDEV-15528~~ ]

Marko Mäkelä added a comment - 2019-10-12 12:22

Sorry, it turns out that the check that I added when merging the fix of ~~MDEV-20805~~ is a bogus one.

The page scrubbing is indeed writing zeroed pages (with the exception of the page number and tablespace identifier) to data files. Here is where the pages will be cleared:

	if (srv_immediate_scrub_data_uncompressed) {

		/* In MDEV-15528 this call must be removed, and we should

		zero out the page after the redo log for this mini-transaction

		has been durably written. */

		fsp_init_file_page(fil_space_get(index->space), block, mtr);

Thus, the assertion that I added is bogus and must be removed. We should reinstate it in ~~MDEV-15528~~, where I think that we should provide three options:

do not touch freed pages (the current default)
write them out as all-zero (the scrubbing variant), or
punch holes for freed page ranges

Scrubbing in its current form has problems, and tests are disabled, as noted in ~~MDEV-8139~~. The current implementation would be replaced in ~~MDEV-15528~~.

Marko Mäkelä added a comment - 2019-10-12 12:22 Sorry, it turns out that the check that I added when merging the fix of MDEV-20805 is a bogus one. The page scrubbing is indeed writing zeroed pages (with the exception of the page number and tablespace identifier) to data files. Here is where the pages will be cleared: if (srv_immediate_scrub_data_uncompressed) { /* In MDEV-15528 this call must be removed, and we should zero out the page after the redo log for this mini-transaction has been durably written. */ fsp_init_file_page(fil_space_get(index->space), block, mtr); } Thus, the assertion that I added is bogus and must be removed. We should reinstate it in MDEV-15528 , where I think that we should provide three options: do not touch freed pages (the current default) write them out as all-zero (the scrubbing variant), or punch holes for freed page ranges Scrubbing in its current form has problems, and tests are disabled, as noted in MDEV-8139 . The current implementation would be replaced in MDEV-15528 .

Marko Mäkelä made changes - 2019-10-12 12:37

issue.field.resolutiondate

2019-10-12 12:37:02.0

2019-10-12 12:37:02.228

Marko Mäkelä made changes - 2019-10-12 12:37

Fix Version/s		10.2.28 [ 23910 ]
Fix Version/s		10.3.19 [ 23908 ]
Fix Version/s		10.4.9 [ 23906 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2019-10-12 12:47

Fix Version/s

10.4.9 [ 23906 ]

Elena Stepanova added a comment - 2019-10-14 08:00 - edited

Here is a variation on 10.1 with encryption upon upgrade from 10.0, still exists:

10.1 2ae02c29
2019-10-14 10:56:51 7f959b3ff700 InnoDB: Assertion failure in thread 140280531515136 in file buf0flu.cc line 790
InnoDB: Failing assertion: !newest_lsn \|\| fil_page_get_type(page)

#5 0x00007f95c403f42a in __GI_abort () at abort.c:89
#6 0x0000562211a811a0 in buf_flush_init_for_writing (page=0x7f95b0588000 "˵?\005", page_zip_=0x0, newest_lsn=1616908) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:790
#7 0x0000562211a81773 in buf_flush_write_block_low (bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:961
#8 0x0000562211a81d9e in buf_flush_page (buf_pool=0x7f95c388d878, bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1141
#9 0x0000562211a8237a in buf_flush_try_neighbors (space=0, offset=13, flush_type=BUF_FLUSH_LIST, n_flushed=11, n_to_flush=100) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1355
#10 0x0000562211a8267a in buf_flush_page_and_try_neighbors (bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, n_to_flush=100, count=0x7f959b3feae8) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1443
#11 0x0000562211a83185 in buf_do_flush_list_batch (buf_pool=0x7f95c388d878, min_n=100, lsn_limit=18446744073709551615) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1772
#12 0x0000562211a834df in buf_flush_batch (buf_pool=0x7f95c388d878, flush_type=BUF_FLUSH_LIST, min_n=100, lsn_limit=18446744073709551615, limited_lru_scan=false, n=0x7f959b3febc0) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1848
#13 0x0000562211a83c3b in buf_flush_list (min_n=200, lsn_limit=18446744073709551615, n_processed=0x7f959b3fee48) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2129
#14 0x0000562211a84822 in page_cleaner_do_flush_batch (n_to_flush=200, lsn_limit=18446744073709551615) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2444
#15 0x0000562211a85a0b in buf_flush_page_cleaner_thread (arg=0x0) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2841
#16 0x00007f95c56dd4a4 in start_thread (arg=0x7f959b3ff700) at pthread_create.c:456
#17 0x00007f95c40f3d0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

To reproduce, start 10.1 with encryption on a freshly bootstrapped 10.0 datadir. For 10.0 all defaults will do, 10.1 encryption options are e.g.

--innodb-encrypt-tables --innodb-encrypt-log --innodb-encryption-threads=4  --file-key-management --file-key-management-filename=`pwd`/mysql-test/std_data/keys.txt --plugin-load-add=file_key_management

En example of 10.0 datadir is attached as data-10.0.tar.gz

Elena Stepanova added a comment - 2019-10-14 08:00 - edited Here is a variation on 10.1 with encryption upon upgrade from 10.0, still exists: 10.1 2ae02c29 2019-10-14 10:56:51 7f959b3ff700 InnoDB: Assertion failure in thread 140280531515136 in file buf0flu.cc line 790 InnoDB: Failing assertion: !newest_lsn || fil_page_get_type(page) #5 0x00007f95c403f42a in __GI_abort () at abort.c:89 #6 0x0000562211a811a0 in buf_flush_init_for_writing (page=0x7f95b0588000 "˵?\005", page_zip_=0x0, newest_lsn=1616908) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:790 #7 0x0000562211a81773 in buf_flush_write_block_low (bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:961 #8 0x0000562211a81d9e in buf_flush_page (buf_pool=0x7f95c388d878, bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1141 #9 0x0000562211a8237a in buf_flush_try_neighbors (space=0, offset=13, flush_type=BUF_FLUSH_LIST, n_flushed=11, n_to_flush=100) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1355 #10 0x0000562211a8267a in buf_flush_page_and_try_neighbors (bpage=0x7f95a87ce510, flush_type=BUF_FLUSH_LIST, n_to_flush=100, count=0x7f959b3feae8) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1443 #11 0x0000562211a83185 in buf_do_flush_list_batch (buf_pool=0x7f95c388d878, min_n=100, lsn_limit=18446744073709551615) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1772 #12 0x0000562211a834df in buf_flush_batch (buf_pool=0x7f95c388d878, flush_type=BUF_FLUSH_LIST, min_n=100, lsn_limit=18446744073709551615, limited_lru_scan=false, n=0x7f959b3febc0) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:1848 #13 0x0000562211a83c3b in buf_flush_list (min_n=200, lsn_limit=18446744073709551615, n_processed=0x7f959b3fee48) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2129 #14 0x0000562211a84822 in page_cleaner_do_flush_batch (n_to_flush=200, lsn_limit=18446744073709551615) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2444 #15 0x0000562211a85a0b in buf_flush_page_cleaner_thread (arg=0x0) at /data/src/10.1/storage/xtradb/buf/buf0flu.cc:2841 #16 0x00007f95c56dd4a4 in start_thread (arg=0x7f959b3ff700) at pthread_create.c:456 #17 0x00007f95c40f3d0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97 To reproduce, start 10.1 with encryption on a freshly bootstrapped 10.0 datadir. For 10.0 all defaults will do, 10.1 encryption options are e.g. --innodb-encrypt-tables --innodb-encrypt-log --innodb-encryption-threads=4 --file-key-management --file-key-management-filename=`pwd`/mysql-test/std_data/keys.txt --plugin-load-add=file_key_management En example of 10.0 datadir is attached as data-10.0.tar.gz

Elena Stepanova made changes - 2019-10-14 08:00

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Elena Stepanova made changes - 2019-10-14 08:00

Attachment

data-10.0.tar.gz [ 49236 ]

Elena Stepanova made changes - 2019-10-14 08:01

Affects Version/s

10.1 [ 16100 ]

Marko Mäkelä added a comment - 2019-10-14 10:03

The function fil_crypt_rotate_page() was checking for empty pages by determining if FIL_PAGE_OFFSET is 0. It would be better to check for FIL_PAGE_TYPE being 0. In data-10.0.tar.gz, page 13 in the system tablespace is mostly filled with NUL bytes, except for some header and trailer fields.

Marko Mäkelä added a comment - 2019-10-14 10:03 The function fil_crypt_rotate_page() was checking for empty pages by determining if FIL_PAGE_OFFSET is 0. It would be better to check for FIL_PAGE_TYPE being 0. In data-10.0.tar.gz , page 13 in the system tablespace is mostly filled with NUL bytes, except for some header and trailer fields.

Elena Stepanova added a comment - 2019-10-14 12:26

On upgrade from 5.5 to 10.4. Same approach, only with 5.5 you need to create at least one table.

bootstrap 5.5
start 5.5 with all defaults
run CREATE TABLE t1 (a INT);
stop 5.5
start 10.4 with encryption options --innodb-encrypt-tables --innodb-encrypt-log --innodb-encryption-threads=4 --file-key-management --file-key-management-filename=`pwd`/mysql-test/std_data/keys.txt --plugin-load-add=file_key_management
=> observe the crash.

An example of 5.5 directory is attached as data-5.5.tar.gz.

10.4 899c843f
mysqld: /data/src/10.4/storage/innobase/buf/buf0flu.cc:793: void buf_flush_init_for_writing(const buf_block_t, byte, void*, lsn_t, bool): Assertion `!newest_lsn \|\| fil_page_get_type(page)' failed.
191014 15:22:45 [ERROR] mysqld got signal 6 ;

#7 0x00007fda884e3f12 in __GI___assert_fail (assertion=0x55a68618c730 "!newest_lsn \|\| fil_page_get_type(page)", file=0x55a68618c2a0 "/data/src/10.4/storage/innobase/buf/buf0flu.cc", line=793, function=0x55a68618dec0 <buf_flush_init_for_writing(buf_block_t const, unsigned char, void, unsigned long, bool)::__PRETTY_FUNCTION__> "void buf_flush_init_for_writing(const buf_block_t, byte, void, lsn_t, bool)") at assert.c:101
#8 0x000055a685a76055 in buf_flush_init_for_writing (block=0x7fda6402a4e0, page=0x7fda6490c000 "\226F\033@", page_zip_=0x0, newest_lsn=1609370, use_full_checksum=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:793
#9 0x000055a685a76efd in buf_flush_write_block_low (bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1035
#10 0x000055a685a77aa1 in buf_flush_page (buf_pool=0x55a687ca36d0, bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1210
#11 0x000055a685a7852d in buf_flush_try_neighbors (page_id=..., flush_type=BUF_FLUSH_LIST, n_flushed=137, n_to_flush=200) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1436
#12 0x000055a685a788b3 in buf_flush_page_and_try_neighbors (bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, n_to_flush=200, count=0x7fda5eff89d8) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1510
#13 0x000055a685a79673 in buf_do_flush_list_batch (buf_pool=0x55a687ca36d0, min_n=200, lsn_limit=18446744073709551615) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1769
#14 0x000055a685a79ce1 in buf_flush_batch (buf_pool=0x55a687ca36d0, flush_type=BUF_FLUSH_LIST, min_n=200, lsn_limit=18446744073709551615, n=0x7fda5eff8c90) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1839
#15 0x000055a685a7a4cb in buf_flush_do_batch (buf_pool=0x55a687ca36d0, type=BUF_FLUSH_LIST, min_n=200, lsn_limit=18446744073709551615, n=0x7fda5eff8c90) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1997
#16 0x000055a685a7a7bd in buf_flush_lists (min_n=200, lsn_limit=18446744073709551615, n_processed=0x7fda5eff8ce8) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:2099
#17 0x000055a685a7e70b in buf_flush_page_cleaner_coordinator () at /data/src/10.4/storage/innobase/buf/buf0flu.cc:3255
#18 0x00007fda8a0594a4 in start_thread (arg=0x7fda5eff9700) at pthread_create.c:456
#19 0x00007fda885a0d0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

Elena Stepanova added a comment - 2019-10-14 12:26 On upgrade from 5.5 to 10.4. Same approach, only with 5.5 you need to create at least one table. bootstrap 5.5 start 5.5 with all defaults run CREATE TABLE t1 (a INT); stop 5.5 start 10.4 with encryption options --innodb-encrypt-tables --innodb-encrypt-log --innodb-encryption-threads=4 --file-key-management --file-key-management-filename=`pwd`/mysql-test/std_data/keys.txt --plugin-load-add=file_key_management => observe the crash. An example of 5.5 directory is attached as data-5.5.tar.gz . 10.4 899c843f mysqld: /data/src/10.4/storage/innobase/buf/buf0flu.cc:793: void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t, bool): Assertion `!newest_lsn || fil_page_get_type(page)' failed. 191014 15:22:45 [ERROR] mysqld got signal 6 ; #7 0x00007fda884e3f12 in __GI___assert_fail (assertion=0x55a68618c730 "!newest_lsn || fil_page_get_type(page)", file=0x55a68618c2a0 "/data/src/10.4/storage/innobase/buf/buf0flu.cc", line=793, function=0x55a68618dec0 <buf_flush_init_for_writing(buf_block_t const*, unsigned char*, void*, unsigned long, bool)::__PRETTY_FUNCTION__> "void buf_flush_init_for_writing(const buf_block_t*, byte*, void*, lsn_t, bool)") at assert.c:101 #8 0x000055a685a76055 in buf_flush_init_for_writing (block=0x7fda6402a4e0, page=0x7fda6490c000 "\226F\033@", page_zip_=0x0, newest_lsn=1609370, use_full_checksum=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:793 #9 0x000055a685a76efd in buf_flush_write_block_low (bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1035 #10 0x000055a685a77aa1 in buf_flush_page (buf_pool=0x55a687ca36d0, bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, sync=false) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1210 #11 0x000055a685a7852d in buf_flush_try_neighbors (page_id=..., flush_type=BUF_FLUSH_LIST, n_flushed=137, n_to_flush=200) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1436 #12 0x000055a685a788b3 in buf_flush_page_and_try_neighbors (bpage=0x7fda6402a4e0, flush_type=BUF_FLUSH_LIST, n_to_flush=200, count=0x7fda5eff89d8) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1510 #13 0x000055a685a79673 in buf_do_flush_list_batch (buf_pool=0x55a687ca36d0, min_n=200, lsn_limit=18446744073709551615) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1769 #14 0x000055a685a79ce1 in buf_flush_batch (buf_pool=0x55a687ca36d0, flush_type=BUF_FLUSH_LIST, min_n=200, lsn_limit=18446744073709551615, n=0x7fda5eff8c90) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1839 #15 0x000055a685a7a4cb in buf_flush_do_batch (buf_pool=0x55a687ca36d0, type=BUF_FLUSH_LIST, min_n=200, lsn_limit=18446744073709551615, n=0x7fda5eff8c90) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:1997 #16 0x000055a685a7a7bd in buf_flush_lists (min_n=200, lsn_limit=18446744073709551615, n_processed=0x7fda5eff8ce8) at /data/src/10.4/storage/innobase/buf/buf0flu.cc:2099 #17 0x000055a685a7e70b in buf_flush_page_cleaner_coordinator () at /data/src/10.4/storage/innobase/buf/buf0flu.cc:3255 #18 0x00007fda8a0594a4 in start_thread (arg=0x7fda5eff9700) at pthread_create.c:456 #19 0x00007fda885a0d0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

Elena Stepanova made changes - 2019-10-14 12:27

Attachment

data-5.5.tar.gz [ 49241 ]

Marko Mäkelä added a comment - 2019-10-14 14:33

I removed the assertion from 10.1. In 10.2 and later, I adjusted fil_crypt_rotate_page() so that it will skip key rotation on pages where both the key_version and FIL_PAGE_TYPE fields are 0. Previously, it was checking FIL_PAGE_OFFSET.

Starting with 10.2, buf_flush_init_for_writing() will initialize FIL_PAGE_TYPE when pages that were originally created in old InnoDB versions are modified. The debug assertion would fail before that happens, but I hope that we can live with that.

Marko Mäkelä added a comment - 2019-10-14 14:33 I removed the assertion from 10.1. In 10.2 and later, I adjusted fil_crypt_rotate_page() so that it will skip key rotation on pages where both the key_version and FIL_PAGE_TYPE fields are 0. Previously, it was checking FIL_PAGE_OFFSET . Starting with 10.2, buf_flush_init_for_writing() will initialize FIL_PAGE_TYPE when pages that were originally created in old InnoDB versions are modified. The debug assertion would fail before that happens, but I hope that we can live with that.

Marko Mäkelä made changes - 2019-10-14 14:33

Component/s		Storage Engine - XtraDB [ 10135 ]
Fix Version/s		10.1.42 [ 23407 ]

Marko Mäkelä made changes - 2019-10-14 14:35

Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:50

Workflow

MariaDB v3 [ 100376 ]

MariaDB v4 [ 156854 ]

Rob Schwyzer (Inactive) made changes - 2022-01-06 19:23

Remote Link

This issue links to "Page (MariaDB Confluence)" [ 32698 ]

Jira Automation (IT) made changes - 2024-07-04 03:32

Zendesk Related Tickets		201658
Zendesk active tickets		201658

MariaDB Server

Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' or `!newest_lsn || fil_page_get_type(page)' failed in buf_flush_init_for_writing

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration