[MDEV-20805] ibuf_add_free_page() is not initializing FIL_PAGE_TYPE first - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
Fix Version/s: 10.2.28, 5.5.66, 10.1.42, 10.3.19, 10.4.9, 10.5.0
Component/s: Storage Engine - InnoDB, Storage Engine - XtraDB
Labels:
- recovery

Description

In the function recv_parse_or_apply_log_rec_body() there are debug checks for validating the state of the page when redo log records are being applied. Most notably, FIL_PAGE_TYPE should be set before anything else is being written to the page.

The function ibuf_add_free_page() is violating this by invoking flst_add_last() before setting FIL_PAGE_TYPE. This bug was noticed during the testing of ~~MDEV-19514~~.

Attachments

Issue Links

blocks

MDEV-19514 Defer change buffer merge until pages are requested

Closed

relates to

MDEV-20813 Assertion `!srv_safe_truncate || !newest_lsn || fil_page_get_type(page)' or `!newest_lsn || fil_page_get_type(page)' failed in buf_flush_init_for_writing

Closed

Activity

Ascending order - Click to sort in descending order

Marko Mäkelä created issue - 2019-10-11 11:11

Marko Mäkelä made changes - 2019-10-11 11:11

Field	Original Value	New Value
Link		This issue blocks ~~MDEV-19514~~ [ ~~MDEV-19514~~ ]

Marko Mäkelä made changes - 2019-10-11 11:15

issue.field.resolutiondate

2019-10-11 11:15:11.0

2019-10-11 11:15:11.017

Marko Mäkelä made changes - 2019-10-11 11:15

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Marko Mäkelä added a comment - 2019-10-11 12:56

To 10.1, I pushed an additional change that asserts that when flushing pages, the FIL_PAGE_TYPE will be set. The doublewrite buffer creation during bootstrap is violating that, but I added an extra initialization for debug builds.

All in all, this should not impact non-debug builds at all. For release builds, we are slightly changing the order of redo log records in the mini-transaction of ibuf_add_free_page(). The volume of written redo log should remain unchanged.

Marko Mäkelä added a comment - 2019-10-11 12:56 To 10.1, I pushed an additional change that asserts that when flushing pages, the FIL_PAGE_TYPE will be set. The doublewrite buffer creation during bootstrap is violating that, but I added an extra initialization for debug builds. All in all, this should not impact non-debug builds at all. For release builds, we are slightly changing the order of redo log records in the mini-transaction of ibuf_add_free_page() . The volume of written redo log should remain unchanged.

Marko Mäkelä made changes - 2019-10-12 12:22

Link

This issue relates to ~~MDEV-20813~~ [ ~~MDEV-20813~~ ]

Sergei Golubchik made changes - 2021-12-06 21:50

Workflow

MariaDB v3 [ 100352 ]

MariaDB v4 [ 156849 ]

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2019-10-11 11:11

Updated:: 2019-10-12 12:28

Resolved:: 2019-10-11 11:15

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server