[MDEV-18016] Assertion failure in dict_table_check_for_dup_indexes / ha_innobase::commit_inplace_alter_table upon ADD FOREIGN KEY or ADD FULLTEXT - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL)
Fix Version/s: 10.4.3, 10.1.38, 10.0.38, 10.2.22, 10.3.13
Component/s: Full-text Search, Storage Engine - InnoDB, Storage Engine - XtraDB
Labels:
- affects-tests

Description

Note: See also ~~MDEV-15329~~, ~~MDEV-18017~~, ~~MDEV-18020~~

--source include/have_innodb.inc

CREATE TABLE t1 (f VARCHAR(256)) ENGINE=InnoDB;

SET SESSION FOREIGN_KEY_CHECKS= OFF ;

ALTER TABLE t1 ADD FOREIGN KEY (f) REFERENCES non_existing_table (x);

ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f);

ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f);

# Cleanup

DROP TABLE t1;

On 10.2+ debug builds:

10.2 0a2edddbf4
2018-12-16 20:41:54 0x7ff6a84ff700 InnoDB: Assertion failure in file /data/src/10.2/storage/innobase/dict/dict0dict.cc line 6346

#6 0x000055acb002a1f2 in ut_dbg_assertion_failed (expr=0x0, file=0x55acb061a290 "/data/src/10.2/storage/innobase/dict/dict0dict.cc", line=6346) at /data/src/10.2/storage/innobase/ut/ut0dbg.cc:60
#7 0x000055acb00deff9 in dict_table_check_for_dup_indexes (table=0x7ff65009aa78, check=CHECK_ALL_COMPLETE) at /data/src/10.2/storage/innobase/dict/dict0dict.cc:6346
#8 0x000055acafe5cf98 in ha_innobase::commit_inplace_alter_table (this=0x7ff6500a9368, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, commit=true) at /data/src/10.2/storage/innobase/handler/handler0alter.cc:9015
#9 0x000055acafc181e6 in handler::ha_commit_inplace_alter_table (this=0x7ff6500a9368, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, commit=true) at /data/src/10.2/sql/handler.cc:4231
#10 0x000055acafa67818 in mysql_inplace_alter_table (thd=0x7ff650000d60, table_list=0x7ff6500127a8, table=0x7ff65009ee00, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7ff6a84fb640, alter_ctx=0x7ff6a84fc200) at /data/src/10.2/sql/sql_table.cc:7391
#11 0x000055acafa6cd14 in mysql_alter_table (thd=0x7ff650000d60, new_db=0x7ff650012db8 "test", new_name=0x0, create_info=0x7ff6a84fce20, table_list=0x7ff6500127a8, alter_info=0x7ff6a84fcd70, order_num=0, order=0x0, ignore=false) at /data/src/10.2/sql/sql_table.cc:9390
#12 0x000055acafae753a in Sql_cmd_alter_table::execute (this=0x7ff650012e88, thd=0x7ff650000d60) at /data/src/10.2/sql/sql_alter.cc:323
#13 0x000055acaf99fd22 in mysql_execute_command (thd=0x7ff650000d60) at /data/src/10.2/sql/sql_parse.cc:6227
#14 0x000055acaf9a4e6e in mysql_parse (thd=0x7ff650000d60, rawbuf=0x7ff6500126a8 "ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f)", length=41, parser_state=0x7ff6a84fe1e0, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:8014
#15 0x000055acaf9924ef in dispatch_command (command=COM_QUERY, thd=0x7ff650000d60, packet=0x7ff650008b01 "ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f)", packet_length=41, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:1824
#16 0x000055acaf990e8d in do_command (thd=0x7ff650000d60) at /data/src/10.2/sql/sql_parse.cc:1378
#17 0x000055acafae2201 in do_handle_one_connection (connect=0x55acb2483ec0) at /data/src/10.2/sql/sql_connect.cc:1335
#18 0x000055acafae1f81 in handle_one_connection (arg=0x55acb2483ec0) at /data/src/10.2/sql/sql_connect.cc:1241
#19 0x000055acb03139db in pfs_spawn_thread (arg=0x55acb278e1d0) at /data/src/10.2/storage/perfschema/pfs.cc:1862
#20 0x00007ff6aec1b6db in start_thread (arg=0x7ff6a84ff700) at pthread_create.c:463
#21 0x00007ff6ae00588f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Non-debug build doesn't crash, it produces errors:

10.3 non-debug 5fefcb0a21
2018-12-16 20:49:53 9 [ERROR] Cannot find index ft2 in InnoDB index dictionary.
2018-12-16 20:49:53 9 [ERROR] InnoDB indexes are inconsistent with what defined in .frm for table ./test/t1
2018-12-16 20:49:53 9 [ERROR] InnoDB could not find key no 1 with name ft2 from dict cache for table test/t1
2018-12-16 20:49:53 9 [ERROR] InnoDB: Table test/t1 contains 2 indexes inside InnoDB, which is different from the number of indexes 2 defined in the MariaDB Have you mixed up .frm files from different installations? See http://dev.mysql.com/doc/refman/5.7/en/innodb-troubleshooting.html

On 10.0 and 10.1 the failure looks a bit different, it happens on the first ADD INDEX already:

10.0 1a7158b88a1
181216 20:47:30 [ERROR] InnoDB: dict_load_foreigns() returned 38 for ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f)
2018-12-16 20:47:30 7fa9d47c7700 InnoDB: Assertion failure in thread 140367391127296 in file handler0alter.cc line 6047
InnoDB: Failing assertion: 0

#5 0x00007fa9d2e39801 in __GI_abort () at abort.c:79
#6 0x00005638084084a0 in ha_innobase::commit_inplace_alter_table (this=0x7fa9be880088, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, commit=true) at /data/src/10.0/storage/xtradb/handler/handler0alter.cc:6047
#7 0x000056380809b6f8 in handler::ha_commit_inplace_alter_table (this=0x7fa9be880088, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, commit=true) at /data/src/10.0/sql/handler.cc:4228
#8 0x0000563807f4570c in mysql_inplace_alter_table (thd=0x7fa9c7a0c070, table_list=0x7fa9be9a2188, table=0x7fa9be89e470, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7fa9d47c3a70, alter_ctx=0x7fa9d47c4200) at /data/src/10.0/sql/sql_table.cc:7176
#9 0x0000563807f4a118 in mysql_alter_table (thd=0x7fa9c7a0c070, new_db=0x7fa9be9a2768 "test", new_name=0x0, create_info=0x7fa9d47c52c0, table_list=0x7fa9be9a2188, alter_info=0x7fa9d47c5230, order_num=0, order=0x0, ignore=false) at /data/src/10.0/sql/sql_table.cc:8980
#10 0x0000563807fbb1e6 in Sql_cmd_alter_table::execute (this=0x7fa9be9a2838, thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_alter.cc:306
#11 0x0000563807e8b622 in mysql_execute_command (thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_parse.cc:5118
#12 0x0000563807e8f21b in mysql_parse (thd=0x7fa9c7a0c070, rawbuf=0x7fa9be9a2088 "ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f)", length=41, parser_state=0x7fa9d47c6660) at /data/src/10.0/sql/sql_parse.cc:6637
#13 0x0000563807e8111f in dispatch_command (command=COM_QUERY, thd=0x7fa9c7a0c070, packet=0x7fa9cc91e071 "ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f)", packet_length=41) at /data/src/10.0/sql/sql_parse.cc:1300
#14 0x0000563807e803d3 in do_command (thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_parse.cc:1003
#15 0x0000563807fb63be in do_handle_one_connection (thd_arg=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_connect.cc:1377
#16 0x0000563807fb610d in handle_one_connection (arg=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_connect.cc:1292
#17 0x00005638083c6304 in pfs_spawn_thread (arg=0x7fa9c773cf70) at /data/src/10.0/storage/perfschema/pfs.cc:1861
#18 0x00007fa9d39186db in start_thread (arg=0x7fa9d47c7700) at pthread_create.c:463
#19 0x00007fa9d2f1a88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Attachments

Issue Links

duplicates

MDEV-15329 [Draft] InnoDB: Assertion failure in dict_table_check_for_dup_indexes()

Closed

is duplicated by

MDEV-16654 InnoDB: dict_load_foreigns() returned 38 and Failing assertion: 0 in ha_innodb::commit_inplace_alter_table

Closed

MDEV-18321 Server crash or Failing assertion: 0 in ha_innodb::commit_inplace_alter_table upon adding virtual column

Closed

relates to

MDEV-18047 Crash in dict_foreign_qualify_index or Assertion `index->magic_n == 76789786' or Assertion `pos < index->n_def' failed in dict_index_get_nth_field

Confirmed

MDEV-18017 Assertion `!index->to_be_dropped' or Failing assertion: 0 in ha_innobase::commit_inplace_alter_table upon DROP fulltext INDEX

Closed

MDEV-18020 Failing assertion: !prebuilt->trx->check_foreigns and its variations upon mixing FULLTEXT and FOREIGN KEYs

Closed

(1 relates to)

Activity

Ascending order - Click to sort in descending order

Elena Stepanova created issue - 2018-12-15 14:24

Elena Stepanova made changes - 2018-12-15 14:28

Field	Original Value	New Value
Description	_Note: Might be related to ~~MDEV-15329~~_ https://travis-ci.org/elenst/travis-tests/jobs/467803822 {noformat:title=10.2 e3dda3d95ee4c09c2ed45ce886ecd25d1fc1ae92} 2018-12-14 08:07:53 0x7f55e4cdc700 InnoDB: Assertion failure in file /home/travis/src/storage/innobase/dict/dict0dict.cc line 6346 #5 0x00007f55edede02a in abort () from /lib/x86_64-linux-gnu/libc.so.6 #6 0x00005595bb5df7a7 in ut_dbg_assertion_failed (expr=0x0, file=0x5595bbbfb1a8 "/home/travis/src/storage/innobase/dict/dict0dict.cc", line=6346) at /home/travis/src/storage/innobase/ut/ut0dbg.cc:60 #7 0x00005595bb694141 in dict_table_check_for_dup_indexes (table=0x5595beefdeb8, check=CHECK_ALL_COMPLETE) at /home/travis/src/storage/innobase/dict/dict0dict.cc:6346 #8 0x00005595bb41118b in ha_innobase::commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/storage/innobase/handler/handler0alter.cc:9016 #9 0x00005595bb1c7f41 in handler::ha_commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/sql/handler.cc:4231 #10 0x00005595bb015dd8 in mysql_inplace_alter_table (thd=0x7f55e0094120, table_list=0x7f55e00a7bf8, table=0x5595bf432520, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, inplace_supported=HA_ALTER_INPLACE_NO_LOCK_AFTER_PREPARE, target_mdl_request=0x7f55e4cd86d0, alter_ctx=0x7f55e4cd9290) at /home/travis/src/sql/sql_table.cc:7391 #11 0x00005595bb01b2f1 in mysql_alter_table (thd=0x7f55e0094120, new_db=0x7f55e00a8208 "test", new_name=0x0, create_info=0x7f55e4cd9ea0, table_list=0x7f55e00a7bf8, alter_info=0x7f55e4cd9df0, order_num=0, order=0x0, ignore=false) at /home/travis/src/sql/sql_table.cc:9390 #12 0x00005595bb0963bc in Sql_cmd_alter_table::execute (this=0x7f55e00a8480, thd=0x7f55e0094120) at /home/travis/src/sql/sql_alter.cc:329 #13 0x00005595baf4db55 in mysql_execute_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:6226 #14 0x00005595baf52c5b in mysql_parse (thd=0x7f55e0094120, rawbuf=0x7f55e00a79c8 "ALTER ONLINE TABLE `B` /* 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 /", length=189, parser_state=0x7f55e4cdb250, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:8013 #15 0x00005595baf402ac in dispatch_command (command=COM_QUERY, thd=0x7f55e0094120, packet=0x7f55e0099921 "ALTER ONLINE TABLE `B` /!100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) /!100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 / ", packet_length=190, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:1824 #16 0x00005595baf3ec08 in do_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:1378 #17 0x00005595bb091094 in do_handle_one_connection (connect=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1335 #18 0x00005595bb090e14 in handle_one_connection (arg=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1241 #19 0x00007f55eeb196ba in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #20 0x00007f55edfae41d in clone () from /lib/x86_64-linux-gnu/libc.so.6 Query (0x7f55e00a79c8): ALTER ONLINE TABLE `B` / 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 */ Connection ID (thread ID): 19 {noformat} {noformat:title=elenst-dev 89b8fe9456508bc7310e88e88143ceedea77b2fe} perl ./runall-new.pl --basedir=/home/travis/server --vardir=/home/travis/logs/vardir --duration=350 --threads=6 --seed=1544774862 --reporters=Backtrace,ErrorLog,Deadlock --validators=TransformerNoComparator --views --redefine=conf/mariadb/alter_table.yy --redefine=conf/mariadb/sp.yy --redefine=conf/mariadb/bulk_insert.yy --redefine=conf/mariadb/modules/foreign_keys.yy --redefine=conf/mariadb/modules/admin.yy --redefine=conf/mariadb/modules/sql_mode.yy --mysqld=--log_output=FILE --mysqld=--max-statement-time=30 --mysqld=--lock-wait-timeout=10 --mysqld=--loose-innodb-lock-wait-timeout=5 --mysqld=--loose-debug_assert_on_not_freed_memory=0 --grammar=conf/engines/innodb/full_text_search.yy --transformers=ExecuteAsCTE,ExecuteAsExecuteImmediate,ExecuteAsDeleteReturning,ExecuteAsInsertSelect,ExecuteAsUnion,ExecuteAsUpdateDelete,ExecuteAsView,ExecuteAsPreparedTwice {noformat}	_Note: Might be related to ~~MDEV-15329~~_ https://travis-ci.org/elenst/travis-tests/jobs/467803822 {noformat:title=10.2 e3dda3d95ee4c09c2ed45ce886ecd25d1fc1ae92} 2018-12-14 08:07:53 0x7f55e4cdc700 InnoDB: Assertion failure in file /home/travis/src/storage/innobase/dict/dict0dict.cc line 6346 #5 0x00007f55edede02a in abort () from /lib/x86_64-linux-gnu/libc.so.6 #6 0x00005595bb5df7a7 in ut_dbg_assertion_failed (expr=0x0, file=0x5595bbbfb1a8 "/home/travis/src/storage/innobase/dict/dict0dict.cc", line=6346) at /home/travis/src/storage/innobase/ut/ut0dbg.cc:60 #7 0x00005595bb694141 in dict_table_check_for_dup_indexes (table=0x5595beefdeb8, check=CHECK_ALL_COMPLETE) at /home/travis/src/storage/innobase/dict/dict0dict.cc:6346 #8 0x00005595bb41118b in ha_innobase::commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/storage/innobase/handler/handler0alter.cc:9016 #9 0x00005595bb1c7f41 in handler::ha_commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/sql/handler.cc:4231 #10 0x00005595bb015dd8 in mysql_inplace_alter_table (thd=0x7f55e0094120, table_list=0x7f55e00a7bf8, table=0x5595bf432520, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, inplace_supported=HA_ALTER_INPLACE_NO_LOCK_AFTER_PREPARE, target_mdl_request=0x7f55e4cd86d0, alter_ctx=0x7f55e4cd9290) at /home/travis/src/sql/sql_table.cc:7391 #11 0x00005595bb01b2f1 in mysql_alter_table (thd=0x7f55e0094120, new_db=0x7f55e00a8208 "test", new_name=0x0, create_info=0x7f55e4cd9ea0, table_list=0x7f55e00a7bf8, alter_info=0x7f55e4cd9df0, order_num=0, order=0x0, ignore=false) at /home/travis/src/sql/sql_table.cc:9390 #12 0x00005595bb0963bc in Sql_cmd_alter_table::execute (this=0x7f55e00a8480, thd=0x7f55e0094120) at /home/travis/src/sql/sql_alter.cc:329 #13 0x00005595baf4db55 in mysql_execute_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:6226 #14 0x00005595baf52c5b in mysql_parse (thd=0x7f55e0094120, rawbuf=0x7f55e00a79c8 "ALTER ONLINE TABLE `B` /* 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 /", length=189, parser_state=0x7f55e4cdb250, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:8013 #15 0x00005595baf402ac in dispatch_command (command=COM_QUERY, thd=0x7f55e0094120, packet=0x7f55e0099921 "ALTER ONLINE TABLE `B` /!100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) /!100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 / ", packet_length=190, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:1824 #16 0x00005595baf3ec08 in do_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:1378 #17 0x00005595bb091094 in do_handle_one_connection (connect=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1335 #18 0x00005595bb090e14 in handle_one_connection (arg=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1241 #19 0x00007f55eeb196ba in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #20 0x00007f55edfae41d in clone () from /lib/x86_64-linux-gnu/libc.so.6 Query (0x7f55e00a79c8): ALTER ONLINE TABLE `B` / 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 / Connection ID (thread ID): 19 {noformat} {noformat:title=elenst-dev 89b8fe9456508bc7310e88e88143ceedea77b2fe} perl ./runall-new.pl --basedir=/home/travis/server --vardir=/home/travis/logs/vardir --duration=350 --threads=6 --seed=1544774862 --reporters=Backtrace,ErrorLog,Deadlock --validators=TransformerNoComparator --views --redefine=conf/mariadb/alter_table.yy --redefine=conf/mariadb/sp.yy --redefine=conf/mariadb/bulk_insert.yy --redefine=conf/mariadb/modules/foreign_keys.yy --redefine=conf/mariadb/modules/admin.yy --redefine=conf/mariadb/modules/sql_mode.yy --mysqld=--log_output=FILE --mysqld=--max-statement-time=30 --mysqld=--lock-wait-timeout=10 --mysqld=--loose-innodb-lock-wait-timeout=5 --mysqld=--loose-debug_assert_on_not_freed_memory=0 --grammar=conf/engines/innodb/full_text_search.yy --transformers=ExecuteAsCTE,ExecuteAsExecuteImmediate,ExecuteAsDeleteReturning,ExecuteAsInsertSelect,ExecuteAsUnion,ExecuteAsUpdateDelete,ExecuteAsView,ExecuteAsPreparedTwice {noformat} Also happened on adding FULLTEXT index (same test job, same versions): {noformat} 2018-12-14 08:17:34 0x7fda8afdf700 InnoDB: Assertion failure in file /home/travis/src/storage/innobase/dict/dict0dict.cc line 6346 #6 0x000056154f19c7a7 in ut_dbg_assertion_failed (expr=0x0, file=0x56154f7b81a8 "/home/travis/src/storage/innobase/dict/dict0dict.cc", line=6346) at /home/travis/src/storage/innobase/ut/ut0dbg.cc:60 #7 0x000056154f251141 in dict_table_check_for_dup_indexes (table=0x5615532bf608, check=CHECK_ALL_COMPLETE) at /home/travis/src/storage/innobase/dict/dict0dict.cc:6346 #8 0x000056154efce18b in ha_innobase::commit_inplace_alter_table (this=0x7fda9c2663c8, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, commit=true) at /home/travis/src/storage/innobase/handler/handler0alter.cc:9016 #9 0x000056154ed84f41 in handler::ha_commit_inplace_alter_table (this=0x7fda9c2663c8, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, commit=true) at /home/travis/src/sql/handler.cc:4231 #10 0x000056154ebd2dd8 in mysql_inplace_alter_table (thd=0x7fda9c047870, table_list=0x7fda9c48f2e0, table=0x7fda9c5605e0, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7fda8afdaf90, alter_ctx=0x7fda8afdbb50) at /home/travis/src/sql/sql_table.cc:7391 #11 0x000056154ebd82f1 in mysql_alter_table (thd=0x7fda9c047870, new_db=0x7fda9c48f8f0 "test", new_name=0x0, create_info=0x7fda8afdc760, table_list=0x7fda9c48f2e0, alter_info=0x7fda8afdc6b0, order_num=0, order=0x0, ignore=false) at /home/travis/src/sql/sql_table.cc:9390 #12 0x000056154ec533bc in Sql_cmd_alter_table::execute (this=0x7fda9c48fa08, thd=0x7fda9c047870) at /home/travis/src/sql/sql_alter.cc:329 #13 0x000056154eb0ab55 in mysql_execute_command (thd=0x7fda9c047870) at /home/travis/src/sql/sql_parse.cc:6226 #14 0x000056154eb2d823 in Prepared_statement::execute (this=0x7fda9c711f00, expanded_query=0x7fda8afddfc0, open_cursor=false) at /home/travis/src/sql/sql_prepare.cc:4799 #15 0x000056154eb2bb81 in Prepared_statement::execute_loop (this=0x7fda9c711f00, expanded_query=0x7fda8afddfc0, open_cursor=false, packet=0x7fda9c04d07a "", packet_end=0x7fda9c04d07a "") at /home/travis/src/sql/sql_prepare.cc:4228 #16 0x000056154eb294fc in mysql_stmt_execute_common (thd=0x7fda9c047870, stmt_id=6594, packet=0x7fda9c04d07a "", packet_end=0x7fda9c04d07a "", cursor_flags=0, bulk_op=false, read_types=false) at /home/travis/src/sql/sql_prepare.cc:3230 #17 0x000056154eb290c0 in mysqld_stmt_execute (thd=0x7fda9c047870, packet_arg=0x7fda9c04d071 "\302\031", packet_length=9) at /home/travis/src/sql/sql_prepare.cc:3128 #18 0x000056154eafcf2b in dispatch_command (command=COM_STMT_EXECUTE, thd=0x7fda9c047870, packet=0x7fda9c04d071 "\302\031", packet_length=9, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:1766 #19 0x000056154eafbc08 in do_command (thd=0x7fda9c047870) at /home/travis/src/sql/sql_parse.cc:1378 #20 0x000056154ec4e094 in do_handle_one_connection (connect=0x56155388f240) at /home/travis/src/sql/sql_connect.cc:1335 #21 0x000056154ec4de14 in handle_one_connection (arg=0x56155388f240) at /home/travis/src/sql/sql_connect.cc:1241 #22 0x00007fdaa344e6ba in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #23 0x00007fdaa28e341d in clone () from /lib/x86_64-linux-gnu/libc.so.6 Query (0x7fda9c48f178): ALTER TABLE `DD` ADD FULLTEXT INDEX idx_99 (`col_varchar_nokey`) / QNO 6054 CON_ID 15 */ Connection ID (thread ID): 15 Status: NOT_KILLED {noformat}

Elena Stepanova made changes - 2018-12-16 17:35

Link

This issue relates to ~~MDEV-18020~~ [ ~~MDEV-18020~~ ]

Elena Stepanova made changes - 2018-12-16 18:50

Component/s		Full-text Search [ 10104 ]
Fix Version/s		10.0 [ 16000 ]
Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.2 [ 14601 ]
Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Affects Version/s		10.0 [ 16000 ]
Affects Version/s		10.1 [ 16100 ]
Affects Version/s		10.3 [ 22126 ]
Affects Version/s		10.4 [ 22408 ]
Description	_Note: Might be related to ~~MDEV-15329~~_ https://travis-ci.org/elenst/travis-tests/jobs/467803822 {noformat:title=10.2 e3dda3d95ee4c09c2ed45ce886ecd25d1fc1ae92} 2018-12-14 08:07:53 0x7f55e4cdc700 InnoDB: Assertion failure in file /home/travis/src/storage/innobase/dict/dict0dict.cc line 6346 #5 0x00007f55edede02a in abort () from /lib/x86_64-linux-gnu/libc.so.6 #6 0x00005595bb5df7a7 in ut_dbg_assertion_failed (expr=0x0, file=0x5595bbbfb1a8 "/home/travis/src/storage/innobase/dict/dict0dict.cc", line=6346) at /home/travis/src/storage/innobase/ut/ut0dbg.cc:60 #7 0x00005595bb694141 in dict_table_check_for_dup_indexes (table=0x5595beefdeb8, check=CHECK_ALL_COMPLETE) at /home/travis/src/storage/innobase/dict/dict0dict.cc:6346 #8 0x00005595bb41118b in ha_innobase::commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/storage/innobase/handler/handler0alter.cc:9016 #9 0x00005595bb1c7f41 in handler::ha_commit_inplace_alter_table (this=0x5595bee904e8, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, commit=true) at /home/travis/src/sql/handler.cc:4231 #10 0x00005595bb015dd8 in mysql_inplace_alter_table (thd=0x7f55e0094120, table_list=0x7f55e00a7bf8, table=0x5595bf432520, altered_table=0x7f55e01767c0, ha_alter_info=0x7f55e4cd8660, inplace_supported=HA_ALTER_INPLACE_NO_LOCK_AFTER_PREPARE, target_mdl_request=0x7f55e4cd86d0, alter_ctx=0x7f55e4cd9290) at /home/travis/src/sql/sql_table.cc:7391 #11 0x00005595bb01b2f1 in mysql_alter_table (thd=0x7f55e0094120, new_db=0x7f55e00a8208 "test", new_name=0x0, create_info=0x7f55e4cd9ea0, table_list=0x7f55e00a7bf8, alter_info=0x7f55e4cd9df0, order_num=0, order=0x0, ignore=false) at /home/travis/src/sql/sql_table.cc:9390 #12 0x00005595bb0963bc in Sql_cmd_alter_table::execute (this=0x7f55e00a8480, thd=0x7f55e0094120) at /home/travis/src/sql/sql_alter.cc:329 #13 0x00005595baf4db55 in mysql_execute_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:6226 #14 0x00005595baf52c5b in mysql_parse (thd=0x7f55e0094120, rawbuf=0x7f55e00a79c8 "ALTER ONLINE TABLE `B` /* 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 /", length=189, parser_state=0x7f55e4cdb250, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:8013 #15 0x00005595baf402ac in dispatch_command (command=COM_QUERY, thd=0x7f55e0094120, packet=0x7f55e0099921 "ALTER ONLINE TABLE `B` /!100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) /!100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 / ", packet_length=190, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:1824 #16 0x00005595baf3ec08 in do_command (thd=0x7f55e0094120) at /home/travis/src/sql/sql_parse.cc:1378 #17 0x00005595bb091094 in do_handle_one_connection (connect=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1335 #18 0x00005595bb090e14 in handle_one_connection (arg=0x5595bef4eed0) at /home/travis/src/sql/sql_connect.cc:1241 #19 0x00007f55eeb196ba in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #20 0x00007f55edfae41d in clone () from /lib/x86_64-linux-gnu/libc.so.6 Query (0x7f55e00a79c8): ALTER ONLINE TABLE `B` / 100301 WAIT 8 / ADD CONSTRAINT a FOREIGN KEY (`col_time_nokey`) REFERENCES B (`col_time_key`) / 100307, ALGORITHM=INSTANT /, LOCK=SHARED / QNO 171 CON_ID 19 / Connection ID (thread ID): 19 {noformat} {noformat:title=elenst-dev 89b8fe9456508bc7310e88e88143ceedea77b2fe} perl ./runall-new.pl --basedir=/home/travis/server --vardir=/home/travis/logs/vardir --duration=350 --threads=6 --seed=1544774862 --reporters=Backtrace,ErrorLog,Deadlock --validators=TransformerNoComparator --views --redefine=conf/mariadb/alter_table.yy --redefine=conf/mariadb/sp.yy --redefine=conf/mariadb/bulk_insert.yy --redefine=conf/mariadb/modules/foreign_keys.yy --redefine=conf/mariadb/modules/admin.yy --redefine=conf/mariadb/modules/sql_mode.yy --mysqld=--log_output=FILE --mysqld=--max-statement-time=30 --mysqld=--lock-wait-timeout=10 --mysqld=--loose-innodb-lock-wait-timeout=5 --mysqld=--loose-debug_assert_on_not_freed_memory=0 --grammar=conf/engines/innodb/full_text_search.yy --transformers=ExecuteAsCTE,ExecuteAsExecuteImmediate,ExecuteAsDeleteReturning,ExecuteAsInsertSelect,ExecuteAsUnion,ExecuteAsUpdateDelete,ExecuteAsView,ExecuteAsPreparedTwice {noformat} Also happened on adding FULLTEXT index (same test job, same versions): {noformat} 2018-12-14 08:17:34 0x7fda8afdf700 InnoDB: Assertion failure in file /home/travis/src/storage/innobase/dict/dict0dict.cc line 6346 #6 0x000056154f19c7a7 in ut_dbg_assertion_failed (expr=0x0, file=0x56154f7b81a8 "/home/travis/src/storage/innobase/dict/dict0dict.cc", line=6346) at /home/travis/src/storage/innobase/ut/ut0dbg.cc:60 #7 0x000056154f251141 in dict_table_check_for_dup_indexes (table=0x5615532bf608, check=CHECK_ALL_COMPLETE) at /home/travis/src/storage/innobase/dict/dict0dict.cc:6346 #8 0x000056154efce18b in ha_innobase::commit_inplace_alter_table (this=0x7fda9c2663c8, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, commit=true) at /home/travis/src/storage/innobase/handler/handler0alter.cc:9016 #9 0x000056154ed84f41 in handler::ha_commit_inplace_alter_table (this=0x7fda9c2663c8, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, commit=true) at /home/travis/src/sql/handler.cc:4231 #10 0x000056154ebd2dd8 in mysql_inplace_alter_table (thd=0x7fda9c047870, table_list=0x7fda9c48f2e0, table=0x7fda9c5605e0, altered_table=0x7fda9c159170, ha_alter_info=0x7fda8afdaf20, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7fda8afdaf90, alter_ctx=0x7fda8afdbb50) at /home/travis/src/sql/sql_table.cc:7391 #11 0x000056154ebd82f1 in mysql_alter_table (thd=0x7fda9c047870, new_db=0x7fda9c48f8f0 "test", new_name=0x0, create_info=0x7fda8afdc760, table_list=0x7fda9c48f2e0, alter_info=0x7fda8afdc6b0, order_num=0, order=0x0, ignore=false) at /home/travis/src/sql/sql_table.cc:9390 #12 0x000056154ec533bc in Sql_cmd_alter_table::execute (this=0x7fda9c48fa08, thd=0x7fda9c047870) at /home/travis/src/sql/sql_alter.cc:329 #13 0x000056154eb0ab55 in mysql_execute_command (thd=0x7fda9c047870) at /home/travis/src/sql/sql_parse.cc:6226 #14 0x000056154eb2d823 in Prepared_statement::execute (this=0x7fda9c711f00, expanded_query=0x7fda8afddfc0, open_cursor=false) at /home/travis/src/sql/sql_prepare.cc:4799 #15 0x000056154eb2bb81 in Prepared_statement::execute_loop (this=0x7fda9c711f00, expanded_query=0x7fda8afddfc0, open_cursor=false, packet=0x7fda9c04d07a "", packet_end=0x7fda9c04d07a "") at /home/travis/src/sql/sql_prepare.cc:4228 #16 0x000056154eb294fc in mysql_stmt_execute_common (thd=0x7fda9c047870, stmt_id=6594, packet=0x7fda9c04d07a "", packet_end=0x7fda9c04d07a "", cursor_flags=0, bulk_op=false, read_types=false) at /home/travis/src/sql/sql_prepare.cc:3230 #17 0x000056154eb290c0 in mysqld_stmt_execute (thd=0x7fda9c047870, packet_arg=0x7fda9c04d071 "\302\031", packet_length=9) at /home/travis/src/sql/sql_prepare.cc:3128 #18 0x000056154eafcf2b in dispatch_command (command=COM_STMT_EXECUTE, thd=0x7fda9c047870, packet=0x7fda9c04d071 "\302\031", packet_length=9, is_com_multi=false, is_next_command=false) at /home/travis/src/sql/sql_parse.cc:1766 #19 0x000056154eafbc08 in do_command (thd=0x7fda9c047870) at /home/travis/src/sql/sql_parse.cc:1378 #20 0x000056154ec4e094 in do_handle_one_connection (connect=0x56155388f240) at /home/travis/src/sql/sql_connect.cc:1335 #21 0x000056154ec4de14 in handle_one_connection (arg=0x56155388f240) at /home/travis/src/sql/sql_connect.cc:1241 #22 0x00007fdaa344e6ba in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0 #23 0x00007fdaa28e341d in clone () from /lib/x86_64-linux-gnu/libc.so.6 Query (0x7fda9c48f178): ALTER TABLE `DD` ADD FULLTEXT INDEX idx_99 (`col_varchar_nokey`) / QNO 6054 CON_ID 15 */ Connection ID (thread ID): 15 Status: NOT_KILLED {noformat}	_Note: See also ~~MDEV-15329~~, ~~MDEV-18017~~, ~~MDEV-18020~~_ {code:sql} --source include/have_innodb.inc CREATE TABLE t1 (f VARCHAR(256)) ENGINE=InnoDB; SET SESSION FOREIGN_KEY_CHECKS= OFF ; ALTER TABLE t1 ADD FOREIGN KEY (f) REFERENCES non_existing_table (x); ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f); ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f); # Cleanup DROP TABLE t1; {code} On 10.2+ debug builds: {noformat:title=10.2 0a2edddbf4} 2018-12-16 20:41:54 0x7ff6a84ff700 InnoDB: Assertion failure in file /data/src/10.2/storage/innobase/dict/dict0dict.cc line 6346 #6 0x000055acb002a1f2 in ut_dbg_assertion_failed (expr=0x0, file=0x55acb061a290 "/data/src/10.2/storage/innobase/dict/dict0dict.cc", line=6346) at /data/src/10.2/storage/innobase/ut/ut0dbg.cc:60 #7 0x000055acb00deff9 in dict_table_check_for_dup_indexes (table=0x7ff65009aa78, check=CHECK_ALL_COMPLETE) at /data/src/10.2/storage/innobase/dict/dict0dict.cc:6346 #8 0x000055acafe5cf98 in ha_innobase::commit_inplace_alter_table (this=0x7ff6500a9368, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, commit=true) at /data/src/10.2/storage/innobase/handler/handler0alter.cc:9015 #9 0x000055acafc181e6 in handler::ha_commit_inplace_alter_table (this=0x7ff6500a9368, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, commit=true) at /data/src/10.2/sql/handler.cc:4231 #10 0x000055acafa67818 in mysql_inplace_alter_table (thd=0x7ff650000d60, table_list=0x7ff6500127a8, table=0x7ff65009ee00, altered_table=0x7ff650038620, ha_alter_info=0x7ff6a84fb5d0, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7ff6a84fb640, alter_ctx=0x7ff6a84fc200) at /data/src/10.2/sql/sql_table.cc:7391 #11 0x000055acafa6cd14 in mysql_alter_table (thd=0x7ff650000d60, new_db=0x7ff650012db8 "test", new_name=0x0, create_info=0x7ff6a84fce20, table_list=0x7ff6500127a8, alter_info=0x7ff6a84fcd70, order_num=0, order=0x0, ignore=false) at /data/src/10.2/sql/sql_table.cc:9390 #12 0x000055acafae753a in Sql_cmd_alter_table::execute (this=0x7ff650012e88, thd=0x7ff650000d60) at /data/src/10.2/sql/sql_alter.cc:323 #13 0x000055acaf99fd22 in mysql_execute_command (thd=0x7ff650000d60) at /data/src/10.2/sql/sql_parse.cc:6227 #14 0x000055acaf9a4e6e in mysql_parse (thd=0x7ff650000d60, rawbuf=0x7ff6500126a8 "ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f)", length=41, parser_state=0x7ff6a84fe1e0, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:8014 #15 0x000055acaf9924ef in dispatch_command (command=COM_QUERY, thd=0x7ff650000d60, packet=0x7ff650008b01 "ALTER TABLE t1 ADD FULLTEXT INDEX ft2 (f)", packet_length=41, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:1824 #16 0x000055acaf990e8d in do_command (thd=0x7ff650000d60) at /data/src/10.2/sql/sql_parse.cc:1378 #17 0x000055acafae2201 in do_handle_one_connection (connect=0x55acb2483ec0) at /data/src/10.2/sql/sql_connect.cc:1335 #18 0x000055acafae1f81 in handle_one_connection (arg=0x55acb2483ec0) at /data/src/10.2/sql/sql_connect.cc:1241 #19 0x000055acb03139db in pfs_spawn_thread (arg=0x55acb278e1d0) at /data/src/10.2/storage/perfschema/pfs.cc:1862 #20 0x00007ff6aec1b6db in start_thread (arg=0x7ff6a84ff700) at pthread_create.c:463 #21 0x00007ff6ae00588f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 {noformat} Non-debug build doesn't crash, it produces errors: {noformat:title=10.3 non-debug 5fefcb0a21} 2018-12-16 20:49:53 9 [ERROR] Cannot find index ft2 in InnoDB index dictionary. 2018-12-16 20:49:53 9 [ERROR] InnoDB indexes are inconsistent with what defined in .frm for table ./test/t1 2018-12-16 20:49:53 9 [ERROR] InnoDB could not find key no 1 with name ft2 from dict cache for table test/t1 2018-12-16 20:49:53 9 [ERROR] InnoDB: Table test/t1 contains 2 indexes inside InnoDB, which is different from the number of indexes 2 defined in the MariaDB Have you mixed up .frm files from different installations? See http://dev.mysql.com/doc/refman/5.7/en/innodb-troubleshooting.html {noformat} On 10.0 and 10.1 the failure looks a bit different, it happens on the first ADD INDEX already: {noformat:title=10.0 1a7158b88a1} 181216 20:47:30 [ERROR] InnoDB: dict_load_foreigns() returned 38 for ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f) 2018-12-16 20:47:30 7fa9d47c7700 InnoDB: Assertion failure in thread 140367391127296 in file handler0alter.cc line 6047 InnoDB: Failing assertion: 0 #5 0x00007fa9d2e39801 in __GI_abort () at abort.c:79 #6 0x00005638084084a0 in ha_innobase::commit_inplace_alter_table (this=0x7fa9be880088, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, commit=true) at /data/src/10.0/storage/xtradb/handler/handler0alter.cc:6047 #7 0x000056380809b6f8 in handler::ha_commit_inplace_alter_table (this=0x7fa9be880088, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, commit=true) at /data/src/10.0/sql/handler.cc:4228 #8 0x0000563807f4570c in mysql_inplace_alter_table (thd=0x7fa9c7a0c070, table_list=0x7fa9be9a2188, table=0x7fa9be89e470, altered_table=0x7fa9beba0070, ha_alter_info=0x7fa9d47c3a00, inplace_supported=HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, target_mdl_request=0x7fa9d47c3a70, alter_ctx=0x7fa9d47c4200) at /data/src/10.0/sql/sql_table.cc:7176 #9 0x0000563807f4a118 in mysql_alter_table (thd=0x7fa9c7a0c070, new_db=0x7fa9be9a2768 "test", new_name=0x0, create_info=0x7fa9d47c52c0, table_list=0x7fa9be9a2188, alter_info=0x7fa9d47c5230, order_num=0, order=0x0, ignore=false) at /data/src/10.0/sql/sql_table.cc:8980 #10 0x0000563807fbb1e6 in Sql_cmd_alter_table::execute (this=0x7fa9be9a2838, thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_alter.cc:306 #11 0x0000563807e8b622 in mysql_execute_command (thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_parse.cc:5118 #12 0x0000563807e8f21b in mysql_parse (thd=0x7fa9c7a0c070, rawbuf=0x7fa9be9a2088 "ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f)", length=41, parser_state=0x7fa9d47c6660) at /data/src/10.0/sql/sql_parse.cc:6637 #13 0x0000563807e8111f in dispatch_command (command=COM_QUERY, thd=0x7fa9c7a0c070, packet=0x7fa9cc91e071 "ALTER TABLE t1 ADD FULLTEXT INDEX ft1 (f)", packet_length=41) at /data/src/10.0/sql/sql_parse.cc:1300 #14 0x0000563807e803d3 in do_command (thd=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_parse.cc:1003 #15 0x0000563807fb63be in do_handle_one_connection (thd_arg=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_connect.cc:1377 #16 0x0000563807fb610d in handle_one_connection (arg=0x7fa9c7a0c070) at /data/src/10.0/sql/sql_connect.cc:1292 #17 0x00005638083c6304 in pfs_spawn_thread (arg=0x7fa9c773cf70) at /data/src/10.0/storage/perfschema/pfs.cc:1861 #18 0x00007fa9d39186db in start_thread (arg=0x7fa9d47c7700) at pthread_create.c:463 #19 0x00007fa9d2f1a88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 {noformat}
Summary	[Draft] Assertion failure in dict_table_check_for_dup_indexes / ha_innobase::commit_inplace_alter_table upon ADD FOREIGN KEY	Assertion failure in dict_table_check_for_dup_indexes / ha_innobase::commit_inplace_alter_table upon ADD FOREIGN KEY or ADD FULLTEXT

Elena Stepanova made changes - 2018-12-16 18:51

Assignee

Elena Stepanova [ elenst ]

Marko Mäkelä [ marko ]

Elena Stepanova made changes - 2018-12-18 00:11

Link

This issue relates to ~~MDEV-15329~~ [ ~~MDEV-15329~~ ]

Elena Stepanova made changes - 2018-12-24 12:52

Link

This issue relates to ~~MDEV-18017~~ [ ~~MDEV-18017~~ ]

Elena Stepanova made changes - 2019-01-08 01:29

Link

This issue relates to MDEV-18047 [ MDEV-18047 ]

Elena Stepanova made changes - 2019-01-25 13:21

Labels

affects-tests

Marko Mäkelä added a comment - 2019-01-29 12:47

The assertion ut_ad(0) that fails in 10.0 was added by me in
Bug#15989081 INNODB ALTER TABLE IS NOT ATOMIC
which claims the following:

Revert the work-around and really fix
Bug#14105491 ADD FOREIGN KEY ON COLUMNS BEING RENAMED DOES NOT WORK CORRECTLY

Refactor ha_innobase::commit_inplace_alter_table() as follows:

First, update the data dictionary definitions in the persistent data
dictionary within a single data dictionary transaction. If any step
fails, roll back the dictionary transaction. Update the foreign key
constraints in the same data dictionary transaction with everything
else.

Only if the definitions were successfully updated, perform the
corresponding modifications in the data dictionary cache. In this way,
there is no need to implement any logic for rolling back any changes
in the data dictionary cache. (Adding an index is the most notable
exception to this, as we will allocate a placeholder for the index.)

When adding the assertion, I did not take into account the fact that malformed FOREIGN KEY constraints may be added when foreign_key_checks=0. I think that we must change this code to only output a warning, and no error:

				/* The data dictionary cache

				should be corrupted now.  The

				best solution should be to

				kill and restart the server,

				but the *.frm file has not

				been replaced yet. */

				my_error(ER_CANNOT_ADD_FOREIGN,

					 MYF(0));

				sql_print_error(

					"InnoDB: dict_load_foreigns()"

					" returned %u for %s",

					(unsigned) error,

					thd_query_string(user_thd)

					->str);

				ut_ad(0);

In MariaDB 10.2, it looks like we have gotten a change from MySQL 5.7, causing an assertion failure in a different place.

Marko Mäkelä added a comment - 2019-01-29 12:47 The assertion ut_ad(0) that fails in 10.0 was added by me in Bug#15989081 INNODB ALTER TABLE IS NOT ATOMIC which claims the following: Revert the work-around and really fix Bug#14105491 ADD FOREIGN KEY ON COLUMNS BEING RENAMED DOES NOT WORK CORRECTLY Refactor ha_innobase::commit_inplace_alter_table() as follows: First, update the data dictionary definitions in the persistent data dictionary within a single data dictionary transaction. If any step fails, roll back the dictionary transaction. Update the foreign key constraints in the same data dictionary transaction with everything else. Only if the definitions were successfully updated, perform the corresponding modifications in the data dictionary cache. In this way, there is no need to implement any logic for rolling back any changes in the data dictionary cache. (Adding an index is the most notable exception to this, as we will allocate a placeholder for the index.) When adding the assertion, I did not take into account the fact that malformed FOREIGN KEY constraints may be added when foreign_key_checks=0 . I think that we must change this code to only output a warning, and no error: /* The data dictionary cache should be corrupted now. The best solution should be to kill and restart the server, but the *.frm file has not been replaced yet. */ my_error(ER_CANNOT_ADD_FOREIGN, MYF(0)); sql_print_error( "InnoDB: dict_load_foreigns()" " returned %u for %s" , (unsigned) error, thd_query_string(user_thd) ->str); ut_ad(0); In MariaDB 10.2, it looks like we have gotten a change from MySQL 5.7, causing an assertion failure in a different place.

Marko Mäkelä made changes - 2019-01-29 13:24

issue.field.resolutiondate

2019-01-29 13:24:08.0

2019-01-29 13:24:08.099

Marko Mäkelä made changes - 2019-01-29 13:24

Component/s		Storage Engine - XtraDB [ 10135 ]
Fix Version/s		10.4.3 [ 23230 ]
Fix Version/s		10.1.38 [ 23209 ]
Fix Version/s		10.0.38 [ 23211 ]
Fix Version/s		10.3.13 [ 23215 ]
Fix Version/s		10.2.22 [ 23250 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.0 [ 16000 ]
Fix Version/s	10.1 [ 16100 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2019-04-18 13:51

Link

This issue is duplicated by ~~MDEV-16654~~ [ ~~MDEV-16654~~ ]

Marko Mäkelä made changes - 2019-04-18 13:51

Link

This issue is duplicated by ~~MDEV-18321~~ [ ~~MDEV-18321~~ ]

Elena Stepanova made changes - 2019-10-30 14:22

Link

This issue duplicates ~~MDEV-15329~~ [ ~~MDEV-15329~~ ]

Elena Stepanova made changes - 2019-10-30 14:22

Link

This issue relates to ~~MDEV-15329~~ [ ~~MDEV-15329~~ ]

Sergei Golubchik made changes - 2021-12-06 21:48

Workflow

MariaDB v3 [ 91265 ]

MariaDB v4 [ 155367 ]

People

Assignee:: Marko Mäkelä

Reporter:: Elena Stepanova

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2018-12-15 14:24

Updated:: 2019-10-30 14:22

Resolved:: 2019-01-29 13:24

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration