[MDEV-10356] rpl.rpl_parallel_temptable failure due to incorrect commit optimization of temptables - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL)
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3
Component/s: Replication, Tests
Labels:

Description

Temporary tables require strict single-threaded operation, there is no locking protecting concurrent access. For this reason, they are considered non-transactional for the purpose of parallel replication.

However, even non-transactional event groups have an optimisation that allow part of the commit of such event groups to run in parallel with following event groups. Thus, it was still possible for part of the commit codepath to run in parallel with another operation on the temporary table such as a SELECT or DML or even a DROP TEMPORARY TABLE. This can cause access of freed memory and probably other nasty effects.

The problem is the mark_start_commit() in handle_rpl_parallel_thread() just before the COMMIT event is applied, as well as calls of wakeup_subsequent_commit() in the binlog code and in innobase_commit(). These are too early at these points when temporary tables are replicated.

Since temporary table operations are not binlogged in MIXED or ROW mode, this problem affects only statement-based replication.

This is seen as occasional test failures of rpl.rpl_parallel_temptable as reported by Elena and others:

http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest2/builds/5564/steps/test_6/logs/stdio

rpl.rpl_parallel_temptable 'innodb_plugin,stmt' w1 [ fail ]

        Test ended at 2016-07-09 07:04:06

CURRENT_TEST: rpl.rpl_parallel_temptable

mysqltest: At line 132: failed in 'select master_pos_wait('master-bin.000002', 558, 300, '')': 2013: Lost connection to MySQL server during query

The result from queries just before the failure was:

< snip >

INSERT INTO t2 VALUES (13);

INSERT INTO t3 SELECT a+32 FROM t4;

INSERT INTO t2 VALUES (14);

INSERT INTO t2 VALUES (15);

INSERT INTO t2 VALUES (16);

INSERT INTO t4 SELECT a+64 FROM t3;

INSERT INTO t2 VALUES (17);

INSERT INTO t2 VALUES (18);

INSERT INTO t2 VALUES (19);

INSERT INTO t3 SELECT a+128 FROM t4;

INSERT INTO t2 VALUES (20);

INSERT INTO t1 SELECT a, a MOD 7 FROM t3;

INSERT INTO t1 SELECT a, a MOD 7 FROM t4;

INSERT INTO t1 SELECT a, COUNT(*) FROM t2 GROUP BY a;

FLUSH TABLES;

SET SESSION debug_dbug="+d,crash_dispatch_command_before";

SELECT 1;

Got one of the listed errors

INSERT INTO t1 VALUES (0, 1);

include/start_slave.inc

More results from queries before failure can be found in /mnt/buildbot/build/mariadb-10.1.16/mysql-test/var/1/log/rpl_parallel_temptable.log

Server [mysqld.2 - pid: 26230, winpid: 26230, exit: 256] failed during test run

Server log from this test:

----------SERVER LOG START-----------

2016-07-09  7:03:47 3077719808 [Note] /mnt/buildbot/build/mariadb-10.1.16/sql/mysqld (mysqld 10.1.16-MariaDB-debug) starting as process 26231 ...

2016-07-09  7:03:47 3077719808 [Warning] Could not increase number of max_open_files to more than 1024 (request: 4162)

2016-07-09  7:03:47 3077719808 [Note] Plugin 'file_key_management' is disabled.

2016-07-09  7:03:47 3077719808 [Note] Plugin 'BLACKHOLE' is disabled.

2016-07-09  7:03:47 3077719808 [Note] Plugin 'partition' is disabled.

2016-07-09  7:03:47 3077719808 [Note] Plugin 'ARCHIVE' is disabled.

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Using mutexes to ref count buffer pool pages

2016-07-09  7:03:48 3077719808 [Note] InnoDB:  InnoDB: !!!!!!!! UNIV_DEBUG switched on !!!!!!!!!

2016-07-09  7:03:48 3077719808 [Note] InnoDB:  InnoDB: !!!!!!!! UNIV_SYNC_DEBUG switched on !!!!!!!!!

2016-07-09  7:03:48 3077719808 [Note] InnoDB: The InnoDB memory heap is disabled

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Memory barrier is not used

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Compressed tables use zlib 1.2.3.4

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Using Linux native AIO

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Using generic crc32 instructions

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Initializing buffer pool, size = 8.0M

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Completed initialization of buffer pool

2016-07-09  7:03:48 3077719808 [Note] InnoDB: Highest supported file format is Barracuda.

2016-07-09  7:03:49 3077719808 [Note] InnoDB: 128 rollback segment(s) are active.

2016-07-09  7:03:49 3077719808 [Note] InnoDB: Waiting for purge to start

2016-07-09  7:03:49 3077719808 [Note] InnoDB: 5.6.31 started; log sequence number 1629517

2016-07-09  7:03:49 2858416960 [Note] InnoDB: Dumping buffer pool(s) not yet started

2016-07-09  7:03:49 3077719808 [Note] Plugin 'TEST_SQL_DISCOVERY' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'CONNECT' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'SPHINX' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'SEQUENCE' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'FEDERATED' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_DATAFILES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_TABLESTATS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'XTRADB_READ_VIEW' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'XTRADB_RSEG' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'CHANGED_PAGE_BITMAPS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'QUERY_CACHE_INFO' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_LOCK_WAITS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_TABLESPACES_ENCRYPTION' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_FIELDS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_TABLESPACES_SCRUBBING' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_INDEX_TABLE' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'XTRADB_INTERNAL_HASH_TABLES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_MUTEXES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_CMPMEM_RESET' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'FEEDBACK' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'METADATA_LOCK_INFO' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_CMP' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_DEFAULT_STOPWORD' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_CMP_RESET' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'QUERY_RESPONSE_TIME' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_INDEX_CACHE' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_BEING_DELETED' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_CMP_PER_INDEX_RESET' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_SEMAPHORE_WAITS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_COLUMNS' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_CONFIG' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_TABLESPACES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_FT_DELETED' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'INNODB_SYS_INDEXES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'LOCALES' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'unix_socket' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'QUERY_RESPONSE_TIME_AUDIT' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'rpl_semi_sync_slave' is disabled.

2016-07-09  7:03:49 3077719808 [Note] Plugin 'rpl_semi_sync_master' is disabled.

2016-07-09  7:03:49 3077719808 [Warning] /mnt/buildbot/build/mariadb-10.1.16/sql/mysqld: unknown option '--loose-skip-plugin-innodb-changed-pages'

2016-07-09  7:03:49 3077719808 [Note] Server socket created on IP: '127.0.0.1'.

2016-07-09  7:03:49 3077719808 [Note] /mnt/buildbot/build/mariadb-10.1.16/sql/mysqld: ready for connections.

Version: '10.1.16-MariaDB-debug'  socket: '/mnt/buildbot/build/mariadb-10.1.16/mysql-test/var/tmp/1/mysqld.2.sock'  port: 16041  Source distribution

2016-07-09  7:03:50 2918969152 [Note] 'CHANGE MASTER TO executed'. Previous state master_host='', master_port='3306', master_log_file='', master_log_pos='4'. New state master_host='127.0.0.1', master_port='16040', master_log_file='master-bin.000001', master_log_pos='4'.

2016-07-09  7:03:50 2872782656 [Note] Slave I/O thread: connected to master 'root@127.0.0.1:16040',replication started in log 'master-bin.000001' at position 4

2016-07-09  7:03:50 2872479552 [Note] Slave SQL thread initialized, starting replication in log 'master-bin.000001' at position 4, relay log './slave-relay-bin.000001' position: 4

2016-07-09  7:03:51 2872479552 [Note] Error reading relay log event: slave SQL thread was killed

2016-07-09  7:03:51 2872782656 [ERROR] Error reading packet from server: Lost connection to MySQL server during query ( server_errno=2013)

2016-07-09  7:03:51 2872782656 [Note] Slave I/O thread exiting, read up to log 'master-bin.000001', position 314

2016-07-09  7:03:51 2918969152 [Note] 'CHANGE MASTER TO executed'. Previous state master_host='127.0.0.1', master_port='16040', master_log_file='master-bin.000001', master_log_pos='314'. New state master_host='127.0.0.1', master_port='16040', master_log_file='master-bin.000001', master_log_pos='314'.

2016-07-09  7:03:51 2918969152 [Note] Previous Using_Gtid=No. New Using_Gtid=Current_Pos

2016-07-09  7:03:51 2872479552 [Note] Slave I/O thread: connected to master 'root@127.0.0.1:16040',replication starts at GTID position ''

2016-07-09  7:03:51 2824539968 [Note] Slave SQL thread initialized, starting replication in log 'master-bin.000001' at position 314, relay log './slave-relay-bin.000001' position: 4; GTID position ''

2016-07-09  7:03:51 2824539968 [Note] Error reading relay log event: slave SQL thread was killed

2016-07-09  7:03:51 2872479552 [ERROR] Error reading packet from server: Lost connection to MySQL server during query ( server_errno=2013)

2016-07-09  7:03:51 2872479552 [Note] Slave I/O thread exiting, read up to log 'master-bin.000001', position 485; GTID position 0-1-1

2016-07-09  7:03:56 2824539968 [Note] Slave I/O thread: connected to master 'root@127.0.0.1:16040',replication starts at GTID position '0-1-1'

2016-07-09  7:03:56 2862300992 [Note] Slave SQL thread initialized, starting replication in log 'master-bin.000001' at position 485, relay log './slave-relay-bin.000001' position: 4; GTID position '0-1-1'

160709  7:03:56 [ERROR] mysqld got signal 11 ;

This could be because you hit a bug. It is also possible that this binary

or one of the libraries it was linked against is corrupt, improperly built,

or misconfigured. This error can also be caused by malfunctioning hardware.

To report this bug, see https://mariadb.com/kb/en/reporting-bugs

We will try our best to scrape up some info that will hopefully help

diagnose the problem, but since we have already crashed,

something is definitely wrong and this may fail.

Server version: 10.1.16-MariaDB-debug

key_buffer_size=1048576

read_buffer_size=131072

max_used_connections=2

max_threads=153

thread_count=2

It is possible that mysqld could use up to

key_buffer_size + (read_buffer_size + sort_buffer_size)*max_threads = 61813 K  bytes of memory

Hope that's ok; if not, decrease some variables in the equation.

Thread pointer: 0x0xaa800670

Attempting backtrace. You can use the following information to find out

where mysqld died. If you see no messages after this, something went

terribly wrong...

stack_bottom = 0xaa9696b8 thread_stack 0x48400

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(my_print_stacktrace+0x29)[0x8b0fe39]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(handle_fatal_signal+0x53c)[0x8438b4c]

[0xe9b400]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_Z19close_thread_tablesP3THD+0x48f)[0x81f7c3f]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_Z21mysql_execute_commandP3THD+0x45b)[0x825582b]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_Z11mysql_parseP3THDPcjP12Parser_state+0x36c)[0x8261b2c]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_ZN15Query_log_event14do_apply_eventEP14rpl_group_infoPKcj+0xcef)[0x8540d3f]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_ZN15Query_log_event14do_apply_eventEP14rpl_group_info+0x31)[0x8542031]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(_Z26apply_event_and_update_posP9Log_eventP3THDP14rpl_group_infoP19rpl_parallel_thread+0x63d)[0x81c41ad]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld[0x83ad240]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld(handle_rpl_parallel_thread+0x99b)[0x83b1e4b]

/mnt/buildbot/build/mariadb-10.1.16/sql/mysqld[0x8619a8a]

/lib/i386-linux-gnu/libpthread.so.0(+0x6d4c)[0x1a3d4c]

/lib/i386-linux-gnu/libc.so.6(clone+0x5e)[0xa38ace]

Trying to get some variables.

Some pointers may be invalid and cause the dump to abort.

Query (0xb2d12cd3): COMMIT

Connection ID (thread ID): 18

Status: NOT_KILLED

Optimizer switch: index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on,index_merge_sort_intersection=off,engine_condition_pushdown=off,index_condition_pushdown=on,derived_merge=on,derived_with_keys=on,firstmatch=on,loosescan=on,materialization=on,in_to_exists=on,semijoin=on,partial_match_rowid_merge=on,partial_match_table_scan=on,subquery_cache=on,mrr=off,mrr_cost_based=off,mrr_sort_keys=off,outer_join_with_cache=on,semijoin_with_cache=on,join_cache_incremental=on,join_cache_hashed=on,join_cache_bka=on,optimize_join_buffer_size=off,table_elimination=on,extended_keys=on,exists_to_in=on,orderby_uses_equalities=off

The manual page at http://dev.mysql.com/doc/mysql/en/crashing.html contains

information that should help you find out what is causing the crash.

Writing a core file

It happens very rarely in buildbot, a handful of occasions over 2 years.
It's possible that the failure is caused by the same problem as was recently fixed in ~~MDEV-10219~~, but then the fix needs to be backported into 10.1 and possibly 10.0.

Attachments

Issue Links

blocks

MDEV-7069 Fix buildbot failures in main server trees

Stalled

is duplicated by

MDEV-25064 rpl.rpl_parallel_temptable failed in bb, ASAN heap-use-after-free in std::__atomic_base<long>::store

Closed

relates to

MDEV-26126 Replication delay increasing infinitely from grandpa master when enable parallel replication and use temporary table?

Open

MDEV-26152 Assertion: prebuilt->template_type == ROW_MYSQL_WHOLE_ROW fails in row0mysql.cc line 1752

Confirmed

MDEV-12459 The information_schema tables for getting temporary tables info is missing, at least for innodb there is no INNODB_TEMP_TABLE_INFO

Closed

MDEV-16539 Server crashes in THD::mark_tmp_table_as_free_for_reuse

Open

MDEV-25064 rpl.rpl_parallel_temptable failed in bb, ASAN heap-use-after-free in std::__atomic_base<long>::store

Closed

(2 relates to)

Activity

People

Assignee:: Kristian Nielsen

Reporter:: Elena Stepanova

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 2016-07-10 23:01

Updated:: 2023-09-14 07:19

Resolved:: 2023-09-07 13:09

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.