Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9267

pull in Connector/C sources into the server tree on builds

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • N/A
    • Compiling
    • None
    • 10.2.0-5, 10.2.0-6, 10.2.0-7, 10.2.0-10, 10.2.0-11, 10.2.1-1, 10.2.1-2

    Description

      We need Connector/C sources to be present in the server source tree. There are (at least) two possibilities:

      1. download the source tarball using cmake FILE(DOWLOAD ...) command
      2. pull them in using git submodule feature

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-9293 change clients to use Connector/C

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CONC-177 myisam_views-big (ps-protocol) test fails in bb-10.2-connector-c-integ

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-179 federatedx fails in bb-10.2-connector-c-integ

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-180 Timeout in SSL handshake results in unhelpful message "Unknown MySQL error"

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-9055 replace libmysqlclient with Connector/C

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            wlad Vladislav Vaintroub added a comment -

            Following tests currently fail :

            main.mysql_locale_posix : (charset = auto ) http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-centos5-amd64/builds/2532/steps/test/logs/stdio
            main.openssl_1 : (different error msg) http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-centos5-amd64/builds/2532/steps/test/logs/stdio
            main.mysql_client_test(_nonblock) : http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-quantal-x86/builds/3736/steps/test/logs/stdio
            main.ssl-big(mysqltest failed provided no output ) :http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest/builds/5636/steps/test_2/logs/stdio
            funcs_1.myisam_views-big : http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest/builds/5636/steps/test_2/logs/stdio
            failed compile (solaris) : http://buildbot.askmonty.org/buildbot/builders/sol10-64/builds/4934/steps/compile/logs/stdio
            main.userstat : http://buildbot.askmonty.org/buildbot/builders/win32-debug2/builds/9241/steps/test/logs/stdio
            main.ssl_8k_key main.non_blocking_api main.openssl_1 main.ssl main.ssl_compress main.ssl_timeout : http://buildbot.askmonty.org/buildbot/builders/win32-debug-azure/builds/529/steps/test/logs/stdio

            wlad Vladislav Vaintroub added a comment - Following tests currently fail : main.mysql_locale_posix : (charset = auto ) http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-centos5-amd64/builds/2532/steps/test/logs/stdio main.openssl_1 : (different error msg) http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-centos5-amd64/builds/2532/steps/test/logs/stdio main.mysql_client_test(_nonblock) : http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-quantal-x86/builds/3736/steps/test/logs/stdio main.ssl-big(mysqltest failed provided no output ) : http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest/builds/5636/steps/test_2/logs/stdio funcs_1.myisam_views-big : http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest/builds/5636/steps/test_2/logs/stdio failed compile (solaris) : http://buildbot.askmonty.org/buildbot/builders/sol10-64/builds/4934/steps/compile/logs/stdio main.userstat : http://buildbot.askmonty.org/buildbot/builders/win32-debug2/builds/9241/steps/test/logs/stdio main.ssl_8k_key main.non_blocking_api main.openssl_1 main.ssl main.ssl_compress main.ssl_timeout : http://buildbot.askmonty.org/buildbot/builders/win32-debug-azure/builds/529/steps/test/logs/stdio
            wlad Vladislav Vaintroub added a comment -

            Closing, since this part of bringing connector c to server is already done (in bb-10.2-connector-c-integ tree) Continuation of the connector c integraton is done in MDEV-9293

            wlad Vladislav Vaintroub added a comment - Closing, since this part of bringing connector c to server is already done (in bb-10.2-connector-c-integ tree) Continuation of the connector c integraton is done in MDEV-9293
            wlad Vladislav Vaintroub added a comment -

            implemented in in connector c integration tree.

            wlad Vladislav Vaintroub added a comment - implemented in in connector c integration tree.
            otto Otto Kekäläinen added a comment -

            For the record, in my opinion the correct solution to this would have been to add libmariadb3 into the debian/control file (where all other build dependencies are listed as well) instead of going with a bundled libmariadb3 as now done.

            Or at least if using a bundled version of libmariadb3, then at least not publish the packages for it for others to consume, but rather let others consume the real original libmariadb3 built from MariaDB Connector C sources.

            I am currently in the midst of thinking what to do in Debian official. I will probably not start publishing libmariadb3 from the server source package like upstream did.

            otto Otto Kekäläinen added a comment - For the record, in my opinion the correct solution to this would have been to add libmariadb3 into the debian/control file (where all other build dependencies are listed as well) instead of going with a bundled libmariadb3 as now done. Or at least if using a bundled version of libmariadb3, then at least not publish the packages for it for others to consume, but rather let others consume the real original libmariadb3 built from MariaDB Connector C sources. I am currently in the midst of thinking what to do in Debian official. I will probably not start publishing libmariadb3 from the server source package like upstream did.

            People

              wlad Vladislav Vaintroub
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.