Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9260

Improve progress report on on-line alter table

Details

    Description

      There is very limited progress report and no real progress report on FT-indexes.

      Attachments

        Issue Links

          includes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-9148 Assertion `thd->stmt_arena != thd->progress.arena' failed in thd_progress_init

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12512 Accurately report progress for ALTER TABLE...ALGORITHM=INPLACE

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-13626 Merge InnoDB test cases from MySQL 5.7

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16329 Engine-independent online ALTER TABLE

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä added a comment -

            With MDEV-16329 replacing the InnoDB internal table rebuild, the progress reporting should be limited to ADD INDEX creating secondary indexes.

            marko Marko Mäkelä added a comment - With MDEV-16329 replacing the InnoDB internal table rebuild, the progress reporting should be limited to ADD INDEX creating secondary indexes.
            marko Marko Mäkelä added a comment -

            MDEV-16329 did not replace the InnoDB internal table rebuild. In MySQL 5.7 there is a test innodb.alter_table_stage_progress that would execute the following query:

            SELECT
            		 
            event_name,
            		 
            work_completed > 0,
            		 
            work_estimated > 0,
            		 
            work_completed <= work_estimated
            		 
            FROM performance_schema.events_stages_history
            		 
            WHERE event_name LIKE 'stage/innodb/alter table%'
            		 
            ORDER BY 1;

            This query would fail in MariaDB because there are no columns work_completed or work_estimated in the performance_schema.event_stages_history.

            There is also https://mariadb.com/kb/en/progress-reporting/ which might be worth supporting.

            marko Marko Mäkelä added a comment - MDEV-16329 did not replace the InnoDB internal table rebuild. In MySQL 5.7 there is a test innodb.alter_table_stage_progress that would execute the following query: SELECT event_name, work_completed > 0, work_estimated > 0, work_completed <= work_estimated FROM performance_schema.events_stages_history WHERE event_name LIKE 'stage/innodb/alter table%' ORDER BY 1; This query would fail in MariaDB because there are no columns work_completed or work_estimated in the performance_schema.event_stages_history . There is also https://mariadb.com/kb/en/progress-reporting/ which might be worth supporting.

            People

              marko Marko Mäkelä
              jplindst Jan Lindström (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.